Non-Regression: Clearing data from chrome://settings doesn't automatically reflect in MD History |
|||||||||||
Issue descriptionVersion: 54.0.2803.0 OS: Ubuntu 14.04,Windows Pre-condition: Make sure Material design history is enabled from chrome://flags What steps will reproduce the problem? (1) Launch chrome >> Make sure you have some history in chrome://history (2) Go to chrome://settings in another tab >> Select "Clear Browsing data from" (3) Now go back to chrome://history and observe Expected: History should be cleared and "No history Found" message should be seen. Actual: Instead history doesn't get cleared unless u refresh the page. NOTE: In normal history no need of refreshing the page to see whether history is deleted or not. Raising this as Non-regression issue as same behaviour is seen from the introduction material design history [i.e 50.0.2638.0] Changelog url: https://chromium.googlesource.com/chromium/src/+log/50.0.2637.0..50.0.2638.0?pretty=fuller&n=10000 Suspecting https://codereview.chromium.org/1574063003
,
Jul 21 2016
msramek@: this is another case for additional observers to global browser data clearing
,
Jul 21 2016
,
Jul 22 2016
I believe we get notified on the page when data is deleted. We should make sure we refresh the list when that happens.
,
Jul 29 2016
,
Aug 4 2016
,
Aug 5 2016
Re #2: dbeam@, you didn't CC me, so I didn't see this :) And since I didn't know about this bug, I discovered it independently: https://docs.google.com/document/d/1Fd6CdBf6UMbYbkwSjEKyFOxew0Xid5IaT-QwnFchjig/ But I disagree with your assessment. History could be deleted from other instance of the history page, or even from another device, where observing BrowsingDataRemover doesn't help. So it's semantically wrong to focus on the act of deletion, instead we should observe the state of the storage. As tsergeant@ noted in #4, we already do this with HistoryService. For synced history, it's a bit harder - but SyncService already informs us about changes in synced tabs, so it could be extended to inform us about changes in synced history.
,
Aug 5 2016
sorry I didn't CC you yeah, agreed that it doesn't need to be CBD specific
,
Aug 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/570a8850893d9625d9aeb2b5fa7d27aa35f17d3b commit 570a8850893d9625d9aeb2b5fa7d27aa35f17d3b Author: lshang <lshang@chromium.org> Date: Fri Aug 19 01:48:32 2016 MD History: Refresh the list when clearing browsing data Automatically refresh history list when user clears browsing data from chrome://settings. BUG= 630164 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2200233003 Cr-Commit-Position: refs/heads/master@{#413020} [modify] https://crrev.com/570a8850893d9625d9aeb2b5fa7d27aa35f17d3b/chrome/browser/resources/md_history/app.crisper.js [modify] https://crrev.com/570a8850893d9625d9aeb2b5fa7d27aa35f17d3b/chrome/browser/resources/md_history/app.js [modify] https://crrev.com/570a8850893d9625d9aeb2b5fa7d27aa35f17d3b/chrome/browser/resources/md_history/history.js [modify] https://crrev.com/570a8850893d9625d9aeb2b5fa7d27aa35f17d3b/chrome/browser/resources/md_history/history_list.js [modify] https://crrev.com/570a8850893d9625d9aeb2b5fa7d27aa35f17d3b/chrome/browser/resources/md_history/list_container.js [modify] https://crrev.com/570a8850893d9625d9aeb2b5fa7d27aa35f17d3b/chrome/test/data/webui/md_history/history_list_test.js
,
Aug 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d39070b1ac01776e5a3800a9ef55fe43dce74225 commit d39070b1ac01776e5a3800a9ef55fe43dce74225 Author: msramek <msramek@chromium.org> Date: Fri Aug 26 09:46:29 2016 Make BrowsingDataHandler observe WebHistoryService deletions BrowsingDataHandler observes local history deletions, but not synced history deletions. In cases where there are no local history entries to delete, it can happen that the history page does not reload and it looks as if the deletion failed. See https://docs.google.com/document/d/1Fd6CdBf6UMbYbkwSjEKyFOxew0Xid5IaT-QwnFchjig/ for background. This CL 1. Adds an Observer subclass to the WebHistoryService. 2. Registers BrowsingHistoryHandler as a WebHistoryService::Observer; and since WebHistoryService's existence is based on whether history sync is enabled, we also register as a SyncServiceObserver. 3. Adds a test to browsing_history_handler_unittest.cc. Also tested manually on Android - seems to solve the problem described in the above mentioned document. BUG= 604114 , 630164 Review-Url: https://codereview.chromium.org/2263613002 Cr-Commit-Position: refs/heads/master@{#414679} [modify] https://crrev.com/d39070b1ac01776e5a3800a9ef55fe43dce74225/chrome/browser/ui/webui/browsing_history_handler.cc [modify] https://crrev.com/d39070b1ac01776e5a3800a9ef55fe43dce74225/chrome/browser/ui/webui/browsing_history_handler.h [modify] https://crrev.com/d39070b1ac01776e5a3800a9ef55fe43dce74225/chrome/browser/ui/webui/browsing_history_handler_unittest.cc [modify] https://crrev.com/d39070b1ac01776e5a3800a9ef55fe43dce74225/components/history/core/browser/BUILD.gn [modify] https://crrev.com/d39070b1ac01776e5a3800a9ef55fe43dce74225/components/history/core/browser/web_history_service.cc [modify] https://crrev.com/d39070b1ac01776e5a3800a9ef55fe43dce74225/components/history/core/browser/web_history_service.h [add] https://crrev.com/d39070b1ac01776e5a3800a9ef55fe43dce74225/components/history/core/browser/web_history_service_observer.h [modify] https://crrev.com/d39070b1ac01776e5a3800a9ef55fe43dce74225/components/history/core/test/fake_web_history_service.cc
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ce19cc272209840e306fde7485e5bc6f34432bb commit 8ce19cc272209840e306fde7485e5bc6f34432bb Author: Martin Sramek <msramek@chromium.org> Date: Thu Sep 01 09:07:16 2016 Make BrowsingDataHandler observe WebHistoryService deletions BrowsingDataHandler observes local history deletions, but not synced history deletions. In cases where there are no local history entries to delete, it can happen that the history page does not reload and it looks as if the deletion failed. See https://docs.google.com/document/d/1Fd6CdBf6UMbYbkwSjEKyFOxew0Xid5IaT-QwnFchjig/ for background. This CL 1. Adds an Observer subclass to the WebHistoryService. 2. Registers BrowsingHistoryHandler as a WebHistoryService::Observer; and since WebHistoryService's existence is based on whether history sync is enabled, we also register as a SyncServiceObserver. 3. Adds a test to browsing_history_handler_unittest.cc. Also tested manually on Android - seems to solve the problem described in the above mentioned document. TBR=tsergeant@chromium.org,lshang@chromium.org,sky@chromium.org,dbeam@chromium.org BUG= 604114 , 630164 Review-Url: https://codereview.chromium.org/2263613002 Cr-Commit-Position: refs/heads/master@{#414679} (cherry picked from commit d39070b1ac01776e5a3800a9ef55fe43dce74225) Review URL: https://codereview.chromium.org/2299133002 . Cr-Commit-Position: refs/branch-heads/2840@{#95} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/8ce19cc272209840e306fde7485e5bc6f34432bb/chrome/browser/ui/webui/browsing_history_handler.cc [modify] https://crrev.com/8ce19cc272209840e306fde7485e5bc6f34432bb/chrome/browser/ui/webui/browsing_history_handler.h [modify] https://crrev.com/8ce19cc272209840e306fde7485e5bc6f34432bb/chrome/browser/ui/webui/browsing_history_handler_unittest.cc [modify] https://crrev.com/8ce19cc272209840e306fde7485e5bc6f34432bb/components/history/core/browser/BUILD.gn [modify] https://crrev.com/8ce19cc272209840e306fde7485e5bc6f34432bb/components/history/core/browser/web_history_service.cc [modify] https://crrev.com/8ce19cc272209840e306fde7485e5bc6f34432bb/components/history/core/browser/web_history_service.h [add] https://crrev.com/8ce19cc272209840e306fde7485e5bc6f34432bb/components/history/core/browser/web_history_service_observer.h [modify] https://crrev.com/8ce19cc272209840e306fde7485e5bc6f34432bb/components/history/core/test/fake_web_history_service.cc
,
Sep 6 2016
Verified the issue on Windows 10 and Ubuntu 14.04 using chrome Dev # 54.0.2840.14 which worked as expected. Attached a screen cast for your reference. Following are the steps followed to reproduce the issue. ------------ 1. Launched chrome having some history in chrome://history 2. Navigated to chrome://settings in another tab and then selected "Clear Browsing data" from advance settings. 3. Went back to chrome://history tab and observed that it worked as expected and showed "No history entries found".
,
Sep 7 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ce19cc272209840e306fde7485e5bc6f34432bb commit 8ce19cc272209840e306fde7485e5bc6f34432bb Author: Martin Sramek <msramek@chromium.org> Date: Thu Sep 01 09:07:16 2016 Make BrowsingDataHandler observe WebHistoryService deletions BrowsingDataHandler observes local history deletions, but not synced history deletions. In cases where there are no local history entries to delete, it can happen that the history page does not reload and it looks as if the deletion failed. See https://docs.google.com/document/d/1Fd6CdBf6UMbYbkwSjEKyFOxew0Xid5IaT-QwnFchjig/ for background. This CL 1. Adds an Observer subclass to the WebHistoryService. 2. Registers BrowsingHistoryHandler as a WebHistoryService::Observer; and since WebHistoryService's existence is based on whether history sync is enabled, we also register as a SyncServiceObserver. 3. Adds a test to browsing_history_handler_unittest.cc. Also tested manually on Android - seems to solve the problem described in the above mentioned document. TBR=tsergeant@chromium.org,lshang@chromium.org,sky@chromium.org,dbeam@chromium.org BUG= 604114 , 630164 Review-Url: https://codereview.chromium.org/2263613002 Cr-Commit-Position: refs/heads/master@{#414679} (cherry picked from commit d39070b1ac01776e5a3800a9ef55fe43dce74225) Review URL: https://codereview.chromium.org/2299133002 . Cr-Commit-Position: refs/branch-heads/2840@{#95} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/8ce19cc272209840e306fde7485e5bc6f34432bb/chrome/browser/ui/webui/browsing_history_handler.cc [modify] https://crrev.com/8ce19cc272209840e306fde7485e5bc6f34432bb/chrome/browser/ui/webui/browsing_history_handler.h [modify] https://crrev.com/8ce19cc272209840e306fde7485e5bc6f34432bb/chrome/browser/ui/webui/browsing_history_handler_unittest.cc [modify] https://crrev.com/8ce19cc272209840e306fde7485e5bc6f34432bb/components/history/core/browser/BUILD.gn [modify] https://crrev.com/8ce19cc272209840e306fde7485e5bc6f34432bb/components/history/core/browser/web_history_service.cc [modify] https://crrev.com/8ce19cc272209840e306fde7485e5bc6f34432bb/components/history/core/browser/web_history_service.h [add] https://crrev.com/8ce19cc272209840e306fde7485e5bc6f34432bb/components/history/core/browser/web_history_service_observer.h [modify] https://crrev.com/8ce19cc272209840e306fde7485e5bc6f34432bb/components/history/core/test/fake_web_history_service.cc
,
Nov 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1ee6c76c90bfbe3cd842ac6d68cca5a6364738d commit a1ee6c76c90bfbe3cd842ac6d68cca5a6364738d Author: calamity <calamity@chromium.org> Date: Thu Nov 03 05:28:03 2016 [MD History] Fix deletion in heavily scrolled list. This CL fixes an issue where results would reload when an item was deleted in a history list that was scrolled beyond the first 'page'. This was happening because code that refreshed the results on external deletion was getting triggered for internal deletes due to the web history service. This has been fixed by disabling the reload when web history deletions are occurring, bringing it in line with the local history service. BUG= 660267 , 630164 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2455503004 Cr-Commit-Position: refs/heads/master@{#429529} [modify] https://crrev.com/a1ee6c76c90bfbe3cd842ac6d68cca5a6364738d/chrome/browser/ui/webui/browsing_history_handler.cc [modify] https://crrev.com/a1ee6c76c90bfbe3cd842ac6d68cca5a6364738d/chrome/browser/ui/webui/browsing_history_handler.h [modify] https://crrev.com/a1ee6c76c90bfbe3cd842ac6d68cca5a6364738d/chrome/browser/ui/webui/browsing_history_handler_unittest.cc [modify] https://crrev.com/a1ee6c76c90bfbe3cd842ac6d68cca5a6364738d/components/history/core/browser/web_history_service.cc
,
Nov 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eaf4e86ec35b1cb58dadc5dd0eff99f258412ce5 commit eaf4e86ec35b1cb58dadc5dd0eff99f258412ce5 Author: Dan Beam <dbeam@chromium.org> Date: Fri Nov 04 19:03:41 2016 [MD History] Fix deletion in heavily scrolled list. This CL fixes an issue where results would reload when an item was deleted in a history list that was scrolled beyond the first 'page'. This was happening because code that refreshed the results on external deletion was getting triggered for internal deletes due to the web history service. This has been fixed by disabling the reload when web history deletions are occurring, bringing it in line with the local history service. BUG= 660267 , 630164 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2455503004 Cr-Commit-Position: refs/heads/master@{#429529} (cherry picked from commit a1ee6c76c90bfbe3cd842ac6d68cca5a6364738d) Review URL: https://codereview.chromium.org/2478373002 . Cr-Commit-Position: refs/branch-heads/2883@{#461} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/eaf4e86ec35b1cb58dadc5dd0eff99f258412ce5/chrome/browser/ui/webui/browsing_history_handler.cc [modify] https://crrev.com/eaf4e86ec35b1cb58dadc5dd0eff99f258412ce5/chrome/browser/ui/webui/browsing_history_handler.h [modify] https://crrev.com/eaf4e86ec35b1cb58dadc5dd0eff99f258412ce5/chrome/browser/ui/webui/browsing_history_handler_unittest.cc [modify] https://crrev.com/eaf4e86ec35b1cb58dadc5dd0eff99f258412ce5/components/history/core/browser/web_history_service.cc
,
Nov 9 2016
Tested the same on win10 and Linux 14.04 chrome version 55.0.2883.44 - History cleared and "No history entries found" message is seen after clicking "clear browsing data" in chrome://settings Please find the screen cast |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by brajkumar@chromium.org
, Jul 21 2016