Autofill edit form isn't reset if user edits same issue |
|||||||
Issue descriptionVersion: 54.0.2803.0 Dev OS: Ubuntu 14.04,Windows What steps will reproduce the problem? (1)Launch Chrome>>Navigate to chrome://md-settings/autofill page>>Save address information (2)Click on edit link in three dot menu>>In edit address overlay,Edit any field>>Click on cancel button(donot save) (3)Now again go to edit overlay and observe previously edited text is still seen in the overlay (Please refer video) Expected:Edited text should not be saved in edit address overlay on clicking cancel. Actual:Instead edited text is seen in overlay even after clicking cancel and navigating back to edit overlay. This is a Non-regression issue as Edit/Add address is added from 54.0.2796.0 build. Changelog url: https://chromium.googlesource.com/chromium/src/+log/54.0.2795.0..54.0.2796.0?pretty=fuller&n=10000 Suspecting https://codereview.chromium.org/2109233002 from changelog. @hcarmona: Please confirm the issue. Attaching screen-cast for reference.
,
Jul 22 2016
,
Jul 22 2016
,
Jan 6 2017
So to clarify the issue: the form just isn't being reset if the user decides to make changes, click cancel, and then open the same item. We aren't saving anything when the user clicks cancel.
,
Jan 6 2017
,
Jan 9 2017
Correct, pressing cancel updates the local instance, but doesn't save changes.
,
Feb 2 2017
,
Feb 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/032c204569668e1ea6cf0604a99a073e074c8a62 commit 032c204569668e1ea6cf0604a99a073e074c8a62 Author: hcarmona <hcarmona@chromium.org> Date: Fri Feb 03 22:52:08 2017 Copy item so dialog won't update model on cancel. BUG= 630157 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2676573003 Cr-Commit-Position: refs/heads/master@{#448102} [modify] https://crrev.com/032c204569668e1ea6cf0604a99a073e074c8a62/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
,
Feb 6 2017
Issue on cancel is fixed for both credit cards and addresses. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by kavvaru@chromium.org
, Jul 21 2016