The piper automatic roller can break the tree. |
|||||
Issue descriptionThe automatic roll https://chromereviews.googleplex.com/471487013/ landed and broke the tree. This required reverting the CL, and blocking the autoroller.
,
Jul 21 2016
One difference is that the simulator-builder (which broke) is using GN, but not the piper-autoroller. We've had some issues recently with gyp and GN having different building options. Maybe for GoogleKit there is a -Wno-deprecated-declarations that remains for gyp and not for GN.
,
Jul 21 2016
Ha, I came to the same conclusion :) The good news is that GN's config is doing what we want. It's that line: https://cs.corp.google.com/piper///depot/google3/third_party/bling/master/ios_internal/google_internal/piper/googlemac_googlekit.gyp?type=cs&q=%23+Suppress+warnings+in+any+module+that+uses+GoogleKit.&sq=//depot/google3/third_party/bling/master&l=17 It forwards the no-deprecated-declarations to all dependent settings. I remove it and add the flag only for the GoogleKit targets that need it.
,
Jul 21 2016
,
Jul 21 2016
Sylvain, how can we have the Piper autoroller build with GN?
,
Sep 23 2016
What is the next action item? Add more test coverage in what the Piper autoroller runs?
,
Sep 23 2016
I guess the exact issue of this bug is moot now, since everything has been moved to GN.
,
Sep 23 2016
In the particular case in #2, yes that seems fixed. Yet we can still envision a roll that passes on the autoroller, but fails on the waterfall because a test was not run by the autoroller but was by the waterfall.
,
Oct 23 2016
We haven’t seen much issues with the autoroller landing stuff that breaks the tree. Let's close. If we want more tests on the piper-autoroller, we'll add them. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jif@chromium.org
, Jul 21 2016Owner: lpromero@chromium.org
Status: Assigned (was: Available)