New issue
Advanced search Search tips
Starred by 20 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug


Sign in to add a comment

Chromium-side TLS 1.3 work

Project Member Reported by davidben@chromium.org, Jul 21 2016 Back to list

Issue description

Tracking bug for changes we need to do in Chromium for TLS 1.3.
 
Blockedon: 630149
Cc: svaldez@chromium.org nhar...@chromium.org
Blockedon: 630150
Blockedon: 630151
Blockedon: 618035
Blockedon: 630165
Blockedon: 631988
Blockedon: 639495
Blockedon: 641225
Blockedon: 658863
Labels: M-56
Blockedon: boringssl:73
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99ce6308c09c342dbf6cdabda0bdbc1452ee036d

commit 99ce6308c09c342dbf6cdabda0bdbc1452ee036d
Author: davidben <davidben@chromium.org>
Date: Wed Nov 09 17:30:28 2016

Don't maintain a second level of timeouts.

This second level of timeouts is not maintained correctly in the case of
TLS 1.2 ticket renewals. BoringSSL does not extend ticket lifetimes on
ticket renewals because the master secret is unchanged, but BoringSSL's
default is two hours, while SSLClientSessionCache uses one hour. This
meant that TLS 1.2 ticket renewals currently extend the one hour
lifetime up to a two hour non-renewable lifetime.

This makes no sense. Instead, have SSLClientSessionCache query
SSL_SESSION timeout fields. Then configure the SSL_CTX to match the old
timeout to preserve the existing behavior. (Though I suspect one vs two
hours isn't a big difference and we could just leave it at BoringSSL
defaults.)

Do this both to fix our TLS 1.2 ticket renewal policy and prepare for
TLS 1.3 which will involve a more complex timeout policy. (Resumptions
do an ECDH and renewals incorporate that key material, so longer and
renewable lifetimes makes sense, but we will still need a non-renewable
timeout for when we require a fresh signature.)

BUG=630147

Review-Url: https://codereview.chromium.org/2480813002
Cr-Commit-Position: refs/heads/master@{#430961}

[modify] https://crrev.com/99ce6308c09c342dbf6cdabda0bdbc1452ee036d/net/socket/ssl_client_socket_impl.cc
[modify] https://crrev.com/99ce6308c09c342dbf6cdabda0bdbc1452ee036d/net/ssl/ssl_client_session_cache.cc
[modify] https://crrev.com/99ce6308c09c342dbf6cdabda0bdbc1452ee036d/net/ssl/ssl_client_session_cache.h
[modify] https://crrev.com/99ce6308c09c342dbf6cdabda0bdbc1452ee036d/net/ssl/ssl_client_session_cache_unittest.cc

Blockedon: 676353
Blockedon: 347402
Blockedon: 677254
Blockedon: 677326
Blockedon: 792204
 Issue 807276  has been merged into this issue.
Blockedon: 828965

Sign in to add a comment