The context is: https://github.com/w3c/webcomponents/issues/530 Currently, Blink bans <link ref="stylesheet" href="..."> in a shadow tree. We have to relax the condition.
The context is: https://github.com/w3c/webcomponents/issues/530 Currently, Blink bans <link rel="stylesheet" href="..."> in a shadow tree. We have to relax the condition.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/337e2547babe2c6a27130ad593de52f730848b74 commit 337e2547babe2c6a27130ad593de52f730848b74 Author: hayato <hayato@chromium.org> Date: Thu Jul 21 09:13:54 2016 Remove HTMLLinkElement::m_isInShadowTree member variable This member variable can be removed without any behavior change. BUG= 630141 Review-Url: https://codereview.chromium.org/2169803002 Cr-Commit-Position: refs/heads/master@{#406807} [modify] https://crrev.com/337e2547babe2c6a27130ad593de52f730848b74/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp [modify] https://crrev.com/337e2547babe2c6a27130ad593de52f730848b74/third_party/WebKit/Source/core/html/HTMLLinkElement.h
Issue 313458 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/119fe0f585d87fd4d86bc4765e3b947ce3fa93b2 commit 119fe0f585d87fd4d86bc4765e3b947ce3fa93b2 Author: hayato <hayato@chromium.org> Date: Fri Jul 22 08:51:08 2016 Remove the unnecessary DCHECK(..), which is guaranteed to be true by the previous line This DCHECK just rephrases the result of the previous line. BUG= 630141 Review-Url: https://codereview.chromium.org/2174693002 Cr-Commit-Position: refs/heads/master@{#407104} [modify] https://crrev.com/119fe0f585d87fd4d86bc4765e3b947ce3fa93b2/third_party/WebKit/Source/core/dom/StyleEngine.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9461cb39b01538d866e99df243fbe5dc1a802290 commit 9461cb39b01538d866e99df243fbe5dc1a802290 Author: hayato <hayato@chromium.org> Date: Mon Jul 25 02:28:46 2016 Fix the condition to call removePandingSheet() in LinkStyle::setCSSStyleSheet It looks that https://codereview.chromium.org/1285413002 is not a correct fix. The right approach is to check "in a document tree" here because there is a possibility that a link element moved from a document tree to a disconnected non-shadow tree. TEST=None. It might be difficult to write a meaningful non-flaky test. BUG= 630141 Review-Url: https://codereview.chromium.org/2171293002 Cr-Commit-Position: refs/heads/master@{#407398} [modify] https://crrev.com/9461cb39b01538d866e99df243fbe5dc1a802290/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d90f310e3bdfc51391a7c34d1982c8f23845090 commit 0d90f310e3bdfc51391a7c34d1982c8f23845090 Author: hayato <hayato@chromium.org> Date: Mon Jul 25 09:39:30 2016 Add a test for canceling a pending stylesheet loading of a link element This test should be added together with https://codereview.chromium.org/2171293002 BUG= 630141 Review-Url: https://codereview.chromium.org/2173413002 Cr-Commit-Position: refs/heads/master@{#407439} [add] https://crrev.com/0d90f310e3bdfc51391a7c34d1982c8f23845090/third_party/WebKit/Source/web/tests/LinkElementLoadingTest.cpp [modify] https://crrev.com/0d90f310e3bdfc51391a7c34d1982c8f23845090/third_party/WebKit/Source/web/web.gypi
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10f38919e18ed8fa5b4fa96834a024cfdd9a0667 commit 10f38919e18ed8fa5b4fa96834a024cfdd9a0667 Author: hayato <hayato@chromium.org> Date: Tue Jul 26 08:56:23 2016 Remove unused code from HTMLLinkElement This should be removed in https://codereview.chromium.org/242883002 BUG= 357586 , 630141 Review-Url: https://codereview.chromium.org/2181263002 Cr-Commit-Position: refs/heads/master@{#407739} [modify] https://crrev.com/10f38919e18ed8fa5b4fa96834a024cfdd9a0667/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0cecf3ac0c7adf7a7c78eeb02cc75d380a9ce4d commit f0cecf3ac0c7adf7a7c78eeb02cc75d380a9ce4d Author: hayato <hayato@chromium.org> Date: Thu Aug 04 06:34:32 2016 Allow <link rel=stylesheet> in a connected shadow tree See https://github.com/w3c/webcomponents/issues/530. We have relaxed the condition. "Web-Facing Change PSA" mail in blink-dev is: https://groups.google.com/a/chromium.org/d/msg/blink-dev/b7g62d2yqWo/2itpAFafBgAJ Regarding a browsing context, this CL does not change any behavior. That should be another concern and should be investigated later. See also https://github.com/w3c/webcomponents/issues/535. "title= attribute" is ignored completely for <link rel=stylesheet>. BUG= 630141 Review-Url: https://codereview.chromium.org/2177163002 Cr-Commit-Position: refs/heads/master@{#409728} [delete] https://crrev.com/279f12d293087b7619089ecbe418e83df9d04a76/third_party/WebKit/LayoutTests/fast/dom/shadow/link-in-shadow-tree-expected.txt [delete] https://crrev.com/279f12d293087b7619089ecbe418e83df9d04a76/third_party/WebKit/LayoutTests/fast/dom/shadow/link-in-shadow-tree.html [add] https://crrev.com/f0cecf3ac0c7adf7a7c78eeb02cc75d380a9ce4d/third_party/WebKit/LayoutTests/shadow-dom/link-title.html [add] https://crrev.com/f0cecf3ac0c7adf7a7c78eeb02cc75d380a9ce4d/third_party/WebKit/LayoutTests/shadow-dom/link.html [modify] https://crrev.com/f0cecf3ac0c7adf7a7c78eeb02cc75d380a9ce4d/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp [modify] https://crrev.com/f0cecf3ac0c7adf7a7c78eeb02cc75d380a9ce4d/third_party/WebKit/Source/core/dom/ShadowTreeStyleSheetCollection.cpp [modify] https://crrev.com/f0cecf3ac0c7adf7a7c78eeb02cc75d380a9ce4d/third_party/WebKit/Source/core/dom/StyleEngine.cpp [modify] https://crrev.com/f0cecf3ac0c7adf7a7c78eeb02cc75d380a9ce4d/third_party/WebKit/Source/core/dom/StyleSheetCandidate.cpp [modify] https://crrev.com/f0cecf3ac0c7adf7a7c78eeb02cc75d380a9ce4d/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
Comment 1 by hayato@chromium.org
, Jul 21 2016