WorkerEventQueue::EventDispatcherTask should not inherit ExecutionContextTask |
|||
Issue descriptionThis is blocking issue 625927 to replace ExecutionContextTask with WTF::Function.
,
Jul 28 2016
Probably we can work around this, by - making WorkerEventQueue::EventDispatcherTask non-ExecutionContextTask, and - using createSameThreadTask() with std::unique_ptr<WorkerEventQueue::EventDispatcherTask>. Similar thing is done in https://codereview.chromium.org/1976083002.
,
Aug 3 2016
tzik@ is working on this issue: https://codereview.chromium.org/2209613002/
,
Aug 4 2016
,
Aug 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3697042db3e1ee433545c06bed5aee95657ebc16 commit 3697042db3e1ee433545c06bed5aee95657ebc16 Author: tzik <tzik@chromium.org> Date: Thu Aug 04 07:41:56 2016 Remove WorkerEventQueue::EventDispatcherTask EventDispatcherTask is the last blocker of ExecutionContextTask removal. It holds an Event and WorkerEventQueue instance, and makes the Event cancellable. This CL reimplements the cancellation mechanism without the custom ExecutionContextTask and removes the custom one. BUG= 630139 Review-Url: https://codereview.chromium.org/2209613002 Cr-Commit-Position: refs/heads/master@{#409732} [modify] https://crrev.com/3697042db3e1ee433545c06bed5aee95657ebc16/third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp [modify] https://crrev.com/3697042db3e1ee433545c06bed5aee95657ebc16/third_party/WebKit/Source/core/workers/WorkerEventQueue.h
,
Aug 5 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by nhiroki@chromium.org
, Jul 21 2016Labels: OS-All