New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630139 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 625927



Sign in to add a comment

WorkerEventQueue::EventDispatcherTask should not inherit ExecutionContextTask

Project Member Reported by nhiroki@chromium.org, Jul 21 2016

Issue description

This is blocking  issue 625927  to replace ExecutionContextTask with WTF::Function.
 
Cc: yuryu@chromium.org hirosh...@chromium.org tzik@chromium.org
Labels: OS-All
Probably we can work around this, by
- making WorkerEventQueue::EventDispatcherTask non-ExecutionContextTask, and
- using createSameThreadTask() with std::unique_ptr<WorkerEventQueue::EventDispatcherTask>.

Similar thing is done in https://codereview.chromium.org/1976083002.

tzik@ is working on this issue: https://codereview.chromium.org/2209613002/
Cc: -tzik@chromium.org
Owner: tzik@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3697042db3e1ee433545c06bed5aee95657ebc16

commit 3697042db3e1ee433545c06bed5aee95657ebc16
Author: tzik <tzik@chromium.org>
Date: Thu Aug 04 07:41:56 2016

Remove WorkerEventQueue::EventDispatcherTask

EventDispatcherTask is the last blocker of ExecutionContextTask removal.
It holds an Event and WorkerEventQueue instance, and makes the Event
cancellable.

This CL reimplements the cancellation mechanism without the custom
ExecutionContextTask and removes the custom one.

BUG= 630139 

Review-Url: https://codereview.chromium.org/2209613002
Cr-Commit-Position: refs/heads/master@{#409732}

[modify] https://crrev.com/3697042db3e1ee433545c06bed5aee95657ebc16/third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp
[modify] https://crrev.com/3697042db3e1ee433545c06bed5aee95657ebc16/third_party/WebKit/Source/core/workers/WorkerEventQueue.h

Comment 6 by tzik@chromium.org, Aug 5 2016

Status: Fixed (was: Started)

Sign in to add a comment