New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 630125 link

Starred by 4 users
Status: Fixed
Owner:
calamity@chromium.org
Closed: Jul 2016
Cc:
calamity@chromium.org
nyerramilli@chromium.org
█ tsergeant@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

MD History search URLs don't work sometimes

Project Member Reported by calamity@chromium.org, Jul 21 2016 
In certain cases, (I got a repro with a signed out profile with ~30 history entries) using a search URL on the main history page e.g chrome://history?q=google will still show all history results.

This is due to the results from the empty query made at startup being processed after the search query results, overriding them.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45eaf49a7cea5e2188ecacb01c0579d7035963ac

commit 45eaf49a7cea5e2188ecacb01c0579d7035963ac
Author: calamity <calamity@chromium.org>
Date: Mon Jul 25 03:47:11 2016

[MD History] Force history results to be processed in order.

This CL fixes an issue where history results could be returned in
quick succession but the later result set would be processed first due
to the earlier result set being deferred to the next event loop. This
was causing problems with loading search URLs that loaded too quickly.

This has been fixed by using a single Promise to process all history
results rather than instantiating new ones for each result set.

BUG= 630125 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2171693002
Cr-Commit-Position: refs/heads/master@{#407411}

[modify] https://crrev.com/45eaf49a7cea5e2188ecacb01c0579d7035963ac/chrome/browser/resources/md_history/history.js
[modify] https://crrev.com/45eaf49a7cea5e2188ecacb01c0579d7035963ac/chrome/test/data/webui/md_history/md_history_browsertest.js

Comment 2 by calamity@chromium.org, Jul 25 2016

Cc: msrchandra@chromium.org calamity@chromium.org ranjitkan@chromium.org nyerramilli@chromium.org
 Issue 630159  has been merged into this issue.

Comment 3 by calamity@chromium.org, Jul 25 2016

Status: Fixed (was: Started)
►

Sign in to add a comment