MD history: up/down should change the selection inside the "More actions..." menu |
||||||
Issue descriptionrepro steps: 0) click "More actions..." on a history visit 1) attempt to move between menu items with up/down what do you expect? that pressing up goes to the next menu item above or wraps around (or works however chrome://downloads' more actions work today) what happens instead? up/down do nothing note: maybe this is because history uses a <cr-shared-menu> instead of <paper-menu>?
,
Jul 21 2016
Yup, I'll make the behavior match <paper-menu-button> and <paper-menu>.
,
Aug 1 2016
,
Aug 15 2016
Issue 637243 has been merged into this issue.
,
Sep 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8cf11a02e256b61c86a23e9c6126ff3183a628c5 commit 8cf11a02e256b61c86a23e9c6126ff3183a628c5 Author: tsergeant <tsergeant@chromium.org> Date: Thu Sep 29 08:23:28 2016 MD WebUI: Use arrow keys for navigation in cr-shared-menu, close on tab This brings the behavior of the more actions menu in MD History closer in line with other menus in Chrome. BUG= 630102 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2272553002 Cr-Commit-Position: refs/heads/master@{#421777} [modify] https://crrev.com/8cf11a02e256b61c86a23e9c6126ff3183a628c5/chrome/browser/resources/md_history/lazy_load.crisper.js [modify] https://crrev.com/8cf11a02e256b61c86a23e9c6126ff3183a628c5/chrome/browser/resources/md_history/lazy_load.vulcanized.html [modify] https://crrev.com/8cf11a02e256b61c86a23e9c6126ff3183a628c5/chrome/test/data/webui/cr_elements/cr_shared_menu_tests.js [modify] https://crrev.com/8cf11a02e256b61c86a23e9c6126ff3183a628c5/ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.html [modify] https://crrev.com/8cf11a02e256b61c86a23e9c6126ff3183a628c5/ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js
,
Sep 30 2016
,
Oct 28 2016
Verified on ChromeOS 8939.0.0, 56.0.2902.0 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dbeam@chromium.org
, Jul 21 2016