No way to add a user outside of old Options in Canary |
||||
Issue descriptionVersion: 54.0.2802.2 OS: Windows 10 I can't figure out how to create a new user, or add a new supervised user. I'm signed in to a profile in my Canary build but, aside from the old Options page (chrome://settings-frame) I can't find any way of adding users. I've tried resetting all flags to default, also tried enabling --enable-new-profile-management. The MD Settings People section has a link to manage existing supervised users, but nothing for creating a new user or a new supervised user. The profile manager only has options to remove existing users and browse as guest. http://imgur.com/a/JrhK6 Is this not yet implemented? I've seen references to testing user creation in the MD profile manager in other issues (also that it launched in 53), so I'm kinda confused.
,
Jul 21 2016
Thanks, you're absolutely right. Enabling "Let anyone add a person" in Options unhides the "Add person" button in the profile manager, and that button lets me create a supervised user if enable-material-design-user-manager is on. Sounds like the bug is this: When that checkbox is false, the profile manager only lets you add a person if you're signed in **and at least one supervised user exists.** So because I don't have any supervised users, the "add a person" button is unavailable while "Let anyone add a person" is off. Presumably this is a logic error, because there is no "unlocked" profile since the concept of locking doesn't exist without supervised users. In other words, that checkbox should have no effect when there are no supervised user profiles, but instead it just disables everything for everyone.
,
Jul 22 2016
Those two checkboxes were not ideal like you said. and That's why we decided to remove them in the new settings page. Now 'Add Person' and 'Browse As Guest' buttons should always show. And only if all "custodian" profiles are locked, you get an error message asking you to unlock a profile before going ahead with that action. This is much more logical behavior. Feel free to test it. Let's keep this bug open and I'll file the fix for settings the prefs to true by default again it.
,
Aug 3 2016
,
Aug 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c440d2c549779305eb5439ae451158e694b5214 commit 8c440d2c549779305eb5439ae451158e694b5214 Author: mahmadi <mahmadi@chromium.org> Date: Fri Aug 05 18:00:18 2016 Clears GuestModeEnabled and AddPersonEnabled user prefs if MD settings is enabled. MD settings gets rid of the checkboxes that enabled browsing as guest and adding new profiles. This CL clears the two prefs previously set by users. This should have no effect if the prefs are set by policy. This logic can be removed once all users' prefs are cleared BUG= 630100 Review-Url: https://codereview.chromium.org/2207003002 Cr-Commit-Position: refs/heads/master@{#410105} [modify] https://crrev.com/8c440d2c549779305eb5439ae451158e694b5214/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc [modify] https://crrev.com/8c440d2c549779305eb5439ae451158e694b5214/tools/metrics/actions/actions.xml
,
Aug 5 2016
,
Aug 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c14818cae6553f32e6c9cb756e58d0831126e4aa commit c14818cae6553f32e6c9cb756e58d0831126e4aa Author: anthonyvd <anthonyvd@chromium.org> Date: Fri Aug 05 18:13:24 2016 Revert of Clears GuestModeEnabled and AddPersonEnabled user prefs if MD settings is enabled (patchset #4 id:60001 of https://codereview.chromium.org/2207003002/ ) Reason for revert: Reverting this CL because it breaks compile on the following bot: https://build.chromium.org/p/chromium.gpu/builders/GPU%20Mac%20Builder/builds/66935 Original issue's description: > Clears GuestModeEnabled and AddPersonEnabled user prefs if MD settings is enabled. > > MD settings gets rid of the checkboxes that enabled browsing as guest and adding new profiles. This CL clears the two prefs previously set by users. This should have no effect if the prefs are set by policy. > > This logic can be removed once all users' prefs are cleared > > BUG= 630100 > > Committed: https://crrev.com/8c440d2c549779305eb5439ae451158e694b5214 > Cr-Commit-Position: refs/heads/master@{#410105} TBR=rogerta@chromium.org,rkaplow@chromium.org,michaelpg@chromium.org,mahmadi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 630100 Review-Url: https://codereview.chromium.org/2218173002 Cr-Commit-Position: refs/heads/master@{#410111} [modify] https://crrev.com/c14818cae6553f32e6c9cb756e58d0831126e4aa/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc [modify] https://crrev.com/c14818cae6553f32e6c9cb756e58d0831126e4aa/tools/metrics/actions/actions.xml
,
Aug 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/131e08f78c7d001d959dce36bcbcbc3f988395ab commit 131e08f78c7d001d959dce36bcbcbc3f988395ab Author: mahmadi <mahmadi@chromium.org> Date: Fri Aug 05 19:36:08 2016 Clears GuestModeEnabled and AddPersonEnabled user prefs if MD settings is enabled. MD settings gets rid of the checkboxes that enabled browsing as guest and adding new profiles. This CL clears the two prefs previously set by users. This should have no effect if the prefs are set by policy. This logic can be removed once all users' prefs are cleared BUG= 630100 Committed: https://crrev.com/8c440d2c549779305eb5439ae451158e694b5214 Review-Url: https://codereview.chromium.org/2207003002 Cr-Original-Commit-Position: refs/heads/master@{#410105} Cr-Commit-Position: refs/heads/master@{#410144} [modify] https://crrev.com/131e08f78c7d001d959dce36bcbcbc3f988395ab/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc [modify] https://crrev.com/131e08f78c7d001d959dce36bcbcbc3f988395ab/tools/metrics/actions/actions.xml |
||||
►
Sign in to add a comment |
||||
Comment 1 by mahmadi@chromium.org
, Jul 21 2016Status: Assigned (was: Untriaged)