New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 630075 link

Starred by 2 users
Status: Fixed
Owner:
█ jaepark@google.com
Email to this user bounced
Closed: Jul 2016
Cc:
ajha@chromium.org
█ jaepark@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

PDF plugin does not handle ctrl + shift + left click on links

Project Member Reported by jaepark@google.com, Jul 21 2016 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.106 Safari/537.36

Steps to reproduce the problem:
1. Open a PDF with links, e.g. the one in  bug 71754 
2. ctrl + shift + left click on a link

What is the expected behavior?
Link opens in a new foreground tab.

What went wrong?
Link opens in a new background tab.

Did this work before? N/A 

Chrome version: 51.0.2704.106  Channel: canary
OS Version: 
Flash Version: Shockwave Flash 22.0 r0

Comment 1 by ajha@chromium.org, Jul 21 2016

Cc: jaepark@google.com ajha@chromium.org
Components: Internals>Plugins>PDF
Labels: -Type-Bug -Pri-2 M-54 hasbisect OS-Mac OS-Windows Pri-1 Type-Bug-Regression
Owner: thestig@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this on the latest canary: 54.0.2803.0 on Windows-7, Mac OS 10.11.5 as well. Same works fine on the latest stable/beta(52.0.2743.82) and the latest Dev(53.0.2785.21) across all OS.

Regressed in M-54.

Last good build: 54.0.2799.0
First bad build: 54.0.2800.0

Changelog: https://chromium.googlesource.com/chromium/src/+log/0db21f9f2bc7bee9c40c64c5ad192297d32a567c..009cf62ee240d54d1f840d3075697ea8c8974164

https://codereview.chromium.org/2149153003 is the related change that changed the behavior.

jaepark@: Could you please take a look at this as you authored this change.

Unable to assign to jaepark@ hence assigning to thestig@(reviewer of the cl) for more inputs.
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 21 2016

Labels: Hotlist-Google
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b44ac414765de1d882f295006cfe2687872320b

commit 1b44ac414765de1d882f295006cfe2687872320b
Author: jaepark <jaepark@google.com>
Date: Tue Jul 26 17:24:01 2016

Handle ctrl + shift + left click on links in PDF.

Ctrl + shift + left (or shift + middle) click on links should open a new
foreground tab.

BUG= 630075 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2166193002
Cr-Commit-Position: refs/heads/master@{#407840}

[modify] https://crrev.com/1b44ac414765de1d882f295006cfe2687872320b/chrome/browser/pdf/pdf_extension_test.cc
[modify] https://crrev.com/1b44ac414765de1d882f295006cfe2687872320b/chrome/browser/resources/pdf/navigator.js
[modify] https://crrev.com/1b44ac414765de1d882f295006cfe2687872320b/chrome/browser/resources/pdf/pdf.js
[modify] https://crrev.com/1b44ac414765de1d882f295006cfe2687872320b/chrome/test/data/pdf/navigator_test.js
[modify] https://crrev.com/1b44ac414765de1d882f295006cfe2687872320b/pdf/BUILD.gn
[modify] https://crrev.com/1b44ac414765de1d882f295006cfe2687872320b/pdf/DEPS
[modify] https://crrev.com/1b44ac414765de1d882f295006cfe2687872320b/pdf/out_of_process_instance.cc
[modify] https://crrev.com/1b44ac414765de1d882f295006cfe2687872320b/pdf/out_of_process_instance.h
[modify] https://crrev.com/1b44ac414765de1d882f295006cfe2687872320b/pdf/pdf.gyp
[modify] https://crrev.com/1b44ac414765de1d882f295006cfe2687872320b/pdf/pdf_engine.h
[modify] https://crrev.com/1b44ac414765de1d882f295006cfe2687872320b/pdf/pdfium/pdfium_engine.cc
[modify] https://crrev.com/1b44ac414765de1d882f295006cfe2687872320b/pdf/preview_mode_client.cc
[modify] https://crrev.com/1b44ac414765de1d882f295006cfe2687872320b/pdf/preview_mode_client.h

Comment 4 by thestig@chromium.org, Jul 26 2016

Owner: ----
Status: Fixed (was: Assigned)

Comment 5 by thestig@chromium.org, Aug 11 2016

Owner: jaepark@google.com
►

Sign in to add a comment