Certain links don't open the intent disambig dialog |
|||||||||||
Issue descriptionSee b/30258209.
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef206ad2f2bd182205b4adb5580c00e7967c4fd8 commit ef206ad2f2bd182205b4adb5580c00e7967c4fd8 Author: kenobi <kenobi@chromium.org> Date: Fri Jul 22 20:49:28 2016 [arc-intents] Adjust link-click detection code. Use the page transition, which seems more reliable, rather than the HasUserGesture method, to detect whether a given navigation event was spawned by the user clicking on a link. BUG= 630072 Review-Url: https://codereview.chromium.org/2165193002 Cr-Commit-Position: refs/heads/master@{#407256} [modify] https://crrev.com/ef206ad2f2bd182205b4adb5580c00e7967c4fd8/chrome/browser/chromeos/arc/arc_navigation_throttle.cc
,
Jul 22 2016
,
Jul 23 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c5f09f8ae5b75efe1b6da05a746a0bbd41a8be7 commit 3c5f09f8ae5b75efe1b6da05a746a0bbd41a8be7 Author: Ben Kwa <kenobi@google.com> Date: Mon Jul 25 15:33:01 2016 [arc-intents] Adjust link-click detection code. Use the page transition, which seems more reliable, rather than the HasUserGesture method, to detect whether a given navigation event was spawned by the user clicking on a link. BUG= 630072 Review-Url: https://codereview.chromium.org/2165193002 Cr-Commit-Position: refs/heads/master@{#407256} (cherry picked from commit ef206ad2f2bd182205b4adb5580c00e7967c4fd8) Review URL: https://codereview.chromium.org/2175353002 . Cr-Commit-Position: refs/branch-heads/2785@{#327} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/3c5f09f8ae5b75efe1b6da05a746a0bbd41a8be7/chrome/browser/chromeos/arc/arc_navigation_throttle.cc
,
Jul 27 2016
,
Jan 21 2017
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by kenobi@chromium.org
, Jul 22 2016