New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630071 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Have nested step failure status displayed in the wrapper step

Project Member Reported by mikec...@chromium.org, Jul 21 2016

Issue description

I love nested steps. But if there is a failure in a nested step, the outer nest step is still green. This can make it very hard to find which step actually failed without just expanding all the nested steps.

I would like it if it were possible to propagate the step_result.presentation.status outward. If an inner step fails, it would be nice to have the containing step show up as red.

Dont know how feasible this is. But I'd like to look into it.

https://cs.chromium.org/chromium/infra/recipes-py/recipe_modules/step/api.py?q=step+nest+api.py&sq=package:chromium&dr=CSs&l=76
 
Cc: martiniss@chromium.org
+martiniss: another data point re nested steps
It looks like you can manually set the status at least.
I'm going to see if this works....
https://codereview.chromium.org/2170903002

However, what I think should happen, is the nest step shows up as Red automatically if any nested step is red.
Additionally, the runtime of the nest step should probably be set to the total runtime of all nested steps. Currently, it just shows up as (0 seconds).
We've had some requests for more functionality for nested steps. I vaguely remember some reasons that we haven't added more features to this, but I'll chat with other recipes people about doing some of this.
Components: Tests>Fails

Comment 6 by stip@chromium.org, Feb 10 2017

Cc: -stip@chromium.org

Sign in to add a comment