New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630068 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Change the HOST of translate from translate.google.com to translate.googleapis.com

Project Member Reported by ftang@chromium.org, Jul 21 2016

Issue description

Comment 1 by ftang@chromium.org, Jul 21 2016

Cc: barakt@google.com

Comment 2 by barakt@google.com, Jul 21 2016

ftang - zkoch confimed that we can merge it into M53. Can you please submit the CL and request-merge-53?

Thanks,

Barak
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/149a3740a58de22cd0ebbd0fe962a9f116c2e776

commit 149a3740a58de22cd0ebbd0fe962a9f116c2e776
Author: ftang <ftang@chromium.org>
Date: Fri Jul 22 22:09:07 2016

switch translate element loading domain

BUG= 630068 

Review-Url: https://codereview.chromium.org/2167843005
Cr-Commit-Position: refs/heads/master@{#407279}

[modify] https://crrev.com/149a3740a58de22cd0ebbd0fe962a9f116c2e776/components/translate/core/browser/translate_script.cc

Comment 5 by ftang@chromium.org, Jul 22 2016

Labels: Merge-Request-53

Comment 6 by ftang@chromium.org, Jul 22 2016

Components: UI>Browser>Translate
Summary: Change the HOST of translate from translate.google.com to translate.googleapis.com (was: UI>Browser>Translate)

Comment 7 by gov...@chromium.org, Jul 22 2016

Before we approve merge to M53, Could you please confirm whether this change is baked/verified in Canary and safe to merge?

Also is this change applicable to all OS or any specific OS?

Comment 8 by ftang@chromium.org, Jul 23 2016

To all OS. 

Comment 9 by gov...@chromium.org, Jul 23 2016

Labels: OS-All

Comment 10 by dimu@chromium.org, Jul 23 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Cc: nyerramilli@chromium.org
 ftang@, could you please merge this to M53 branch 2785 ASAP. Thank you.
Please merge your change to M53 branch 2785 before 5:00 PM PDT today (Monday) so we can pick up for last M53 Dev release tomorrow. Thank you.

Comment 13 by ftang@chromium.org, Jul 25 2016

groby- could you help to merge this to M53 today?
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 26 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/def9f527d1c220c72e0e9df7cd854eab22962705

commit def9f527d1c220c72e0e9df7cd854eab22962705
Author: Rachel Blum <groby@google.com>
Date: Mon Jul 25 23:58:53 2016

switch translate element loading domain

BUG= 630068 

Review-Url: https://codereview.chromium.org/2167843005
Cr-Commit-Position: refs/heads/master@{#407279}
(cherry picked from commit 149a3740a58de22cd0ebbd0fe962a9f116c2e776)

Review URL: https://codereview.chromium.org/2183623002 .

Cr-Commit-Position: refs/branch-heads/2785@{#348}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/def9f527d1c220c72e0e9df7cd854eab22962705/components/translate/core/browser/translate_script.cc

Labels: Needs-Feedback
groby@ : Could you please let us know the steps to verify the issue if this can be tested from TE end.

Comment 16 by ftang@chromium.org, Jul 26 2016

Very simple to verify the change is good. Just verify translate feature is still working. If the change is wrong, the feature will be totally broken. There are no way to see which exact host the chrome load the script so there are no way for TE to observe beside that.
Cc: pbomm...@chromium.org
Verified that translate bubble was seen and page got translated to English and vise versaon Windows 7, Mac and Linux with Chrome 53.0.2785.30,below are the languages which I have checked:

1. Chinese(traditional and simplified)(Sina.com)
2. Japanese(www.yahoo.co.jp) 
3. German(http://www.bild.de/wa/ll/bild-de/unangemeldet-42925516.bild.html)
4. Telugu (http://www.eenadu.net/district/main.aspx?dsname=hyderabad)
5. Hindi (http://www.jagran.com/)
6. Korean (Naver.com)
7. Arabic (http://www.aljazeera.net/portal)
8. Hebrew (http://www.haaretz.co.il/)

Steps followed :
1. Install 53.0.2785.30
2. Open Chrome download page "https://www.google.com/chrome/browser/desktop/index.html' or multiple other webpages as stated above
3. navigate to bottom of the page and change the language to see the translate bubble.
4. Select translate to English and verify that the page is getting translated.
Labels: -Needs-Feedback TE-Verified-M53 TE-Verified-53.0.2785.30
Thanks Frank for the update and Prudhvi to verify it.
Adding respective TE-verified labels for the same.

Comment 19 by ftang@chromium.org, Jul 29 2016

Status: Fixed (was: Assigned)
Components: -UI>Browser>Translate UI>Browser>Language>Translate

Sign in to add a comment