MD WebUI: drop visual changes based on :hover (other than cursor: pointer) |
||||||||
Issue descriptionWe recently decided to stop showing a difference of background-color on :hover for things like dropdowns. This is because in cases where changing the text style is hard to do without affecting layout (i.e. the text getting wider or taller causes problems), things like :focus look the same as :hover when both use a change in background-color. Additionally, :hover outside of menus (i.e. in Alan's words "any bkg hovers on rows or cards") weren't really meant to be there (and are probably from a time where MD on desktop was less defined). TL;DR - we're dropping :hover that changes background-color throughout webui (I've already removed it from downloads[1]). See also: bug 610630 [1] https://codereview.chromium.org/2157723002/
,
Jul 21 2016
i lied, they all come to this bug
,
Jul 21 2016
bettes@ also let me drop :hover shadows on avatars
,
Jul 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ff90f4a2f6f30b5e01f9bef16cbe27efce16b01 commit 2ff90f4a2f6f30b5e01f9bef16cbe27efce16b01 Author: dbeam <dbeam@chromium.org> Date: Thu Jul 21 03:18:24 2016 MD Settings: ensure <a is="action-link"> have no :hover underline tl;dr - the style loading order matters, action_link.css must come before <style include="settings-shared">. R=hcarmona@chromium.org BUG= 630067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2167043002 Cr-Commit-Position: refs/heads/master@{#406755} [modify] https://crrev.com/2ff90f4a2f6f30b5e01f9bef16cbe27efce16b01/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html [modify] https://crrev.com/2ff90f4a2f6f30b5e01f9bef16cbe27efce16b01/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html [modify] https://crrev.com/2ff90f4a2f6f30b5e01f9bef16cbe27efce16b01/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html [modify] https://crrev.com/2ff90f4a2f6f30b5e01f9bef16cbe27efce16b01/chrome/browser/resources/settings/search_engines_page/search_engines_page.html [modify] https://crrev.com/2ff90f4a2f6f30b5e01f9bef16cbe27efce16b01/chrome/browser/resources/settings/settings_shared_css.html
,
Jul 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d6e1f491447569b7fd19be8f1d568a56d8cb4e7 commit 2d6e1f491447569b7fd19be8f1d568a56d8cb4e7 Author: dbeam <dbeam@chromium.org> Date: Thu Jul 21 03:34:55 2016 MD Settings: remove special-casing of links on passwords page They should be the same color as other links and have no underline on :hover. R=hcarmona@chromium.org BUG= 630067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2165183002 Cr-Commit-Position: refs/heads/master@{#406757} [modify] https://crrev.com/2d6e1f491447569b7fd19be8f1d568a56d8cb4e7/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
,
Jul 21 2016
,
Jul 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f52ee40fe6da910d2ff09c94df74a53230bcff44 commit f52ee40fe6da910d2ff09c94df74a53230bcff44 Author: dbeam <dbeam@chromium.org> Date: Thu Jul 21 17:55:51 2016 MD Settings: drop :hover shadow from avatar selector R=tommycli@chromium.org BUG= 630067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2163883009 Cr-Commit-Position: refs/heads/master@{#406896} [modify] https://crrev.com/f52ee40fe6da910d2ff09c94df74a53230bcff44/chrome/browser/resources/settings/people_page/manage_profile.html [modify] https://crrev.com/f52ee40fe6da910d2ff09c94df74a53230bcff44/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html
,
Jul 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a719eb30f9a516530e587612cd9461d44a9e7444 commit a719eb30f9a516530e587612cd9461d44a9e7444 Author: dbeam <dbeam@chromium.org> Date: Thu Jul 21 22:49:07 2016 MD History: remove underline/bgcolor change on :hover R=tsergeant@chromium.org BUG= 630067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2169433003 Cr-Commit-Position: refs/heads/master@{#406978} [modify] https://crrev.com/a719eb30f9a516530e587612cd9461d44a9e7444/chrome/browser/resources/md_history/list_container.html [modify] https://crrev.com/a719eb30f9a516530e587612cd9461d44a9e7444/chrome/browser/resources/md_history/shared_style.html [modify] https://crrev.com/a719eb30f9a516530e587612cd9461d44a9e7444/chrome/browser/resources/md_history/synced_device_card.html
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4710216e29e419a07dd7dd84fd6023c9b2f51ac commit a4710216e29e419a07dd7dd84fd6023c9b2f51ac Author: dbeam <dbeam@chromium.org> Date: Fri Jul 22 03:13:00 2016 MD Setting: drop changes to background-color on :hover R=stevenjb@chromium.org BUG= 630067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOTRY=true # android bots keep failing, this code doesn't even run on android... Review-Url: https://codereview.chromium.org/2164223002 Cr-Commit-Position: refs/heads/master@{#407007} [modify] https://crrev.com/a4710216e29e419a07dd7dd84fd6023c9b2f51ac/chrome/browser/resources/settings/people_page/user_list.html [modify] https://crrev.com/a4710216e29e419a07dd7dd84fd6023c9b2f51ac/chrome/browser/resources/settings/settings_root_css.html [modify] https://crrev.com/a4710216e29e419a07dd7dd84fd6023c9b2f51ac/chrome/browser/resources/settings/settings_shared_css.html
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4710216e29e419a07dd7dd84fd6023c9b2f51ac commit a4710216e29e419a07dd7dd84fd6023c9b2f51ac Author: dbeam <dbeam@chromium.org> Date: Fri Jul 22 03:13:00 2016 MD Setting: drop changes to background-color on :hover R=stevenjb@chromium.org BUG= 630067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOTRY=true # android bots keep failing, this code doesn't even run on android... Review-Url: https://codereview.chromium.org/2164223002 Cr-Commit-Position: refs/heads/master@{#407007} [modify] https://crrev.com/a4710216e29e419a07dd7dd84fd6023c9b2f51ac/chrome/browser/resources/settings/people_page/user_list.html [modify] https://crrev.com/a4710216e29e419a07dd7dd84fd6023c9b2f51ac/chrome/browser/resources/settings/settings_root_css.html [modify] https://crrev.com/a4710216e29e419a07dd7dd84fd6023c9b2f51ac/chrome/browser/resources/settings/settings_shared_css.html
,
Jul 22 2016
,
Jul 23 2016
this is basically fixed now stevenjb@ has qualms about :hover and :focus in the network list, but I think that may be used outside of settings as well (but should still probably act similarly to the rest of Chrome)
,
Oct 21 2016
Verified on ChromeOS 8872.18.0, 55.0.2883.20. No state change is seen with hover on avatars, and also on passwords page |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dbeam@chromium.org
, Jul 21 2016