New issue
Advanced search Search tips

Issue 630066 link

Starred by 2 users
Status: WontFix
Owner:
tkent@chromium.org
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename Element::layoutObjectIsFocusable to isFocusableStyle

Project Member Reported by tkent@chromium.org, Jul 21 2016 
layoutObjectIsFocusable() should not depend on LayoutObject, and should be renamed to isFocusableStyle.

Address a TODO comment here:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/dom/Element.h?type=cs&q=isFocusableStyle&sq=package:chromium&l=613

Comment 1 by tkent@chromium.org, Jul 21 2016

Status: WontFix (was: Started)
We found this was not so easy.  We don't have alternate ways of Elemenet::layoutObject() non-null checking.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0e00543bb2990a7478964be5fc613181bbdd249

commit d0e00543bb2990a7478964be5fc613181bbdd249
Author: tkent <tkent@chromium.org>
Date: Thu Jul 21 06:26:34 2016

Remove layoutObject() dependency from HTMLPlugInElement::layoutObjectIsFocusable().

- Introduce HTMLPlugInElement::m_pluginIsAvailable.
  It is equivalent to:
    layoutObject() && layoutObject()->isEmbeddedObject() &&
    !layoutEmbeddedItem().showsUnavailablePluginIndicator()

- Remove LayoutEmbeddedObject::m_showsUnavailablePluginIndicator.
  Add PluginAvailable state to PluginUnavailabilityReason, and rename it to
  PluginAvailability.  We can replace m_showsUnavailablePluginIndicator with
  |m_pluginAvailability != PluginAvailable|.

This CL should not have any behavior changes.

BUG= 630066 

Review-Url: https://codereview.chromium.org/2166813005
Cr-Commit-Position: refs/heads/master@{#406786}

[modify] https://crrev.com/d0e00543bb2990a7478964be5fc613181bbdd249/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
[modify] https://crrev.com/d0e00543bb2990a7478964be5fc613181bbdd249/third_party/WebKit/Source/core/html/HTMLPlugInElement.h
[modify] https://crrev.com/d0e00543bb2990a7478964be5fc613181bbdd249/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp
[modify] https://crrev.com/d0e00543bb2990a7478964be5fc613181bbdd249/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.h
[modify] https://crrev.com/d0e00543bb2990a7478964be5fc613181bbdd249/third_party/WebKit/Source/core/layout/api/LayoutEmbeddedItem.h

Comment 3 by benhenry@chromium.org, Sep 29 2017

Components: Blink>HTML>Focus

Comment 4 by benhenry@chromium.org, Sep 29 2017

Components: -Blink>Focus
►

Sign in to add a comment