New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630065 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"Compile (without patch)" actually compiles with patch

Project Member Reported by wangxianzhu@chromium.org, Jul 21 2016

Issue description

Owner: phajdan.jr@chromium.org
Status: Started (was: Untriaged)
Ah, this is related to recent remote_run conversion.

We're running bot_update without patch in the wrong directory. It should be kept in sync with how original bot_update runs.

Great catch, thanks for reporting.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 21 2016

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/9dbb8b7b1271804a792e311ecba6344a6b957d34

commit 9dbb8b7b1271804a792e311ecba6344a6b957d34
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Jul 21 15:38:14 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/bbfbad4ff1c20c25e0b3df42fd30c5d0b69e154b chromium_tests: use correct cwd for deapplying patch (phajdan.jr@chromium.org)
  https://crrev.com/e222f56e1e92b532e577cdc36f9e60543aef6e98 chromium.fyi: use chromium recipe in chromium/src via gitiles on remote_run builders (phajdan.jr@chromium.org)
  https://crrev.com/f91d5337a0d67c79c22ce9ebb71d00e19161e724 Reland of [Android] Enable platform mode for perf tests on Galaxy S5 (patchset #1 id:1 of https://codereview.chromium.org/2172463002/ ) (rnephew@chromium.org)

R=dtu@chromium.org,rnephew@chromium.org,jbudorick@chromium.org,stip@chromium.org,phajdan.jr@chromium.org
BUG= 630065 ,584079, 615157 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2163373007

[modify] https://crrev.com/9dbb8b7b1271804a792e311ecba6344a6b957d34/infra/config/recipes.cfg

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/430fa14b4178317246b45eac9a6930d5958f5fe5

commit 430fa14b4178317246b45eac9a6930d5958f5fe5
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Jul 21 15:58:40 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/bbfbad4ff1c20c25e0b3df42fd30c5d0b69e154b chromium_tests: use correct cwd for deapplying patch (phajdan.jr@chromium.org)
  https://crrev.com/e222f56e1e92b532e577cdc36f9e60543aef6e98 chromium.fyi: use chromium recipe in chromium/src via gitiles on remote_run builders (phajdan.jr@chromium.org)
  https://crrev.com/f91d5337a0d67c79c22ce9ebb71d00e19161e724 Reland of [Android] Enable platform mode for perf tests on Galaxy S5 (patchset #1 id:1 of https://codereview.chromium.org/2172463002/ ) (rnephew@chromium.org)
  https://crrev.com/1160d66500b544685e537800c77a4071e35912da Set nest step status when test failure for Chromedriver recipe. (mikecase@chromium.org)

R=rnephew@chromium.org,jbudorick@chromium.org,stip@chromium.org,dtu@chromium.org,mikecase@chromium.org,phajdan.jr@chromium.org
BUG= 627633 , 630065 ,584079, 615157 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2166043006

[modify] https://crrev.com/430fa14b4178317246b45eac9a6930d5958f5fe5/infra/config/recipes.cfg

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/bbfbad4ff1c20c25e0b3df42fd30c5d0b69e154b

commit bbfbad4ff1c20c25e0b3df42fd30c5d0b69e154b
Author: phajdan.jr <phajdan.jr@chromium.org>
Date: Thu Jul 21 15:02:37 2016

chromium_tests: use correct cwd for deapplying patch

BUG= 630065 

Review-Url: https://codereview.chromium.org/2166343002

[modify] https://crrev.com/bbfbad4ff1c20c25e0b3df42fd30c5d0b69e154b/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/bbfbad4ff1c20c25e0b3df42fd30c5d0b69e154b/scripts/slave/recipes/chromium_trybot.expected/compile_failure_infra.json
[modify] https://crrev.com/bbfbad4ff1c20c25e0b3df42fd30c5d0b69e154b/scripts/slave/recipes/chromium_trybot.expected/compile_failure_ng.json
[modify] https://crrev.com/bbfbad4ff1c20c25e0b3df42fd30c5d0b69e154b/scripts/slave/recipes/chromium_trybot.expected/compile_failure_with_component_rev.json
[modify] https://crrev.com/bbfbad4ff1c20c25e0b3df42fd30c5d0b69e154b/scripts/slave/recipes/chromium_trybot.expected/compile_failure_without_patch_ng.json
[modify] https://crrev.com/bbfbad4ff1c20c25e0b3df42fd30c5d0b69e154b/scripts/slave/recipes/chromium_trybot.expected/gclient_runhooks__with_patch__failure.json
[modify] https://crrev.com/bbfbad4ff1c20c25e0b3df42fd30c5d0b69e154b/scripts/slave/recipes/chromium_trybot.expected/runhooks_failure.json
[modify] https://crrev.com/bbfbad4ff1c20c25e0b3df42fd30c5d0b69e154b/scripts/slave/recipes/chromium_trybot.expected/runhooks_failure_ng.json
[modify] https://crrev.com/bbfbad4ff1c20c25e0b3df42fd30c5d0b69e154b/scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot_compile_failure.json

Status: Fixed (was: Started)

Sign in to add a comment