New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 630060 link

Starred by 5 users
Status: Duplicate
Merged: issue 704396
Owner: ----
Closed: May 2017
Cc:
█ phajdan.jr@chromium.org
█ iannucci@chromium.org
d...@chromium.org
iannu...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Allow recipe result annotations?

Project Member Reported by martiniss@chromium.org, Jul 21 2016 
Right now we have a couple "steps" which aren't really steps, but rather annotations on what happened in the recipe execution. The ones I know of are "Uncaught Exception", "Failure reason", and "recipe result".

Really, these things should be displayed the UI (buildbot/milo) in a different way, and they should be annotated differently.

I'm looking at the milo annotation protobuf (https://github.com/luci/luci-go/blob/master/common/proto/milo/annotations.proto), and it looks like these "steps" have analogs there.

"failure reason", "Uncaught Exception" -> Step.FailureDetails

I'm not sure what the analog is for "recipe result". Although maybe milo won't know about it, and it's a DM only thing? Not sure.

Comment 1 by d...@chromium.org, Jul 21 2016 

In the Milo Proto, the top-level result is the analog got "recipe result", I think? Milo's annotation protobuf is all about communicating to Milo how to visualize something, so if we need to pass information out of band of standard recipe concepts, it can/should have a field in the Milo protobuf and not (ab)use a sub-step.

That said, in Milo annotation protobuf, the top-level Step can have text, links, and a result with failure details. That seems like a fine place to put that information.

Comment 2 by martiniss@chromium.org, Jul 26 2016 

 Issue 631188  has been merged into this issue.

Comment 3 by no...@chromium.org, Jul 26 2016

Labels: -Pri-3 M-54 luci Pri-2
in fact there is a CL in milo to hide recipe result step, because it is everywhere, so maybe we should get rid of it

why do we need these annotation steps? can we maybe add emit them behind a flag, so clients that don't need them, don't have them?

Comment 4 by martiniss@chromium.org, Aug 10 2016

Status: Available (was: Untriaged)
Didn't see #3 until now. 

I added the recipe_result step a while ago, since we are technically seeing a recipe result in the engine. Nothing is using it right now, though. So I'm fine removing it.

Comment 5 by no...@chromium.org, Aug 10 2016 

So humans use these steps, by looking at them?

Comment 6 by no...@chromium.org, Aug 10 2016 

S/So/Do

Comment 7 by martiniss@chromium.org, Aug 10 2016 

No, they do not.

Comment 8 by no...@chromium.org, Feb 22 2017

Labels: Pri-3
(bulk edit) setting P3 because this bug has luci label and not time critical for the current milestone

Comment 9 by iannucci@chromium.org, May 15 2017

Mergedinto: 704396
Status: Duplicate (was: Available)
►

Sign in to add a comment