Mac: Closing tabs is sometimes slow |
||
Issue descriptionVersion: 54.0.2800.0 OS: Mac What steps will reproduce the problem? (1) Open a bunch of tabs, then close the active one What is the expected output? Close should be fast What do you see instead? It's strangely slow. I looked into this, and we will often allocate-and-free a ui::Compositor at tab create/switch/close. I have a patch to fix this. I think this regressed in M53, so I'm marking this as M53.
,
Jul 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f260a62accfc82c4bc7d7578bb3edb9116a1056 commit 1f260a62accfc82c4bc7d7578bb3edb9116a1056 Author: ccameron <ccameron@chromium.org> Date: Thu Jul 21 06:29:30 2016 Mac: Clean up ui::Compositor recycling Tab switch was often janky because we would end up creating and destroying a ui::Compositor during tab-switch. Fix this by posting a task to free the "spare" ui::Compositors. This fix has two effects. First, this doesn't destroy the compositor while the browser compositor is potentially waiting for a from the switched-to-tab to come in (reducing contention). Second, by posting a task to free up compositors, it allows us to be in transient states where we have more than one "spare" ui::Compositor, which indeed happens when opening a new tab. BUG= 630028 Review-Url: https://codereview.chromium.org/2167003002 Cr-Commit-Position: refs/heads/master@{#406787} [modify] https://crrev.com/1f260a62accfc82c4bc7d7578bb3edb9116a1056/content/browser/renderer_host/browser_compositor_view_mac.mm
,
May 3 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by sheriffbot@chromium.org
, Jul 21 2016