Include servo verify/repair operations in Repair task status.log files
Reported by
jrbarnette@chromium.org,
Jul 20 2016
|
|||||||||||||||||
Issue descriptionCurrently, if servo isn't working during a repair task, all that gets logged is something like this: START ---- repair.usb timestamp=1469019883 localtime=Jul 20 06:04:43 FAIL ---- repair.usb timestamp=1469019883 localtime=Jul 20 06:04:43 chromeos2-row1-rack4-host11 has no servo support. END FAIL ---- repair.usb timestamp=1469019883 localtime=Jul 20 06:04:43 This message will be logged whether the problem is really "there's no servo", or if the problem is instead "servo is present, but not working". The ServoHost repair procedure should be updated to use the repair and verify framework, so that the reasons for calling servo "down" can be logged.
,
Jul 20 2016
,
Jul 20 2016
,
Jul 20 2016
,
Jul 20 2016
,
Jul 20 2016
,
Jul 20 2016
,
Aug 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/18349ac8d40ea4fd08183cbbb2d270f0142bda05 commit 18349ac8d40ea4fd08183cbbb2d270f0142bda05 Author: Richard Barnette <jrbarnette@chromium.org> Date: Tue Aug 16 00:04:32 2016 [autotest] Remove the infra_ServoDiagnosis test. This test will be obviated by upcoming changes to repair code for servo. BUG= chromium:630018 , chromium:406176 , chromium:406173 TEST=None Change-Id: I953096cfb5ae0c40ddfdd844698709ce10ba1871 Reviewed-on: https://chromium-review.googlesource.com/370898 Commit-Ready: Richard Barnette <jrbarnette@chromium.org> Tested-by: Richard Barnette <jrbarnette@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> Reviewed-by: Kevin Cheng <kevcheng@chromium.org> [delete] https://crrev.com/5de4cc069090b67ae4727feb8df24f01a3667235/server/site_tests/infra_ServoDiagnosis/infra_ServoDiagnosis.py [delete] https://crrev.com/5de4cc069090b67ae4727feb8df24f01a3667235/server/site_tests/infra_ServoDiagnosis/control
,
Aug 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e519dcd90749c04af0541102f453d91a7dd06af6 commit e519dcd90749c04af0541102f453d91a7dd06af6 Author: Richard Barnette <jrbarnette@chromium.org> Date: Tue Aug 16 00:37:17 2016 [autotest] Add DUT board to ServoHost. In preparation for upcoming servo repair changes, the DUT board needs to be a field in the ServoHost object. BUG= chromium:630018 TEST=repair_test on a DUT in the lab Change-Id: I35fd4ca255fa828bb842debd422dda0928c87335 Reviewed-on: https://chromium-review.googlesource.com/370899 Commit-Ready: Richard Barnette <jrbarnette@chromium.org> Tested-by: Richard Barnette <jrbarnette@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> Reviewed-by: Dan Shi <dshi@chromium.org> [modify] https://crrev.com/e519dcd90749c04af0541102f453d91a7dd06af6/server/hosts/cros_host.py [modify] https://crrev.com/e519dcd90749c04af0541102f453d91a7dd06af6/server/hosts/servo_host.py [delete] https://crrev.com/18349ac8d40ea4fd08183cbbb2d270f0142bda05/client/common_lib/cros/servo_afe_board_map.py [modify] https://crrev.com/e519dcd90749c04af0541102f453d91a7dd06af6/site_utils/deployment/install.py [rename] https://crrev.com/e519dcd90749c04af0541102f453d91a7dd06af6/server/hosts/servo_afe_board_map_unittest.py
,
Aug 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f6579937c953d9c6f72f8dcd9ed9f2003f7d2167 commit f6579937c953d9c6f72f8dcd9ed9f2003f7d2167 Author: Richard Barnette <jrbarnette@chromium.org> Date: Wed Aug 17 00:07:03 2016 [autotest] Update exceptions typically raised by verify(). When verify() fails, typically it raises AutoservVerifyDependencyError. Previously, such exceptions would contain the description of every verifier that failed; this was useful for the debug logs. Upcoming changes for servo repair will sometimes need to print the exceptions raised by verify(); for the exceptions raised by verify() to be useful for printing error messages, they need to contain the actual errors. This changes verify and repair so that their exceptions contain both the description and the exception message. If the exception is converted to a string, (i.e. for printing) it includes all the error messages. Logging continues to use the verifier description. This also tweaks the logging messages to be slightly more readable. BUG= chromium:630018 TEST=Unit tests, plus tested the new servo repair with this code Change-Id: I3988e9cd7422e7be5d9280b93589ca63184a450e Reviewed-on: https://chromium-review.googlesource.com/371565 Commit-Ready: Richard Barnette <jrbarnette@chromium.org> Tested-by: Richard Barnette <jrbarnette@chromium.org> Reviewed-by: Kevin Cheng <kevcheng@chromium.org> [modify] https://crrev.com/f6579937c953d9c6f72f8dcd9ed9f2003f7d2167/client/common_lib/hosts/repair.py [modify] https://crrev.com/f6579937c953d9c6f72f8dcd9ed9f2003f7d2167/client/common_lib/hosts/repair_unittest.py
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9a26ad68d71c50a0947edab6a7b9a221c0a76c2b commit 9a26ad68d71c50a0947edab6a7b9a221c0a76c2b Author: Richard Barnette <jrbarnette@chromium.org> Date: Fri Jun 10 19:03:08 2016 [autotest] Use a RepairStrategy to repair ServoHost. This converts ServoHost to use the new repair framework. It effectively replaces the now-defunct infra_ServoDiagnosis. With this change, the preferred way to make sure a Servo is available and working is simply to invoke repair() on the associated ServoHost object. That invocation also assures that standard repair and verify logging will be present in status.log. BUG= chromium:630018 , chromium:406173 , chromium:531643 , chromium:543357 TEST=run `repair_test`, run Repair tasks in a local Autotest instance Change-Id: I5b57e6b4920e043a5389149b3f11dbcd1e59d061 Reviewed-on: https://chromium-review.googlesource.com/372980 Tested-by: Richard Barnette <jrbarnette@chromium.org> Reviewed-by: Kevin Cheng <kevcheng@chromium.org> Commit-Queue: Richard Barnette <jrbarnette@chromium.org> [modify] https://crrev.com/9a26ad68d71c50a0947edab6a7b9a221c0a76c2b/server/control_segments/provision [modify] https://crrev.com/9a26ad68d71c50a0947edab6a7b9a221c0a76c2b/server/control_segments/repair [add] https://crrev.com/9a26ad68d71c50a0947edab6a7b9a221c0a76c2b/server/hosts/servo_repair.py [modify] https://crrev.com/9a26ad68d71c50a0947edab6a7b9a221c0a76c2b/server/hosts/cros_host.py [modify] https://crrev.com/9a26ad68d71c50a0947edab6a7b9a221c0a76c2b/server/control_segments/verify [modify] https://crrev.com/9a26ad68d71c50a0947edab6a7b9a221c0a76c2b/site_utils/deployment/install.py [modify] https://crrev.com/9a26ad68d71c50a0947edab6a7b9a221c0a76c2b/server/site_tests/provision_FirmwareUpdate/provision_FirmwareUpdate.py [modify] https://crrev.com/9a26ad68d71c50a0947edab6a7b9a221c0a76c2b/server/hosts/servo_host.py
,
Sep 26 2016
,
Oct 7 2016
,
Oct 10 2016
,
Nov 19 2016
,
Jan 21 2017
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by jrbarnette@chromium.org
, Jul 20 2016