Re-enable testTextEntry and testEnterText Telemetry unittests on chromeos |
||||||||||
Issue descriptionExample: https://uberchromegw.corp.google.com/i/chromiumos.chromium/builders/x86-generic-telemetry/builds/9978 Logs: 07/19 06:22:32.998 INFO |run_chromeos_tests:0052| [158/1068] telemetry.internal.actions.action_runner_unittest.ActionRunnerTest.testEnterText failed unexpectedly 29.5215s: 07/19 06:22:32.998 INFO |run_chromeos_tests:0052| Traceback (most recent call last): 07/19 06:22:32.999 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/testing/browser_test_case.py", line 41, in WrappedMethod 07/19 06:22:32.999 INFO |run_chromeos_tests:0052| method(self) 07/19 06:22:33.002 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/actions/action_runner_unittest.py", line 281, in testEnterText 07/19 06:22:33.002 INFO |run_chromeos_tests:0052| 'document.querySelector("textarea").value')) 07/19 06:22:33.003 INFO |run_chromeos_tests:0052| AssertionError: 'This is interesting' != u'This is intereing' 07/19 06:27:08.987 INFO |run_chromeos_tests:0052| [169/1068] telemetry.internal.actions.key_event_unittest.KeyPressActionTest.testTextEntry failed unexpectedly 28.7623s: 07/19 06:27:08.991 INFO |run_chromeos_tests:0052| Traceback (most recent call last): 07/19 06:27:08.991 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/testing/browser_test_case.py", line 41, in WrappedMethod 07/19 06:27:08.992 INFO |run_chromeos_tests:0052| method(self) 07/19 06:27:08.993 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/actions/key_event_unittest.py", line 81, in testTextEntry 07/19 06:27:08.993 INFO |run_chromeos_tests:0052| 'document.querySelector("textarea").value')) 07/19 06:27:08.994 INFO |run_chromeos_tests:0052| AssertionError: 'Hello,\nWorld!' != u'Hello,World!'
,
Jul 20 2016
,
Jul 20 2016
,
Jul 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95ebf2c178ed4857532f7e54ed91d4cd807c7bdb commit 95ebf2c178ed4857532f7e54ed91d4cd807c7bdb Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Thu Jul 21 03:08:42 2016 Roll src/third_party/catapult/ cda131c42..6e428a2e9 (2 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/cda131c42ac8..6e428a2e9411 $ git log cda131c42..6e428a2e9 --date=short --no-merges --format='%ad %ae %s' BUG= 630017 ,628836 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2168813002 Cr-Commit-Position: refs/heads/master@{#406749} [modify] https://crrev.com/95ebf2c178ed4857532f7e54ed91d4cd807c7bdb/DEPS
,
Jul 21 2016
I looked at the flakes and I think that the problem is that the last keystrokes are not handled by the browser before the contents of the textarea is inspected:
***ActionRunnerTest.testEnterText***
Last keystrokes: 'e', 's', 't'
(https://github.com/catapult-project/catapult/blob/master/telemetry/telemetry/internal/actions/action_runner_unittest.py#L279)
EXPECTED ACTUAL
AssertionError: 'This is interesting' != u'This is intering'
AssertionError: 'This is interesting' != u'This is intereing'
AssertionError: 'This is interesting' != u'This is interesing'
***KeyPressActionTest.testTextEntry***
Last keystrokes: 'Backspace' (delete space), 'Return'
(https://github.com/catapult-project/catapult/blob/master/telemetry/telemetry/internal/actions/key_event_unittest.py#L77)
EXPECTED ACTUAL
AssertionError: 'Hello,\nWorld!' != u'Hello, World!'
AssertionError: 'Hello,\nWorld!' != u'Hello,World!'
The solution should therefore be just to add a timeout before the
contents of the textarea are inspected.
,
Jul 21 2016
This should now be fixed: https://codereview.chromium.org/2170793003/ Please re-open this bug if the issue occurs again.
,
Jul 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de8d8515aa4919e9930484327dc9f38d6a0d02d5 commit de8d8515aa4919e9930484327dc9f38d6a0d02d5 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Thu Jul 21 12:56:29 2016 Roll src/third_party/catapult/ 6e428a2e9..60ef25306 (1 commit). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6e428a2e9411..60ef2530645f $ git log 6e428a2e9..60ef25306 --date=short --no-merges --format='%ad %ae %s' BUG= 630017 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2167123002 Cr-Commit-Position: refs/heads/master@{#406828} [modify] https://crrev.com/de8d8515aa4919e9930484327dc9f38d6a0d02d5/DEPS
,
Jul 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/392902e423253e1b737861fb7c73128b46699ec1 commit 392902e423253e1b737861fb7c73128b46699ec1 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Mon Jul 25 13:24:29 2016 Roll src/third_party/catapult/ ee0654d7c..2befef433 (1 commit). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ee0654d7c641..2befef4332bc $ git log ee0654d7c..2befef433 --date=short --no-merges --format='%ad %ae %s' BUG= 630017 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2178913002 Cr-Commit-Position: refs/heads/master@{#407461} [modify] https://crrev.com/392902e423253e1b737861fb7c73128b46699ec1/DEPS
,
Aug 29 2016
,
Aug 29 2016
bulk verified
,
Jan 6 2017
Fails again: https://luci-milo.appspot.com/buildbot/chromium.linux/Linux%20Tests/50600 [147/1070] telemetry.internal.actions.key_event_unittest.KeyPressActionTest.testTextEntry queued [148/1070] telemetry.internal.actions.key_event_unittest.KeyPressActionTest.testTextEntry failed unexpectedly 255.3655s:
,
Mar 16 2017
Hector: Could you please route this to the correct person (or mark as obsolete)? Thanks!
,
Mar 16 2017
Seems to working on HEAD https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests. loyso@ Was this test flaky? I can't see any recent failures due to the telemetry tests. I'll close as WontFix for now, please re-open if this is still a problem. Thanks!
,
Oct 14 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by achuith@chromium.org
, Jul 20 2016