Instead of exposing a boolean for the state of MAC address randomization in shill, we can expose a tri-state enabled/disabled/unsupported. I think bailing after failing once might be too strict.

Bumping the priority of this one and marking RB-S since this features is enabled on R-53 as issue 580737.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad8797fd5b55ee3aff6bf06d2a91633fc294f079

commit ad8797fd5b55ee3aff6bf06d2a91633fc294f079
Author: ejcaruso <ejcaruso@chromium.org>
Date: Wed Aug 03 00:04:16 2016

Don't set MAC address randomization when unsupported

Chrome currently tries to set MAC address randomization on the
WiFi device whenever the it detects changes in the device list,
but this means it spams shill with calls and floods shill's log
with errors if the feature is unsupported. Instead, stop trying
to toggle the property when this happens.

BUG= 630012 
R=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2202693005
Cr-Commit-Position: refs/heads/master@{#409388}

[modify] https://crrev.com/ad8797fd5b55ee3aff6bf06d2a91633fc294f079/chromeos/network/network_device_handler_impl.cc
[modify] https://crrev.com/ad8797fd5b55ee3aff6bf06d2a91633fc294f079/chromeos/network/network_device_handler_impl.h

Your change meets the bar and is auto-approved for M53 (branch: 2785)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42f1b3e65bb437d11b965af919eba7194ee615b7

commit 42f1b3e65bb437d11b965af919eba7194ee615b7
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Aug 04 00:32:03 2016

Don't set MAC address randomization when unsupported

Chrome currently tries to set MAC address randomization on the
WiFi device whenever the it detects changes in the device list,
but this means it spams shill with calls and floods shill's log
with errors if the feature is unsupported. Instead, stop trying
to toggle the property when this happens.

BUG= 630012 
R=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2202693005
Cr-Commit-Position: refs/heads/master@{#409388}
(cherry picked from commit ad8797fd5b55ee3aff6bf06d2a91633fc294f079)

Review URL: https://codereview.chromium.org/2214473003 .

Cr-Commit-Position: refs/branch-heads/2785@{#494}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/42f1b3e65bb437d11b965af919eba7194ee615b7/chromeos/network/network_device_handler_impl.cc
[modify] https://crrev.com/42f1b3e65bb437d11b965af919eba7194ee615b7/chromeos/network/network_device_handler_impl.h

Thanks Steven!

I continue to see the following errors on R53-8530.49.0 Veyron-Minnie device. Marking this back as "Assigned" 


2016-08-10T17:32:29.901841+00:00 ERR shill[1186]: [ERROR:error.cc(146)] [wifi.cc(771)]: This WiFi device does not support MAC address randomization
2016-08-10T17:32:29.901887+00:00 ERR shill[1186]: [ERROR:wifi.cc(771)] SetRandomMACEnabled(...): Domain=dbus, Code=org.chromium.flimflam.Error.NotSupported, Message=This WiFi device does not support MAC address randomization
2016-08-10T17:32:29.908376+00:00 ERR shill[1186]: [ERROR:error.cc(146)] [wifi.cc(771)]: This WiFi device does not support MAC address randomization
2016-08-10T17:32:29.908421+00:00 ERR shill[1186]: [ERROR:wifi.cc(771)] SetRandomMACEnabled(...): Domain=dbus, Code=org.chromium.flimflam.Error.NotSupported, Message=This WiFi device does not support MAC address randomization
2016-08-10T17:32:32.845163+00:00 ERR shill[1186]: [ERROR:error.cc(146)] [wifi.cc(771)]: This WiFi device does not support MAC address randomization
2016-08-10T17:32:32.845216+00:00 ERR shill[1186]: [ERROR:wifi.cc(771)] SetRandomMACEnabled(...): Domain=dbus, Code=org.chromium.flimflam.Error.NotSupported, Message=This WiFi device does not support MAC address randomization
2016-08-10T17:37:00.696666+00:00 ERR shill[1186]: [ERROR:error.cc(146)] [wifi.cc(771)]: This WiFi device does not support MAC address randomization
2016-08-10T17:37:00.696703+00:00 ERR shill[1186]: [ERROR:wifi.cc(771)] SetRandomMACEnabled(...): Domain=dbus, Code=org.chromium.flimflam.Error.NotSupported, Message=This WiFi device does not support MAC address randomization
2016-08-10T17:37:01.257253+00:00 ERR shill[1186]: [ERROR:error.cc(146)] [wifi.cc(771)]: This WiFi device does not support MAC address randomization
2016-08-10T17:37:01.257286+00:00 ERR shill[1186]: [ERROR:wifi.cc(771)] SetRandomMACEnabled(...): Domain=dbus, Code=org.chromium.flimflam.Error.NotSupported, Message=This WiFi device does not support MAC address randomization
2016-08-10T17:37:03.723690+00:00 ERR shill[1186]: [ERROR:error.cc(146)] [wifi.cc(771)]: This WiFi device does not support MAC address randomization
2016-08-10T17:37:03.723740+00:00 ERR shill[1186]: [ERROR:wifi.cc(771)] SetRandomMACEnabled(...): Domain=dbus, Code=org.chromium.flimflam.Error.NotSupported, Message=This WiFi device does not support MAC address randomization
2016-08-10T17:37:07.902895+00:00 ERR shill[1186]: [ERROR:error.cc(146)] [wifi.cc(771)]: This WiFi device does not support MAC address randomization
2016-08-10T17:37:07.903109+00:00 ERR shill[1186]: [ERROR:wifi.cc(771)] SetRandomMACEnabled(...): Domain=dbus, Code=org.chromium.flimflam.Error.NotSupported, Message=This WiFi device does not support MAC address randomization
2016-08-10T17:37:11.601001+00:00 ERR shill[1186]: [ERROR:error.cc(146)] [wifi.cc(771)]: This WiFi device does not support MAC address randomization
2016-08-10T17:37:11.601050+00:00 ERR shill[1186]: [ERROR:wifi.cc(771)] SetRandomMACEnabled(...): Domain=dbus, Code=org.chromium.flimflam.Error.NotSupported, Message=This WiFi device does not support MAC address randomization
2016-08-10T17:44:49.015522+00:00 ERR shill[1186]: [ERROR:error.cc(146)] [wifi.cc(771)]: This WiFi device does not support MAC address randomization
2016-08-10T17:44:49.015565+00:00 ERR shill[1186]: [ERROR:wifi.cc(771)] SetRandomMACEnabled(...): Domain=dbus, Code=org.chromium.flimflam.Error.NotSupported, Message=This WiFi device does not support MAC address randomization
2016-08-10T17:44:53.407352+00:00 ERR shill[1186]: [ERROR:error.cc(146)] [wifi.cc(771)]: This WiFi device does not support MAC address randomization
2016-08-10T17:44:53.407934+00:00 ERR shill[1186]: [ERROR:wifi.cc(771)] SetRandomMACEnabled(...): Domain=dbus, Code=org.chromium.flimflam.Error.NotSupported, Message=This WiFi device does not support MAC address randomization
2016-08-10T17:54:30.095992+00:00 ERR shill[1186]: [ERROR:error.cc(146)] [wifi.cc(771)]: This WiFi device does not support MAC address randomization
2016-08-10T17:54:30.096034+00:00 ERR shill[1186]: [ERROR:wifi.cc(771)] SetRandomMACEnabled(...): Domain=dbus, Code=org.chromium.flimflam.Error.NotSupported, Message=This WiFi device does not support MAC address randomization

I can verify the patch is in 53.0.2785.55 which is the chrome version for that image. I'll take another look tomorrow.

Are you sure this isn't from a prior boot in a different image? I truncated my /var/log/messages and rebooted, then used the device for a while, and only saw two log messages within 10ms of each other around boot-time and none after that in half an hour. This is using R53-8530.49.0 fresh off the builder.

(marking as fixed again because I can't reproduce this)

Can you try this again? I continue to see this issue. I have also attached logs. 

Version 53.0.2785.70 unknown
Platform 8530.62.0 (Official Build) dev-channel veyron_minnie test
ARC Version 3152187
Firmware Google_Veyron_Minnie.6588.197.0

2016-08-18T19:23:42.017138+00:00 ERR shill[1243]: [ERROR:error.cc(146)] [wifi.cc(771)]: This WiFi device does not support MAC address randomization
2016-08-18T19:23:42.017177+00:00 ERR shill[1243]: [ERROR:wifi.cc(771)] SetRandomMACEnabled(...): Domain=dbus, Code=org.chromium.flimflam.Error.NotSupported, Message=This WiFi device does not support MAC address randomization
2016-08-18T12:36:01.058473-07:00 ERR shill[1309]: [ERROR:error.cc(146)] [wifi.cc(771)]: This WiFi device does not support MAC address randomization
2016-08-18T12:36:01.058634-07:00 ERR shill[1309]: [ERROR:wifi.cc(771)] SetRandomMACEnabled(...): Domain=dbus, Code=org.chromium.flimflam.Error.NotSupported, Message=This WiFi device does not support MAC address randomization
2016-08-18T12:36:01.061345-07:00 ERR shill[1309]: [ERROR:error.cc(146)] [wifi.cc(771)]: This WiFi device does not support MAC address randomization
2016-08-18T12:36:01.061452-07:00 ERR shill[1309]: [ERROR:wifi.cc(771)] SetRandomMACEnabled(...): Domain=dbus, Code=org.chromium.flimflam.Error.NotSupported, Message=This WiFi device does not support MAC address randomization
2016-08-18T12:45:20.755000-07:00 ERR shill[1182]: [ERROR:error.cc(146)] [wifi.cc(771)]: This WiFi device does not support MAC address randomization
2016-08-18T12:45:20.755046-07:00 ERR shill[1182]: [ERROR:wifi.cc(771)] SetRandomMACEnabled(...): Domain=dbus, Code=org.chromium.flimflam.Error.NotSupported, Message=This WiFi device does not support MAC address randomization
2016-08-18T12:45:20.755955-07:00 ERR shill[1182]: [ERROR:error.cc(146)] [wifi.cc(771)]: This WiFi device does not support MAC address randomization
2016-08-18T12:45:20.755984-07:00 ERR shill[1182]: [ERROR:wifi.cc(771)] SetRandomMACEnabled(...): Domain=dbus, Code=org.chromium.flimflam.Error.NotSupported, Message=This WiFi device does not support MAC address randomization

Deleted: log-081816-141914.tar.gz 943 KB

log-081816-141914.tar.gz 943 KB Download

Minnie 8530.77.0,