New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630010 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 630505



Sign in to add a comment

Advanced toggle button doesn't react to first click at chrome://md-settings/advanced

Project Member Reported by michae...@chromium.org, Jul 20 2016

Issue description

1. chrome://md-settings/advanced
2. click Advanced toggle button

Expected: Advanced closes.
Actual: Advanced stays open and page scrolls down.

This is, weirdly, a different root cause from all the other Advanced toggle bugs I've opened.
 
Blocking: 630505
Labels: Hotlist-MD-Settings-Navigation
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b7b3f37f385179dac9a1ae4407a20fb2a28647a

commit 5b7b3f37f385179dac9a1ae4407a20fb2a28647a
Author: michaelpg <michaelpg@chromium.org>
Date: Fri Jul 22 19:55:09 2016

MD Settings: refactor some main page properties, fix Advanced toggle

Fixes the Advanced toggle when navigating directly to Advanced.

Make currentRouteChanged_ less confusing. Wrap non-About stuff in a dom-if.

Removes a bunch of redundant properties.

Part of https://codereview.chromium.org/2106013002/

BUG= 630010 , 589681 
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2160713002
Cr-Commit-Position: refs/heads/master@{#407236}

[modify] https://crrev.com/5b7b3f37f385179dac9a1ae4407a20fb2a28647a/chrome/browser/resources/settings/settings_main/settings_main.html
[modify] https://crrev.com/5b7b3f37f385179dac9a1ae4407a20fb2a28647a/chrome/browser/resources/settings/settings_main/settings_main.js

Status: Fixed (was: Started)

Sign in to add a comment