Issue metadata
Sign in to add a comment
|
MD Downloads: clear all keyboard shortcut (Alt+c) is broken on Mac |
||||||||||||||||||||||
Issue descriptionAfter dtapuska@ switched keyIdentifier (deprecated) to key (shiny) everywhere in WebUI, Alt+c to clear downloads on Mac is broken. In debugging the code, I'm getting a .key of ç instead of 'c' with an Alt modifier when pressing Alt+c on Mac. Is this expected? Should I change the <command> in the downloads page to be ç instead of Alt|c on Mac OS X?
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ccd8cc4cbdbad46bbc1e6ccd12a309a6151e657 commit 2ccd8cc4cbdbad46bbc1e6ccd12a309a6151e657 Author: dbeam <dbeam@chromium.org> Date: Fri Jul 22 20:23:45 2016 MD Downloads: fix clear all keyboard shortcut on Mac BUG= 630001 R=dtapuska@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2167883002 Cr-Commit-Position: refs/heads/master@{#407246} [modify] https://crrev.com/2ccd8cc4cbdbad46bbc1e6ccd12a309a6151e657/chrome/browser/resources/md_downloads/crisper.js [modify] https://crrev.com/2ccd8cc4cbdbad46bbc1e6ccd12a309a6151e657/chrome/browser/resources/md_downloads/downloads.html [modify] https://crrev.com/2ccd8cc4cbdbad46bbc1e6ccd12a309a6151e657/chrome/browser/resources/md_downloads/vulcanized.html
,
Jul 23 2016
this now works on default en-US keyboard, but I'm still not sure what we're going to do for all the exotic shortcuts (i.e. Alt, Shift, Ctrl + <some char>) in other UIs. maybe using .key is a bad idea if we hit lots more issues like this? |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dbeam@chromium.org
, Jul 21 2016Owner: dbeam@chromium.org
Status: Started (was: Assigned)