New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629997 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 629571



Sign in to add a comment

AppBannerDataFetcherBrowserTest failures on macOS Sierra

Project Member Reported by erikc...@chromium.org, Jul 20 2016

Issue description

Failures:
    AppBannerDataFetcherBrowserTest.WebAppBannerNoTypeInManifest (../../chrome/browser/banners/app_banner_data_fetcher_browsertest.cc:286)
    AppBannerDataFetcherBrowserTest.WebAppBannerNoTypeInManifestCapsExtension (../../chrome/browser/banners/app_banner_data_fetcher_browsertest.cc:292)

e.g.
"""
[ RUN      ] AppBannerDataFetcherBrowserTest.WebAppBannerNoTypeInManifest
2016-07-20 14:57:20.161 browser_tests[95193:1494463] NSWindow warning: adding an unknown subview: <FullSizeContentView: 0x7fbbe06cb150>. Break on NSLog to debug.
2016-07-20 14:57:20.161 browser_tests[95193:1494463] Call stack:
(
    "+callStackSymbols disabled for performance reasons"
)
[95193:93975:0720/145720:WARNING:simple_synchronous_entry.cc(1054)] Could not open platform files for entry.
[95193:51471:0720/145720:WARNING:embedded_test_server.cc(193)] Request not handled. Returning 404: /favicon.ico
[95193:1547:0720/145720:ERROR:app_banner_data_fetcher_browsertest.cc(43)] OnDecidedWhetherToShow: 0
[95193:1547:0720/145720:ERROR:app_banner_data_fetcher_browsertest.cc(43)] OnDecidedWhetherToShow: 0
../../chrome/browser/banners/app_banner_data_fetcher_browsertest.cc:112: Failure
Value of: observer->will_show()
  Actual: false
Expected: expected_to_show
Which is: true
[95193:1547:0720/145720:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown printing.enabled
[95193:1547:0720/145720:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown plugins.always_authorize
[95193:1547:0720/145720:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown plugins.allow_outdated
[  FAILED  ] AppBannerDataFetcherBrowserTest.WebAppBannerNoTypeInManifest, where TypeParam =  and GetParam() =  (1341 ms)
"""
 
Interesting. This test is going away soon, but is being replaced by a similar test due to some internal refactoring (crrev.com/2156113002). I'll follow up on our Sierra test device when the refactor lands.
Ping?
This is still on my radar, but I haven't had a chance to look at it. As mentioned in #1, these tests have now disappeared and been replaced with InstallableManagerBrowserTests.
Correcting comment #3, these tests are now AppBannerManagerBrowserTests. I just checked them on sierra 10.12 (16A313a), and they all pass without an issue. Unless there's any other reason to keep this open, I think this can be WontFix'd.
Status: WontFix (was: Untriaged)

Sign in to add a comment