AppBannerDataFetcherBrowserTest failures on macOS Sierra |
||
Issue description
Failures:
AppBannerDataFetcherBrowserTest.WebAppBannerNoTypeInManifest (../../chrome/browser/banners/app_banner_data_fetcher_browsertest.cc:286)
AppBannerDataFetcherBrowserTest.WebAppBannerNoTypeInManifestCapsExtension (../../chrome/browser/banners/app_banner_data_fetcher_browsertest.cc:292)
e.g.
"""
[ RUN ] AppBannerDataFetcherBrowserTest.WebAppBannerNoTypeInManifest
2016-07-20 14:57:20.161 browser_tests[95193:1494463] NSWindow warning: adding an unknown subview: <FullSizeContentView: 0x7fbbe06cb150>. Break on NSLog to debug.
2016-07-20 14:57:20.161 browser_tests[95193:1494463] Call stack:
(
"+callStackSymbols disabled for performance reasons"
)
[95193:93975:0720/145720:WARNING:simple_synchronous_entry.cc(1054)] Could not open platform files for entry.
[95193:51471:0720/145720:WARNING:embedded_test_server.cc(193)] Request not handled. Returning 404: /favicon.ico
[95193:1547:0720/145720:ERROR:app_banner_data_fetcher_browsertest.cc(43)] OnDecidedWhetherToShow: 0
[95193:1547:0720/145720:ERROR:app_banner_data_fetcher_browsertest.cc(43)] OnDecidedWhetherToShow: 0
../../chrome/browser/banners/app_banner_data_fetcher_browsertest.cc:112: Failure
Value of: observer->will_show()
Actual: false
Expected: expected_to_show
Which is: true
[95193:1547:0720/145720:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown printing.enabled
[95193:1547:0720/145720:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown plugins.always_authorize
[95193:1547:0720/145720:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown plugins.allow_outdated
[ FAILED ] AppBannerDataFetcherBrowserTest.WebAppBannerNoTypeInManifest, where TypeParam = and GetParam() = (1341 ms)
"""
,
Sep 6 2016
Ping?
,
Sep 7 2016
This is still on my radar, but I haven't had a chance to look at it. As mentioned in #1, these tests have now disappeared and been replaced with InstallableManagerBrowserTests.
,
Sep 13 2016
Correcting comment #3, these tests are now AppBannerManagerBrowserTests. I just checked them on sierra 10.12 (16A313a), and they all pass without an issue. Unless there's any other reason to keep this open, I think this can be WontFix'd.
,
Oct 28 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by dominickn@chromium.org
, Jul 21 2016