Wrong colors on EV cert chip when dragging incognito tab
Reported by
jleedev@gmail.com,
Jul 20 2016
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.82 Safari/537.36 Steps to reproduce the problem: 1. Open incognito window 2. Visit EV cert page (github.com) 3. Begin dragging tab out of window What is the expected behavior? The dark theme should stay consistent. What went wrong? The background is dark grey and the lock is white but the text is green, which looks weird. Did this work before? N/A Chrome version: 52.0.2743.82 Channel: beta OS Version: OS X 10.11.6 Flash Version:
,
Jul 21 2016
spqchan@ - please take a look at this, but it's probably something we won't fix given the Omnibox changes that are in flight?
,
Jul 21 2016
Sure, I can look into this. I fixed a similar issue (the alert indicator being dragged) and this is something we should fix since the Omnibox changes won't solve it
,
Aug 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f54c0238952086f5cf5c3dce0f5bdbf88a6d4d72 commit f54c0238952086f5cf5c3dce0f5bdbf88a6d4d72 Author: spqchan <spqchan@chromium.org> Date: Mon Aug 15 18:33:27 2016 [Material][Mac] Fixed EV chip's dark theme colors Use hasDarkTheme instead of inIncognitoModeWithSystemTheme so that the chip gets the correct value. BUG= 629995 Review-Url: https://codereview.chromium.org/2241943002 Cr-Commit-Position: refs/heads/master@{#411994} [modify] https://crrev.com/f54c0238952086f5cf5c3dce0f5bdbf88a6d4d72/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm
,
Aug 15 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by rsesek@chromium.org
, Jul 21 2016Labels: Proj-MaterialDesign-NativeUI