Re-enable memory.top_10_mobile_stress.reference on Android |
||
Issue descriptionmemory.top_10_mobile_stress is now failing on Android reference build seemingly due to https://chromium.googlesource.com/chromium/src/+/578e8ff55813d82c373563039f8ab4db28264ed6 See example failing build: https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%20%283%29/builds/2592 I'm going to disable this test; leaving it to Kari to re-enable when she rolls the ref build.
,
Jul 20 2016
Ok the pointed CL needs to be reverted in this case. Created a revert: https://codereview.chromium.org/2166833003/
,
Jul 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aad3e5da6864138469892f1459137e19a0cd5e26 commit aad3e5da6864138469892f1459137e19a0cd5e26 Author: ssid <ssid@chromium.org> Date: Wed Jul 20 22:23:38 2016 Revert of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2162283002/ ) Reason for revert: Looks like some reference builds still haven't got the devtools api update. Original issue's description: > [telemetry] Trace config should be used to disable periodic dumps > > Telemetry previously used the "--enable-memory-benchmarking" flag to > tell memory dump manager to disable periodic dumps. That is cleaned up > in this CL and the trace config is used to achieve this behavior. > > Note to perf sheriff: Memory benchmarks could regress if the config > did not propagate correctly. > > BUG= 513692 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq > > Committed: https://crrev.com/578e8ff55813d82c373563039f8ab4db28264ed6 > Cr-Commit-Position: refs/heads/master@{#406598} TBR=nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 629988 , 513692 Review-Url: https://codereview.chromium.org/2166833003 Cr-Commit-Position: refs/heads/master@{#406691} [modify] https://crrev.com/aad3e5da6864138469892f1459137e19a0cd5e26/tools/perf/benchmarks/memory_infra.py [modify] https://crrev.com/aad3e5da6864138469892f1459137e19a0cd5e26/tools/perf/benchmarks/oortonline.py [modify] https://crrev.com/aad3e5da6864138469892f1459137e19a0cd5e26/tools/perf/benchmarks/system_health.py [modify] https://crrev.com/aad3e5da6864138469892f1459137e19a0cd5e26/tools/perf/benchmarks/v8.py
,
Jul 20 2016
Could you please re-enable the benchmark and I will land this CL once the reference is rolled?
,
Jul 20 2016
Didn't end up disabling. Sid, I'm just going to Wontfix this bug; consider CCing yourself the blocker (629987) to know when the reference build will be rolled.
,
Nov 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/813ee249f4aadce76998a6fc516fe7adccbb34be commit 813ee249f4aadce76998a6fc516fe7adccbb34be Author: ssid <ssid@chromium.org> Date: Thu Nov 17 11:52:37 2016 Reland of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2166833003/ ) Reason for revert: Reference build was rolled, Issue 629987 . Now reference build Devtools "Tracing.Start" should support trace config string. Original issue's description: > Revert of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2162283002/ ) > > Reason for revert: > Looks like some reference builds still haven't got the devtools api update. > > Original issue's description: > > [telemetry] Trace config should be used to disable periodic dumps > > > > Telemetry previously used the "--enable-memory-benchmarking" flag to > > tell memory dump manager to disable periodic dumps. That is cleaned up > > in this CL and the trace config is used to achieve this behavior. > > > > Note to perf sheriff: Memory benchmarks could regress if the config > > did not propagate correctly. > > > > BUG= 513692 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq > > > > Committed: https://crrev.com/578e8ff55813d82c373563039f8ab4db28264ed6 > > Cr-Commit-Position: refs/heads/master@{#406598} > > TBR=nednguyen@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= 629988 , 513692 > > Committed: https://crrev.com/aad3e5da6864138469892f1459137e19a0cd5e26 > Cr-Commit-Position: refs/heads/master@{#406691} TBR=nednguyen@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 629988 , 513692 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Review-Url: https://codereview.chromium.org/2458413002 Cr-Commit-Position: refs/heads/master@{#432846} [modify] https://crrev.com/813ee249f4aadce76998a6fc516fe7adccbb34be/tools/perf/benchmarks/memory_infra.py [modify] https://crrev.com/813ee249f4aadce76998a6fc516fe7adccbb34be/tools/perf/benchmarks/oortonline.py [modify] https://crrev.com/813ee249f4aadce76998a6fc516fe7adccbb34be/tools/perf/benchmarks/system_health.py [modify] https://crrev.com/813ee249f4aadce76998a6fc516fe7adccbb34be/tools/perf/benchmarks/v8.py |
||
►
Sign in to add a comment |
||
Comment 1 by eakuefner@chromium.org
, Jul 20 2016Labels: -Pri-3 Performance-Sheriff-BotHealth OS-Android Pri-2
Owner: aiolos@chromium.org
Status: Assigned (was: Untriaged)