Issue metadata
Sign in to add a comment
|
system_health.memory_mobile failing on Android Nexus5 Perf |
||||||||||||||||||||||||
Issue descriptionPetr: I haven't reverted because your CL says to contact you first. :) Looks like the Washington Post story may actually have a bug in it. First failing build: https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%20%281%29/builds/3722 Error: Traceback (most recent call last): File "/b/build/slave/Android_Nexus5_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 85, in _RunStoryAndProcessErrorIfNeeded state.RunStory(results) File "/b/build/slave/Android_Nexus5_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 319, in RunStory self._current_page.Run(self) File "/b/build/slave/Android_Nexus5_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/page/__init__.py", line 99, in Run self.RunPageInteractions(action_runner) File "/b/build/slave/Android_Nexus5_Perf__1_/build/src/tools/perf/page_sets/system_health/system_health_story.py", line 79, in RunPageInteractions self._DidLoadDocument(action_runner) File "/b/build/slave/Android_Nexus5_Perf__1_/build/src/tools/perf/page_sets/system_health/browsing_stories.py", line 186, in _DidLoadDocument action_runner.ClickElement(selector='.close') File "/b/build/slave/Android_Nexus5_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/internal/actions/action_runner.py", line 238, in ClickElement selector=selector, text=text, element_function=element_function)) File "/b/build/slave/Android_Nexus5_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/internal/actions/action_runner.py", line 45, in _RunAction action.RunAction(self._tab) File "/b/build/slave/Android_Nexus5_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/internal/actions/javascript_click.py", line 25, in RunAction element_function=self.element_function) File "/b/build/slave/Android_Nexus5_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/internal/actions/page_action.py", line 116, in EvaluateCallbackWithElement return tab.EvaluateJavaScript(code) File "/b/build/slave/Android_Nexus5_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 187, in EvaluateJavaScript expr, context_id=None, timeout=timeout) File "/b/build/slave/Android_Nexus5_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 215, in EvaluateJavaScriptInContext expr, context_id=context_id, timeout=timeout) File "/b/build/slave/Android_Nexus5_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 32, in inner return func(inspector_backend, *args, **kwargs) File "/b/build/slave/Android_Nexus5_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 203, in EvaluateJavaScript return self._runtime.Evaluate(expr, context_id, timeout) File "/b/build/slave/Android_Nexus5_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py", line 52, in Evaluate raise exceptions.EvaluateException(res['result']['result']['description']) EvaluateException: Error: Cannot find element: using selector ".close" at Error (native) at callback (<anonymous>:7:19) at <anonymous>:11:16 at <anonymous>:12:9
,
Jul 21 2016
Ulan: It seems that this is the same as issue 629163 , but it's on a phone (not a tablet). Could you please have a look? The issue has gone away, but I want to check that the story works correctly. I'm wondering whether we should add an `else` branch with an assertion to https://cs.chromium.org/chromium/src/tools/perf/page_sets/system_health/browsing_stories.py?l=210: assert action_runner.EvaluateJavaScript('!!document.querySelector("%s")' % self._MAIL_BUTTON_SELECTOR)
,
Jul 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10766908401f0dd9631b670aa252c33473c41f67 commit 10766908401f0dd9631b670aa252c33473c41f67 Author: ulan <ulan@chromium.org> Date: Thu Jul 21 10:48:52 2016 [system health] Make mobile washington post story more robust. This patch makes sure that we wait for either the "Close" or the "Send link to phone" button after loading the document. BUG= 629983 Review-Url: https://codereview.chromium.org/2171713003 Cr-Commit-Position: refs/heads/master@{#406816} [modify] https://crrev.com/10766908401f0dd9631b670aa252c33473c41f67/tools/perf/page_sets/system_health/browsing_stories.py [modify] https://crrev.com/10766908401f0dd9631b670aa252c33473c41f67/tools/perf/page_sets/system_health/loading_stories.py
,
Jul 22 2016
I'm afraid that https://codereview.chromium.org/2171713003 has broken some of the Android bots (https://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf%20%281%29/builds/3461): Traceback (most recent call last): File "/b/build/slave/Android_One_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 85, in _RunStoryAndProcessErrorIfNeeded state.RunStory(results) File "/b/build/slave/Android_One_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 319, in RunStory self._current_page.Run(self) File "/b/build/slave/Android_One_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/page/__init__.py", line 99, in Run self.RunPageInteractions(action_runner) File "/b/build/slave/Android_One_Perf__1_/build/src/tools/perf/page_sets/system_health/system_health_story.py", line 79, in RunPageInteractions self._DidLoadDocument(action_runner) File "/b/build/slave/Android_One_Perf__1_/build/src/tools/perf/page_sets/system_health/browsing_stories.py", line 209, in _DidLoadDocument (self._CLOSE_BUTTON_SELECTOR, self._MAIL_BUTTON_SELECTOR)) File "/b/build/slave/Android_One_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/internal/actions/action_runner.py", line 206, in WaitForElement timeout_in_seconds=timeout_in_seconds)) File "/b/build/slave/Android_One_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/internal/actions/action_runner.py", line 45, in _RunAction action.RunAction(self._tab) File "/b/build/slave/Android_One_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/internal/actions/wait.py", line 22, in RunAction wait=True, timeout_in_seconds=self.timeout_in_seconds) File "/b/build/slave/Android_One_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/internal/actions/page_action.py", line 113, in EvaluateCallbackWithElement tab.WaitForJavaScriptExpression(code, timeout_in_seconds) File "/b/build/slave/Android_One_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 136, in WaitForJavaScriptExpression e.message + '\n' + debug_message) TimeoutException: <unprintable TimeoutException object> So I'll revert it.
,
Jul 22 2016
Reverting: https://codereview.chromium.org/2172153004/
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf0294eaeb75f88766ef6513c4701d34af353507 commit cf0294eaeb75f88766ef6513c4701d34af353507 Author: petrcermak <petrcermak@chromium.org> Date: Fri Jul 22 12:12:27 2016 Revert of [system health] Make mobile washington post story more robust. (patchset #4 id:60001 of https://codereview.chromium.org/2171713003/ ) Reason for revert: It broke Android perf bots. Original issue's description: > [system health] Make mobile washington post story more robust. > > This patch makes sure that we wait for either the "Close" or > the "Send link to phone" button after loading the document. > > BUG= 629983 > > Committed: https://crrev.com/10766908401f0dd9631b670aa252c33473c41f67 > Cr-Commit-Position: refs/heads/master@{#406816} TBR=ulan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 629983 Review-Url: https://codereview.chromium.org/2172153004 Cr-Commit-Position: refs/heads/master@{#407136} [modify] https://crrev.com/cf0294eaeb75f88766ef6513c4701d34af353507/tools/perf/page_sets/system_health/browsing_stories.py [modify] https://crrev.com/cf0294eaeb75f88766ef6513c4701d34af353507/tools/perf/page_sets/system_health/loading_stories.py
,
Oct 5 2016
,
Oct 5 2016
,
Nov 18 2016
Marking this as fixed, as it seems the original problem was resolved. I'm perfbot health sheriff and am still seeing some problems with this benchmark, but will file them in a separate bug. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by petrcermak@chromium.org
, Jul 21 2016Status: Duplicate (was: Assigned)