[Autofill] Retain maximum use-count when merging two profiles. |
||
Issue descriptionWhen merging two autofill profile, chrome currently sums their use-count values into the resulting profile. This unduly skews the frecency score of the resulting profile. Instead, merging two autofill profiles should put the maximum use-count of the profiles into the resulting profile.
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aea4be33481181302f394083e1e046d1ea65bbee commit aea4be33481181302f394083e1e046d1ea65bbee Author: rogerm <rogerm@chromium.org> Date: Fri Jul 22 14:45:10 2016 Use the max use count on autofill profile merge. This CL retains the maximum autofill profile use-count, instead of summing the use-counts, when merging two profiles. The previous behaviour, summing, inflates the use-count during profile deduplication, double counts on profile usage, and falsely counts a fully-typed submission as a reuse of any profile it matched. All of these skew the frecency score of the resulting merged profile. BUG= 629978 R=mathp@chromium.org, sebsg@chromium.org Review-Url: https://codereview.chromium.org/2164143002 Cr-Commit-Position: refs/heads/master@{#407156} [modify] https://crrev.com/aea4be33481181302f394083e1e046d1ea65bbee/components/autofill/core/browser/autofill_profile.cc [modify] https://crrev.com/aea4be33481181302f394083e1e046d1ea65bbee/components/autofill/core/browser/autofill_profile_unittest.cc [modify] https://crrev.com/aea4be33481181302f394083e1e046d1ea65bbee/components/autofill/core/browser/personal_data_manager_unittest.cc [modify] https://crrev.com/aea4be33481181302f394083e1e046d1ea65bbee/components/autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc [modify] https://crrev.com/aea4be33481181302f394083e1e046d1ea65bbee/components/browser_sync/browser/profile_sync_service_autofill_unittest.cc
,
Oct 7 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jul 22 2016