New issue
Advanced search Search tips

Issue 629958 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 672343


Participants' hotlists:
MacViews-Task-Queue


Sign in to add a comment

MacViews: remove gradients

Project Member Reported by ellyjo...@chromium.org, Jul 20 2016

Issue description

We decided not to go with gradients, so those need to be removed.
 

Comment 1 by tapted@chromium.org, Jul 22 2016

Blocking: 630478

Comment 2 by tapted@chromium.org, Dec 12 2016

Blocking: -630478 672343
Cc: tapted@chromium.org ellyjo...@chromium.org
Labels: M-58
Owner: ----
Status: Available (was: Started)
Doesn't need to block release, but adding a milestone to give it a bit more priority than the other `CodeHealth` ones.

(I think I have an idea what needs to be nuked - should be easier now that the flags are consolidated)
Status: Fixed (was: Available)
We don't have any gradients left and this bug is obsolete.
Status: Available (was: Fixed)
We need to remove some dead code still. Things like NativeThemeMac::GetButtonBackgroundShader()
Cc: -ellyjo...@chromium.org
Labels: -M-58 MacViews-Cleanup
Owner: ellyjo...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ae3b7003dfa719948403cfceb9410028ac47835

commit 4ae3b7003dfa719948403cfceb9410028ac47835
Author: ellyjones <ellyjones@chromium.org>
Date: Mon Apr 24 13:41:02 2017

ui: remove dead NativeThemeMac code

The code for drawing Shiny Modern style buttons is long-dead.

BUG= 629958 

Review-Url: https://codereview.chromium.org/2834173002
Cr-Commit-Position: refs/heads/master@{#466623}

[modify] https://crrev.com/4ae3b7003dfa719948403cfceb9410028ac47835/ui/native_theme/native_theme_mac.h
[modify] https://crrev.com/4ae3b7003dfa719948403cfceb9410028ac47835/ui/native_theme/native_theme_mac.mm

Status: Fixed (was: Assigned)
All references to Shiny Modern are gone, as is all the support code.

Sign in to add a comment