New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629946 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 629731



Sign in to add a comment

Some PaintChunkerTest cases fail on windows debug bots

Project Member Reported by wangxianzhu@chromium.org, Jul 20 2016

Issue description

Some PaintChunkerTest cases fail on Windows debug bots with the PaintChunk Id change (https://codereview.chromium.org/2116693002/):

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/89039

http://build.chromium.org/p/tryserver.blink/builders/win_blink_dbg/builds/4718

The failures look like crashes, but nowhere indicates they are crashes. Only stack traces shown without any symbol.

Didn't reproduce on Windows 10 dev machine.

File this bug to unblock the CL.

 
Blockedon: 629731
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1101d498d5054ecda5c4f6481b4738d7873b4da

commit a1101d498d5054ecda5c4f6481b4738d7873b4da
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Thu Jul 21 07:08:36 2016

Reland PaintChunk::id

The id will be used in rasterization paint invalidation to match old
and new paint chunks. It can be also used in incremental layerization.

Original review url: https://codereview.chromium.org/2116693002

BUG= 510908 , 629946 

Review-Url: https://codereview.chromium.org/2116693002
Review-Url: https://codereview.chromium.org/2168513005
Cr-Original-Commit-Position: refs/heads/master@{#406461}
Cr-Commit-Position: refs/heads/master@{#406793}

[modify] https://crrev.com/a1101d498d5054ecda5c4f6481b4738d7873b4da/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/a1101d498d5054ecda5c4f6481b4738d7873b4da/third_party/WebKit/Source/core/paint/BlockPainter.cpp
[modify] https://crrev.com/a1101d498d5054ecda5c4f6481b4738d7873b4da/third_party/WebKit/Source/core/paint/BoxClipper.cpp
[modify] https://crrev.com/a1101d498d5054ecda5c4f6481b4738d7873b4da/third_party/WebKit/Source/core/paint/FramePainter.cpp
[modify] https://crrev.com/a1101d498d5054ecda5c4f6481b4738d7873b4da/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/a1101d498d5054ecda5c4f6481b4738d7873b4da/third_party/WebKit/Source/core/paint/SVGPaintContext.h
[modify] https://crrev.com/a1101d498d5054ecda5c4f6481b4738d7873b4da/third_party/WebKit/Source/core/paint/ScrollableAreaPainter.cpp
[modify] https://crrev.com/a1101d498d5054ecda5c4f6481b4738d7873b4da/third_party/WebKit/Source/platform/blink_platform.gypi
[modify] https://crrev.com/a1101d498d5054ecda5c4f6481b4738d7873b4da/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h
[modify] https://crrev.com/a1101d498d5054ecda5c4f6481b4738d7873b4da/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h
[modify] https://crrev.com/a1101d498d5054ecda5c4f6481b4738d7873b4da/third_party/WebKit/Source/platform/graphics/paint/PaintChunk.h
[add] https://crrev.com/a1101d498d5054ecda5c4f6481b4738d7873b4da/third_party/WebKit/Source/platform/graphics/paint/PaintChunkTest.cpp
[modify] https://crrev.com/a1101d498d5054ecda5c4f6481b4738d7873b4da/third_party/WebKit/Source/platform/graphics/paint/PaintChunker.cpp
[modify] https://crrev.com/a1101d498d5054ecda5c4f6481b4738d7873b4da/third_party/WebKit/Source/platform/graphics/paint/PaintChunker.h
[modify] https://crrev.com/a1101d498d5054ecda5c4f6481b4738d7873b4da/third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp
[modify] https://crrev.com/a1101d498d5054ecda5c4f6481b4738d7873b4da/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/a1101d498d5054ecda5c4f6481b4738d7873b4da/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
[modify] https://crrev.com/a1101d498d5054ecda5c4f6481b4738d7873b4da/third_party/WebKit/Source/platform/graphics/paint/ScopedPaintChunkProperties.h
[modify] https://crrev.com/a1101d498d5054ecda5c4f6481b4738d7873b4da/third_party/WebKit/Source/platform/testing/FakeDisplayItemClient.h
[modify] https://crrev.com/a1101d498d5054ecda5c4f6481b4738d7873b4da/third_party/WebKit/Source/platform/testing/PaintPrinters.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acd3292620e912700a18c15346a9b1f391493279

commit acd3292620e912700a18c15346a9b1f391493279
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Sat Dec 10 19:24:55 2016

Enable PaintChunkerTest on windows debug build

BUG= 629946 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2563683003
Cr-Commit-Position: refs/heads/master@{#437775}

[modify] https://crrev.com/acd3292620e912700a18c15346a9b1f391493279/third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp

Sign in to add a comment