New issue
Advanced search Search tips

Issue 629933 link

Starred by 4 users

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

UI font stretched

Reported by pdk...@gmail.com, Jul 20 2016

Issue description

UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.82 Safari/537.36

In M52, the UI font is stretched. In particular letter-spacing is increased, but also the width of each letter (albeit only slightly). This affects all parts of the UI, like tabs and the menu.

As you can notice in the animated WebP, the vertical font position in tabs has also changed. (Perhaps for the better.)
 
5152.webp
4.6 KB View Download
Cc: est...@chromium.org
How do you know that's "stretched" and not just a different font size/face?  This doesn't look like a bug to me.

Comment 2 Deleted

Comment 3 by pdk...@gmail.com, Jul 20 2016

Both are the same Ubuntu Regular font. You can tell by the shape of the G.

http://font.ubuntu.com/

A clear regression IMO, particularly in tabs, which have less text
displayed now. (I should've used a tab with more text, but already had
the image from M51, and didn't want to download it again.)

Comment 4 by gov...@chromium.org, Jul 20 2016

Cc: ligim...@chromium.org
Components: UI>Browser>TabStrip
Labels: Proj-MaterialDesign-NativeUI

Comment 6 by pdk...@gmail.com, Jul 20 2016

I forgot to mention that the address bar is not affected by this, and still renders as before.



Comment 7 by est...@chromium.org, Jul 20 2016

looks like the size changed slightly. Doesn't seem like an issue to me.

Comment 8 by pdk...@gmail.com, Jul 20 2016

I found the culprit.

https://chromium.googlesource.com/chromium/src/+/52c96f45954fb726585acd0bac295d801728b22e%5E%21/

(It's between 397169 and 397176 and only this commit is related.)

I have DPI set lower than 96, which is ignored now. I'm not sure what prompted this change.

Comment 9 by est...@chromium.org, Jul 20 2016

Owner: osh...@chromium.org
Status: Assigned (was: Unconfirmed)
Assigning to oshima@ to triage, fix, or close as appropriate.
How are you setting the dpi on X?

Comment 11 by pdk...@gmail.com, Jul 20 2016

Through text-scale-factor on Ubuntu, which does all the rest automatically.

$ dconf read /com/canonical/unity/interface/text-scale-factor

I checked and gtk-xft-dpi is set accordingly.

Comment 12 Deleted

Linux chrome does not support dynamic scale change. The behavior is undefined after the scale is changed until chrome is restarted, because there are other parts that depends on gtk in chrome. (font etc)

The CL in #8 is to avoid more problematic behavior (see  crbug.com/615353 ).

If you have this even after restarted, my CL is less likely to be a culprit, but I can confirm/test it. Please let me know the value you're using.

Comment 14 by pdk...@gmail.com, Jul 21 2016

The problem is this line, which discards DPI < 96.

dpi = std::max(kDefaultDPI, dpi);

(I don't care about dynamic change.)

Comment 15 Deleted

I typically run my desktop environment with text/menu/title scaling set to about .85. I feel I get more screen real estate that way. Ever since I updated my Chrome installation yesterday all the Chrome UI elements don't appear to be obeying my scaling setting.

The tab fonts are much larger and I see less information per-tab title. Password prompt popups use a much larger font than any other UI component and finally the bookmarks tab font has increased as well, I see less bookmark folders than I used to.

I don't like it this way. Chrome should obey my GTK UI scaling settings.

Comment 17 by pdk...@gmail.com, Jul 24 2016

As this is a simple fix, may I request it to be merged afterwards. Thanks.

Comment 18 by ano...@gmail.com, Jul 25 2016

I can confirm text sizing on webpages that do not set font-size is increased in Chrome 52.0.2743.82 (64-bit) on Ubuntu 16.04.

$ xdpyinfo | grep dots
  resolution:    96x96 dots per inch

Comment 19 by pdk...@gmail.com, Jul 25 2016

That value is most likely incorrect. (It's always 96 DPI in Ubuntu.)

You should try https://github.com/derat/font-config-info and report gtk-xft-dpi.

Comment 20 by ano...@gmail.com, Jul 26 2016

gtk-xft-dpi          98304 (96,00 DPI)

Comment 21 by pdk...@gmail.com, Jul 26 2016

I think you might have a different bug then.

Comment 22 by pdk...@gmail.com, Aug 17 2016

Any update? The limitation to >= 96 DPI is unrelated to the problem fixed in the mentioned CL and arbitrary.
I don't think we plan to support <1x dsf, if that's what you're asking.

Comment 24 by pdk...@gmail.com, Aug 17 2016

Why? Odd decision IMO.
Status: WontFix (was: Assigned)
Supporting it doesn't mean just removing the line that disallows it. Supporting it means fixing bugs that crop up throughout Chrome when the scale factor is less than 1, figuring out a way to make our smaller icons look good at <1x scale, etc. The engineering cost is not worth the benefit because very few users have <1x scale.

Comment 26 by pdk...@gmail.com, Aug 18 2016

I think there is a bit of a misunderstanding here. The reason for
users setting DPI < 96 is because quite a few screens have physical
DPI < 96. Matching it improves text display. I don't understand how
this is related to DSF.

And as you mention, there is no "support" anyway. It just works.

Comment 27 by pdk...@gmail.com, Oct 25 2016

https://codereview.chromium.org/2441043002/

For some reason it took another bug report to get this fixed.

https://bugs.chromium.org/p/chromium/issues/detail?id=646254

psknsk: Thanks for the CR link, copied to the bug I reported.
@everyone: working interim fix/hack:

  $ cat ~/.gtkrc-2.0
  gtk-font-name = "Sans 8"

Do something like `GTK2_RC_FILES=path/to/custom/gtkrc chromium` to isolate the font size change to Chrome if you want/need to. More discussion in the bug linked in #27.

I recommend continuing to track this issue (track both bugs, I say) to find out what Chrome's official fix is.

Comment 30 by pdk...@gmail.com, Dec 7 2016

I can confirm that the issue is fixed.

https://chromium.googlesource.com/chromium/src/+/a98afff3156eb88b39f82cfae23d99bed436bb3c

Thanks for filing a duplicate bug report, which for some reason made Google fix this.

Sign in to add a comment