New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629932 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in LayoutUnit's unary operator -

Project Member Reported by ClusterFuzz, Jul 20 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6642495433998336

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::SVGRootInlineBox::layoutRootBox
  blink::SVGRootInlineBox::computePerCharacterLayoutInformation
  blink::LayoutBlockFlow::createLineBoxesFromBidiRuns
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=370022:370027

Minimized Testcase (1.62 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95OptYABmkme5ihMIQAl1PT9SwQ6kTE1rORmaYtAEi2Ft7GkxG4APIeEn5Tw3XeOYpqCRIgF6eUQclQSzJ1QhcfpkUzPZOZJGzZPpUwPPQzixWaYk-T6DQmiOE2sGorRn6PLe_EBf_QMdCqXuHGpDOQHe9Taw?testcase_id=6642495433998336

Additional requirements: Requires HTTP

Filer: mummareddy

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Tools>Test>FindIt>WrongResult Blink>SVG
Labels: Te-Logged M-52
Owner: roc...@chromium.org
Status: Assigned (was: Available)

Author: eae@chromium.org
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/70e39074ac4ebdf18d406fbd56a5ddde4c8e989e
Time: Wed Nov 07 18:33:44 2012
The CL last changed line 648 of file LayoutUnit.h, which is stack frame 0.

Author: wangxianzhu@chromium.org
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/75d0d2d3144bf7df9970f81d1cd6e9f0ff5be221
Time: Wed Jun 17 22:42:16 2015
The CL last changed line 120 of file SVGRootInlineBox.cpp, which is stack frame 1.

Author: leo.yang@torchmobile.com.cn
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/431c6d5d635f44a3b04975183028923395536765
Time: Fri May 20 07:56:57 2011
The CL last changed line 71 of file SVGRootInlineBox.cpp, which is stack frame 2.

Author: gyuyoung.kim@samsung.com
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/9baf8c49d146020322e29f52fa65a68944d79101
Time: Fri Sep 13 02:55:49 2013
The CL last changed line 729 of file LayoutBlockFlowLine.cpp, which is stack frame 3.

Author: igor.o@sisa.samsung.com
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/639ba3409ef6d32f45b723a887dee5068679da2a
Time: Tue Nov 05 22:17:28 2013
The CL last changed line 897 of file LayoutBlockFlowLine.cpp, which is stack frame 4.

Author: eae@chromium.org
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/48ed17cf1d50988a715c1d367dc810d575dcb359
Time: Thu Jul 31 20:05:09 2014
The CL last changed line 769 of file LayoutBlockFlowLine.cpp, which is stack frame 5.

Author: leviw@chromium.org
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/b40f5755401fe50b434912aa7400d61b6cbbdb9f
Time: Sat Jan 25 00:19:25 2014
The CL last changed line 1602 of file LayoutBlockFlowLine.cpp, which is stack frame 6.

Suspected Project: chromium
Suspected Component: Blink>SVG

As per code search on file SVGRootInlineBox.cpp, recent changes done by rockot@. could you please help us to find correct owner?
Thank you.

Comment 2 by roc...@chromium.org, Jul 20 2016

Cc: f...@opera.com
Owner: wangxianzhu@chromium.org
I'm not sure how you came up with my name, I've never touched any of these files. Over to wangxianzhu@ based on your rationale (SVGRootInlineBox.cpp) and CCing fs@opera.com for recent changes to that file.
Thank you very much for your help.
Cc: -f...@opera.com fs@chromium.org pdr@chromium.org
Labels: -Pri-1 Pri-2
Summary: Integer-overflow in LayoutUnit's unary operator - (was: Integer-overflow in blink::SVGRootInlineBox::layoutRootBox)
"runtime error: negation of -2147483648 cannot be represented in type int; cast to an unsigned type to negate this value to itself"

-LayoutUnit::min() should be saturated to LayoutUnit::max().
Cc: wangxianzhu@chromium.org
 Issue 629947  has been merged into this issue.

Comment 6 by f...@opera.com, Jul 20 2016

Cc: -fs@chromium.org f...@opera.com
Cc: le...@chromium.org
 Issue 629916  has been merged into this issue.
Cc: yutak@chromium.org
 Issue 629944  has been merged into this issue.
Cc: msten...@opera.com
 Issue 629650  has been merged into this issue.
Cc: esprehn@chromium.org
 Issue 629655  has been merged into this issue.

Comment 11 by f...@opera.com, Jul 20 2016

These last three doesn't look like obvious dupes.
Right. I just de-duplicated them.
De-duplicated  bug 629655  and  bug 629944 .  Bug 629650 ,  bug 629916  and  bug 629947  are valid dupes.
Labels: -OS-Linux -Stability-Crash -M-52 -Stability-UndefinedBehaviorSanitizer OS-All
Remove crash and stability labels because it doesn't crash on user machines, and this integer overflow do no harm to security and stability.
Status: Fixed (was: Assigned)
 Issue 630223  has been merged into this issue.
Project Member

Comment 18 by ClusterFuzz, Jul 21 2016

ClusterFuzz has detected this issue as fixed in range 406657:406809.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6642495433998336

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::SVGRootInlineBox::layoutRootBox
  blink::SVGRootInlineBox::computePerCharacterLayoutInformation
  blink::LayoutBlockFlow::createLineBoxesFromBidiRuns
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=370022:370027
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=406657:406809

Minimized Testcase (1.62 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95OptYABmkme5ihMIQAl1PT9SwQ6kTE1rORmaYtAEi2Ft7GkxG4APIeEn5Tw3XeOYpqCRIgF6eUQclQSzJ1QhcfpkUzPZOZJGzZPpUwPPQzixWaYk-T6DQmiOE2sGorRn6PLe_EBf_QMdCqXuHGpDOQHe9Taw?testcase_id=6642495433998336

Additional requirements: Requires HTTP

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Components: -Tools>Test>FindIt>WrongResult
Labels: Test-Predator-Wrong
Project Member

Comment 21 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment