Integer-overflow in LayoutUnit's unary operator - |
||||||||
Issue descriptionDetailed report: https://cluster-fuzz.appspot.com/testcase?key=6642495433998336 Fuzzer: inferno_twister Job Type: linux_ubsan_chrome Platform Id: linux Crash Type: Integer-overflow Crash Address: Crash State: blink::SVGRootInlineBox::layoutRootBox blink::SVGRootInlineBox::computePerCharacterLayoutInformation blink::LayoutBlockFlow::createLineBoxesFromBidiRuns Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=370022:370027 Minimized Testcase (1.62 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95OptYABmkme5ihMIQAl1PT9SwQ6kTE1rORmaYtAEi2Ft7GkxG4APIeEn5Tw3XeOYpqCRIgF6eUQclQSzJ1QhcfpkUzPZOZJGzZPpUwPPQzixWaYk-T6DQmiOE2sGorRn6PLe_EBf_QMdCqXuHGpDOQHe9Taw?testcase_id=6642495433998336 Additional requirements: Requires HTTP Filer: mummareddy See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
,
Jul 20 2016
I'm not sure how you came up with my name, I've never touched any of these files. Over to wangxianzhu@ based on your rationale (SVGRootInlineBox.cpp) and CCing fs@opera.com for recent changes to that file.
,
Jul 20 2016
Thank you very much for your help.
,
Jul 20 2016
"runtime error: negation of -2147483648 cannot be represented in type int; cast to an unsigned type to negate this value to itself" -LayoutUnit::min() should be saturated to LayoutUnit::max().
,
Jul 20 2016
,
Jul 20 2016
,
Jul 20 2016
,
Jul 20 2016
,
Jul 20 2016
,
Jul 20 2016
,
Jul 20 2016
These last three doesn't look like obvious dupes.
,
Jul 20 2016
Right. I just de-duplicated them.
,
Jul 20 2016
De-duplicated bug 629655 and bug 629944 . Bug 629650 , bug 629916 and bug 629947 are valid dupes.
,
Jul 21 2016
Remove crash and stability labels because it doesn't crash on user machines, and this integer overflow do no harm to security and stability.
,
Jul 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef6bea224f0266018c3b4fc63262769020b9a4c2 commit ef6bea224f0266018c3b4fc63262769020b9a4c2 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Thu Jul 21 00:59:09 2016 Avoid integer overflow in LayoutUnit's unary minus operator BUG= 629932 Review-Url: https://codereview.chromium.org/2160983007 Cr-Commit-Position: refs/heads/master@{#406734} [modify] https://crrev.com/ef6bea224f0266018c3b4fc63262769020b9a4c2/third_party/WebKit/Source/platform/LayoutUnit.h [modify] https://crrev.com/ef6bea224f0266018c3b4fc63262769020b9a4c2/third_party/WebKit/Source/platform/LayoutUnitTest.cpp
,
Jul 21 2016
,
Jul 21 2016
Issue 630223 has been merged into this issue.
,
Jul 21 2016
ClusterFuzz has detected this issue as fixed in range 406657:406809. Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6642495433998336 Fuzzer: inferno_twister Job Type: linux_ubsan_chrome Platform Id: linux Crash Type: Integer-overflow Crash Address: Crash State: blink::SVGRootInlineBox::layoutRootBox blink::SVGRootInlineBox::computePerCharacterLayoutInformation blink::LayoutBlockFlow::createLineBoxesFromBidiRuns Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=370022:370027 Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=406657:406809 Minimized Testcase (1.62 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95OptYABmkme5ihMIQAl1PT9SwQ6kTE1rORmaYtAEi2Ft7GkxG4APIeEn5Tw3XeOYpqCRIgF6eUQclQSzJ1QhcfpkUzPZOZJGzZPpUwPPQzixWaYk-T6DQmiOE2sGorRn6PLe_EBf_QMdCqXuHGpDOQHe9Taw?testcase_id=6642495433998336 Additional requirements: Requires HTTP See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Jul 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/224e6490115e915ed5e6bc72a7a0bafe32d29389 commit 224e6490115e915ed5e6bc72a7a0bafe32d29389 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Thu Jul 21 18:35:18 2016 Better performance for -LayoutUnit BUG= 629932 Review-Url: https://codereview.chromium.org/2171813002 Cr-Commit-Position: refs/heads/master@{#406913} [modify] https://crrev.com/224e6490115e915ed5e6bc72a7a0bafe32d29389/third_party/WebKit/Source/platform/LayoutUnit.h [modify] https://crrev.com/224e6490115e915ed5e6bc72a7a0bafe32d29389/third_party/WebKit/Source/wtf/SaturatedArithmetic.h [modify] https://crrev.com/224e6490115e915ed5e6bc72a7a0bafe32d29389/third_party/WebKit/Source/wtf/asm/SaturatedArithmeticARM.h
,
Oct 18 2016
,
Nov 22 2016
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mummare...@chromium.org
, Jul 20 2016Labels: Te-Logged M-52
Owner: roc...@chromium.org
Status: Assigned (was: Available)