New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 629925 link

Starred by 2 users
Status: Fixed
Owner:
ssid@chromium.org
Closed: Nov 2016
Cc:
haraken@chromium.org
█ dskiba@chromium.org
primiano@chromium.org
█ picksi@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

MemoryInfra: Support BACKGROUND mode in all possible dump providers

Project Member Reported by ssid@chromium.org, Jul 20 2016 
Background context:go/memory-infra: memory profiling in chrome://tracing

Memory-infra is enabled in slow reports in background mode. But, this does not have all dump providers enabled since they do not support background mode dumps : light and quick.

Doc: https://docs.google.com/document/d/1KGE1P4rN_wSGXUsg-bbuXN5K7axCnAEtgxPL83eR9n4/edit
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/203b334b85d015fb651010ba89e6c6f31bae2b2e

commit 203b334b85d015fb651010ba89e6c6f31bae2b2e
Author: ssid <ssid@chromium.org>
Date: Thu Sep 15 20:40:26 2016

[tracing] Support BACKGROUND mode in MemoryCache dump provider

This CL adds support for BACKGROUND mode in MemoryCache dump provider,
where it just adds the total sizes of resources (given by encodedSize
of each resource).
This CL also fixes the image resources reporting which had a shared
buffer that was not reported in the ImageResource subclass.
It also fixes the SharedBuffer::onMemoryDump to dump when both shared
buffer and segments are used together.

BUG= 629925 

Review-Url: https://codereview.chromium.org/2337733002
Cr-Commit-Position: refs/heads/master@{#418957}

[modify] https://crrev.com/203b334b85d015fb651010ba89e6c6f31bae2b2e/third_party/WebKit/Source/core/fetch/ImageResource.cpp
[modify] https://crrev.com/203b334b85d015fb651010ba89e6c6f31bae2b2e/third_party/WebKit/Source/core/fetch/ImageResource.h
[modify] https://crrev.com/203b334b85d015fb651010ba89e6c6f31bae2b2e/third_party/WebKit/Source/core/fetch/MemoryCache.cpp
[modify] https://crrev.com/203b334b85d015fb651010ba89e6c6f31bae2b2e/third_party/WebKit/Source/core/fetch/MemoryCache.h
[modify] https://crrev.com/203b334b85d015fb651010ba89e6c6f31bae2b2e/third_party/WebKit/Source/platform/MemoryCacheDumpProvider.cpp
[modify] https://crrev.com/203b334b85d015fb651010ba89e6c6f31bae2b2e/third_party/WebKit/Source/platform/SharedBuffer.cpp
[modify] https://crrev.com/203b334b85d015fb651010ba89e6c6f31bae2b2e/third_party/WebKit/Source/platform/web_process_memory_dump.h
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7090f39927449b83607975614be0105a8cf93f4

commit d7090f39927449b83607975614be0105a8cf93f4
Author: ssid <ssid@chromium.org>
Date: Tue Sep 27 00:44:33 2016

[tracing] Whitelist levelDb and webcache dump providers for background mode

These providers support background mode now and can be whitelisted.

BUG= 629925 

Review-Url: https://codereview.chromium.org/2347743002
Cr-Commit-Position: refs/heads/master@{#421053}

[modify] https://crrev.com/d7090f39927449b83607975614be0105a8cf93f4/base/trace_event/memory_infra_background_whitelist.cc

Comment 3 by primiano@chromium.org, Nov 25 2016

Labels: -Pri-2 Pri-3
Status: Started (was: Untriaged)
can we close this? I think we got there? or is there action left?

Comment 4 by ssid@chromium.org, Nov 29 2016

Status: Fixed (was: Started)
yeah, I think kept it open in case I wanted a bug number for some CL.

Comment 5 by primiano@chromium.org, Jan 4 2017

Components: Internals>Instrumentation>Memory
►

Sign in to add a comment