MD Settings: Site options popup menus still use paper-menu |
|||||||||
Issue descriptionIn the rest of the codebase we have been using <iron-dropdown> with <button>s combination (see examples [1] and [2]). Site settings still uses <paper-menu> with <paper-item>s (see [3]. Not only those components are more expensive, they also don't look right (see screenshot where the popup menu is squashed to the right of the click target). [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html?l=39-65 [2] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html?l=24-38 [3] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/site_settings/site_list.html?l=55-82
,
Jul 20 2016
,
Jul 22 2016
,
Jul 22 2016
,
Sep 21 2016
,
Oct 4 2016
,
Oct 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f6bea6b3b13dc044d18813348c1137d0d0b51bc commit 0f6bea6b3b13dc044d18813348c1137d0d0b51bc Author: finnur <finnur@chromium.org> Date: Wed Oct 05 18:27:18 2016 Site Settings Desktop: Switch out Site-List paper-menu for iron-dropdown. BUG= 629920 , 625805 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2386993005 Cr-Commit-Position: refs/heads/master@{#423228} [modify] https://crrev.com/0f6bea6b3b13dc044d18813348c1137d0d0b51bc/chrome/browser/resources/settings/site_settings/site_list.html [modify] https://crrev.com/0f6bea6b3b13dc044d18813348c1137d0d0b51bc/chrome/browser/resources/settings/site_settings/site_list.js [modify] https://crrev.com/0f6bea6b3b13dc044d18813348c1137d0d0b51bc/chrome/test/data/webui/settings/site_list_tests.js
,
Oct 6 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f6bea6b3b13dc044d18813348c1137d0d0b51bc commit 0f6bea6b3b13dc044d18813348c1137d0d0b51bc Author: finnur <finnur@chromium.org> Date: Wed Oct 05 18:27:18 2016 Site Settings Desktop: Switch out Site-List paper-menu for iron-dropdown. BUG= 629920 , 625805 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2386993005 Cr-Commit-Position: refs/heads/master@{#423228} [modify] https://crrev.com/0f6bea6b3b13dc044d18813348c1137d0d0b51bc/chrome/browser/resources/settings/site_settings/site_list.html [modify] https://crrev.com/0f6bea6b3b13dc044d18813348c1137d0d0b51bc/chrome/browser/resources/settings/site_settings/site_list.js [modify] https://crrev.com/0f6bea6b3b13dc044d18813348c1137d0d0b51bc/chrome/test/data/webui/settings/site_list_tests.js
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by dbeam@chromium.org
, Jul 20 2016