New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629915 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

telemetry_AFDOGenerate should support more than Sandybridge

Project Member Reported by bhthompson@chromium.org, Jul 20 2016

Issue description

It looks like telemetry_AFDOGenerate currently only supports Sandybridge systems by a whitelist in the test itself, this seems very limiting.

We have this test enabled on the release branch pre-flight builder, and the build target for that builder recently needed to change from lumpy to cyan as it needs to have cheets support. The build is green but this autotest is failing https://uberchromegw.corp.google.com/i/chromeos_release/builders/cyan-pre-flight-branch%20release-R53-8530.B/builds/17 'TestFail: This test cannot be run on board cyan'.

Can we just add a newer x86 board to this? Are there risks we should be concerned about?
 
Owner: llozano@chromium.org
Luis could you take a look at this?

I can make a CL to add cyan, but I defer to your expertise if this is a good idea or not.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 20 2016

Labels: merge-merged-release-R53-8530.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/aab636f41f2a0d9a4306405d34b8df9607f88ee5

commit aab636f41f2a0d9a4306405d34b8df9607f88ee5
Author: Bernie Thompson <bhthompson@google.com>
Date: Wed Jul 20 20:38:27 2016

Switch release branch pre-flight builder over to samus

The telemetry_AFDOGenerate requires lab systems with 4GB+ RAM, so to
run this test in the pre-flight branch we need to use samus.

BUG= chromium:629915 
TEST=None

Change-Id: Id2786ff510626ffadb1bc50e83be651c85c19dc0
Reviewed-on: https://chromium-review.googlesource.com/361974
Reviewed-by: Luis Lozano <llozano@chromium.org>
Commit-Queue: Bernie Thompson <bhthompson@chromium.org>
Tested-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/aab636f41f2a0d9a4306405d34b8df9607f88ee5/cbuildbot/config_dump.json
[modify] https://crrev.com/aab636f41f2a0d9a4306405d34b8df9607f88ee5/cbuildbot/waterfall_layout_dump.txt
[modify] https://crrev.com/aab636f41f2a0d9a4306405d34b8df9607f88ee5/cbuildbot/chromeos_config.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/fe9e3f543ac55f4b002cf4620869a51fb2585473

commit fe9e3f543ac55f4b002cf4620869a51fb2585473
Author: Bernie Thompson <bhthompson@google.com>
Date: Thu Jul 21 16:10:53 2016

Switch release branch pre-flight builder over to samus

The telemetry_AFDOGenerate requires lab systems with 4GB+ RAM, so to
run this test in the pre-flight branch we need to use samus.

BUG= chromium:629915 
TEST=None

Change-Id: Id2786ff510626ffadb1bc50e83be651c85c19dc0
Reviewed-on: https://chromium-review.googlesource.com/361974
Reviewed-by: Luis Lozano <llozano@chromium.org>
Commit-Queue: Bernie Thompson <bhthompson@chromium.org>
Tested-by: Bernie Thompson <bhthompson@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/362311
Commit-Ready: Bernie Thompson <bhthompson@chromium.org>
Reviewed-by: David Riley <davidriley@chromium.org>

[modify] https://crrev.com/fe9e3f543ac55f4b002cf4620869a51fb2585473/cbuildbot/config_dump.json
[modify] https://crrev.com/fe9e3f543ac55f4b002cf4620869a51fb2585473/cbuildbot/waterfall_layout_dump.txt
[modify] https://crrev.com/fe9e3f543ac55f4b002cf4620869a51fb2585473/cbuildbot/chromeos_config.py

Comment 4 by lloz...@google.com, Aug 23 2016

the change for this was reviewed in 
https://chromium-review.googlesource.com/#/c/362073/
(Sorry I forgot to reference this bug in the CL)

Status: Fixed (was: Untriaged)

Comment 6 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 7 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58
Status: Verified (was: Fixed)

Sign in to add a comment