bisect buildbucket.get() step not handling failure |
|||||||
Issue descriptionExample: green step: https://build.chromium.org/p/tryserver.chromium.perf/builders/win_8_perf_bisect/builds/2042/steps/buildbucket.get%20%285%29/ Output (notice result and failure_reason: { "build": { "bucket": "master.tryserver.chromium.perf", "completed_ts": "1468768218843400", "created_by": "user:446450136466-ugqfr4djan52mqrm39lernfnho0lafi5@developer.gserviceaccount.com", "created_ts": "1468764106413730", "failure_reason": "INFRA_FAILURE", "id": "9006882924416517104", "parameters_json": "{\"builder_name\": \"win_perf_bisect_builder\", \"properties\": {\"build_archive_url\": \"gs://chrome-perf-tryjob/Win Builder/full-build-win32_d1a7457666ee116f4500cc7c1e69bff2831126b1_9813a61b-bfb9-4090-9e99-a5e9bcbdb007.zip\", \"clobber\": true, \"issue\": 2157853002, \"parent_got_revision\": \"d1a7457666ee116f4500cc7c1e69bff2831126b1\", \"patch_storage\": \"rietveld\", \"patchset\": 1, \"rietveld\": \"https://codereview.chromium.org\"}}", "result": "FAILURE", "result_details_json": "{...}}", "status": "COMPLETED", "status_changed_ts": "1468768218843360", "tags": [ "builder:win_perf_bisect_builder", "buildset:patch/rietveld/codereview.chromium.org/2157853002/1", "master:tryserver.chromium.perf", "user_agent:recipe" ], "updated_ts": "1468768218843680", "url": "http://build.chromium.org/p/tryserver.chromium.perf/builders/win_perf_bisect_builder/builds/13842", "utcnow_ts": "1468768908929700" } }
,
Jul 20 2016
,
Jul 20 2016
,
Jul 20 2016
,
Oct 21 2016
This doesn't seem like a problem anymore, right?
,
Oct 21 2016
,
Oct 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/8b65c34f07490a0ddebdf96d0e755821c876847b commit 8b65c34f07490a0ddebdf96d0e755821c876847b Author: robertocn <robertocn@chromium.org> Date: Fri Oct 21 22:21:10 2016 Make bisect not break when buildbucket.get fails. There's fixes for both staging and production branches, but only staging has full test coverage (due to the refactor, which allows this). R=prasadv@chromium.org,dtu@chromium.org BUG= 629896 Review-Url: https://chromiumcodereview.appspot.com/2441143002 [modify] https://crrev.com/8b65c34f07490a0ddebdf96d0e755821c876847b/scripts/slave/recipe_modules/auto_bisect/revision_state.py [add] https://crrev.com/8b65c34f07490a0ddebdf96d0e755821c876847b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_buildbucket_get.json [modify] https://crrev.com/8b65c34f07490a0ddebdf96d0e755821c876847b/scripts/slave/recipe_modules/auto_bisect_staging/example.py [modify] https://crrev.com/8b65c34f07490a0ddebdf96d0e755821c876847b/scripts/slave/recipe_modules/auto_bisect_staging/revision_state.py [modify] https://crrev.com/8b65c34f07490a0ddebdf96d0e755821c876847b/scripts/slave/recipe_modules/auto_bisect_staging/test_api.py
,
Nov 17 2016
,
Feb 3 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sullivan@chromium.org
, Jul 20 2016