New issue
Advanced search Search tips

Issue 629882 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

Autofill card should be on the bottom of the PaymentRequest UI

Project Member Reported by rouslan@chromium.org, Jul 20 2016

Issue description

^^^
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84204fda8113ffef6766812db30d6e11fee1269c

commit 84204fda8113ffef6766812db30d6e11fee1269c
Author: rouslan <rouslan@chromium.org>
Date: Fri Jul 22 17:04:59 2016

Autofill cards at the bottom of the PaymentRequest UI

This patch arranges the payment instruments in the following order:
> Non-autofill payment apps
> Complete credit cards from Autofill.
> Incomplete credit card from Autofill (need editing before sending to
  the merchant).

BUG= 629882 

Review-Url: https://codereview.chromium.org/2165163002
Cr-Commit-Position: refs/heads/master@{#407179}

[modify] https://crrev.com/84204fda8113ffef6766812db30d6e11fee1269c/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/84204fda8113ffef6766812db30d6e11fee1269c/chrome/android/java_sources.gni
[add] https://crrev.com/84204fda8113ffef6766812db30d6e11fee1269c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppAndCardsTest.java
[modify] https://crrev.com/84204fda8113ffef6766812db30d6e11fee1269c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java
[modify] https://crrev.com/84204fda8113ffef6766812db30d6e11fee1269c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
[add] https://crrev.com/84204fda8113ffef6766812db30d6e11fee1269c/chrome/test/data/android/payments/bobpay_and_cards.js
[add] https://crrev.com/84204fda8113ffef6766812db30d6e11fee1269c/chrome/test/data/android/payments/payment_request_bobpay_and_cards_test.html

Labels: Merge-Request-53 M-53

Comment 3 by dimu@chromium.org, Jul 25 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 25 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a2f251483de04cbbfa2c62cec936656ff551caf

commit 4a2f251483de04cbbfa2c62cec936656ff551caf
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Mon Jul 25 01:10:25 2016

[Merge M-53] Autofill cards at the bottom of the PaymentRequest UI

This patch arranges the payment instruments in the following order:
> Non-autofill payment apps
> Complete credit cards from Autofill.
> Incomplete credit card from Autofill (need editing before sending to
  the merchant).

BUG= 629882 

Review-Url: https://codereview.chromium.org/2165163002
Cr-Commit-Position: refs/heads/master@{#407179}
(cherry picked from commit 84204fda8113ffef6766812db30d6e11fee1269c)

Review URL: https://codereview.chromium.org/2179703002 .

Cr-Commit-Position: refs/branch-heads/2785@{#323}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/4a2f251483de04cbbfa2c62cec936656ff551caf/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/4a2f251483de04cbbfa2c62cec936656ff551caf/chrome/android/java_sources.gni
[add] https://crrev.com/4a2f251483de04cbbfa2c62cec936656ff551caf/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppAndCardsTest.java
[modify] https://crrev.com/4a2f251483de04cbbfa2c62cec936656ff551caf/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java
[modify] https://crrev.com/4a2f251483de04cbbfa2c62cec936656ff551caf/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
[add] https://crrev.com/4a2f251483de04cbbfa2c62cec936656ff551caf/chrome/test/data/android/payments/bobpay_and_cards.js
[add] https://crrev.com/4a2f251483de04cbbfa2c62cec936656ff551caf/chrome/test/data/android/payments/payment_request_bobpay_and_cards_test.html

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in 53.0.2785.34
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment