New issue
Advanced search Search tips

Issue 629878 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Change ChooserController::Observer to be ChooserController::View

Project Member Reported by juncai@chromium.org, Jul 20 2016

Issue description

Based on the comment from:
https://codereview.chromium.org/2155743002/

It would be better to change ChooserController::Observer to be ChooserController::View since it better reflects its purpose.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/796733012dd7fe6edf6e5360087447f3a2d187e1

commit 796733012dd7fe6edf6e5360087447f3a2d187e1
Author: juncai <juncai@chromium.org>
Date: Wed Jul 20 22:30:46 2016

Change ChooserController::Observer to ChooserController::View

Based on the comment from:
https://codereview.chromium.org/2155743002/

This CL changes ChooserController::Observer to ChooserController::View
to better reflect its purpose, since ChooserController needs to update
its view when necessary.

BUG= 629878 

Review-Url: https://codereview.chromium.org/2163683005
Cr-Commit-Position: refs/heads/master@{#406696}

[modify] https://crrev.com/796733012dd7fe6edf6e5360087447f3a2d187e1/chrome/browser/chooser_controller/chooser_controller.h
[modify] https://crrev.com/796733012dd7fe6edf6e5360087447f3a2d187e1/chrome/browser/chooser_controller/mock_chooser_controller.cc
[modify] https://crrev.com/796733012dd7fe6edf6e5360087447f3a2d187e1/chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc
[modify] https://crrev.com/796733012dd7fe6edf6e5360087447f3a2d187e1/chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm
[modify] https://crrev.com/796733012dd7fe6edf6e5360087447f3a2d187e1/chrome/browser/ui/views/chooser_content_view.cc
[modify] https://crrev.com/796733012dd7fe6edf6e5360087447f3a2d187e1/chrome/browser/ui/views/chooser_content_view.h
[modify] https://crrev.com/796733012dd7fe6edf6e5360087447f3a2d187e1/chrome/browser/usb/usb_chooser_controller.cc

Comment 2 by juncai@chromium.org, Jul 25 2016

Status: Fixed (was: Started)

Sign in to add a comment