New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629872 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug



Sign in to add a comment

Invalid board being passed to hqe_completion_count

Reported by jrbarnette@chromium.org, Jul 20 2016

Issue description

Looking at this URL:
    http://shortn/_BgvWUMu2nH

You see that the reporting of the hqe_completion_count
metric on cautotest stopped dead some time last night.

Looking in the scheduler logs on cautotest, you find
complaints like this:
    MonitoringInvalidFieldTypeError: Metric "chromeos/autotest/scheduler/hqe_completion_count" was given field "board" with invalid value "None" (<type 'NoneType'>).

Host objects with no 'board' setting have shown up in
special tasks, too.

I'm not quite sure of what's causing this, but we need to
go fiddle with this so that we get better data.

 
Components: Infra>Client>ChromeOS
Labels: -Pri-3 Pri-1
Status: Available (was: Unconfirmed)
Labels: -Pri-1 Pri-0
Owner: jrbarnette@chromium.org
We should fix the exception asap, by adding a str(...) around the offending code. This exception can cause the entire process to not send data to monarch.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3aa7e12f633964fd63a4e5f7eb4794b2380f2e4a

commit 3aa7e12f633964fd63a4e5f7eb4794b2380f2e4a
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Wed Jul 20 19:32:38 2016

[autotest] Stop sending `None` for board in HQE completion metric.

It's possible for a host object to have a 'board' setting of `None`.
The root cause of that behavior isn't known.  Until then, this change
changes the value reported from `None` to an empty string.

BUG= chromium:629872 
TEST=None

Change-Id: I7b61f2d2e9e71f0287b861042d67951fd53a6df0
Reviewed-on: https://chromium-review.googlesource.com/361992
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[modify] https://crrev.com/3aa7e12f633964fd63a4e5f7eb4794b2380f2e4a/scheduler/scheduler_models.py

Status: Fixed (was: Available)
Labels: VerifyIn-54
Status: Verified (was: Fixed)
bulk verified

Sign in to add a comment