New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629868 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

add new host failed

Project Member Reported by ntang@google.com, Jul 20 2016

Issue description

Just tried with ToT update on my moblab, add host from the UI seems broken. The page returns Internal Server Error 500 error.

The apache error logs shows:

[Thu Jul 21 00:29:16.453643 2016] [:error] [pid 22252] [remote 10.50.157.5:0] mod_wsgi (pid=22252): Exception occurred processing WSGI script '/usr/local/autotest/frontend/frontend.wsgi'.
[Thu Jul 21 00:29:16.453709 2016] [:error] [pid 22252] [remote 10.50.157.5:0] Traceback (most recent call last):
[Thu Jul 21 00:29:16.453762 2016] [:error] [pid 22252] [remote 10.50.157.5:0]   File "/usr/local/autotest/frontend/frontend.wsgi", line 23, in application
[Thu Jul 21 00:29:16.453844 2016] [:error] [pid 22252] [remote 10.50.157.5:0]     return _application(environ, start_response)
[Thu Jul 21 00:29:16.453861 2016] [:error] [pid 22252] [remote 10.50.157.5:0]   File "/usr/lib64/python2.7/site-packages/django/core/handlers/wsgi.py", line 255, in __call__
[Thu Jul 21 00:29:16.453962 2016] [:error] [pid 22252] [remote 10.50.157.5:0]     response = self.get_response(request)
[Thu Jul 21 00:29:16.453993 2016] [:error] [pid 22252] [remote 10.50.157.5:0]   File "/usr/lib64/python2.7/site-packages/django/core/handlers/base.py", line 178, in get_response
[Thu Jul 21 00:29:16.454017 2016] [:error] [pid 22252] [remote 10.50.157.5:0]     response = self.handle_uncaught_exception(request, resolver, sys.exc_info())
[Thu Jul 21 00:29:16.454034 2016] [:error] [pid 22252] [remote 10.50.157.5:0]   File "/usr/lib64/python2.7/site-packages/django/core/handlers/base.py", line 224, in handle_uncaught_exception
[Thu Jul 21 00:29:16.454060 2016] [:error] [pid 22252] [remote 10.50.157.5:0]     return callback(request, **param_dict)
[Thu Jul 21 00:29:16.454076 2016] [:error] [pid 22252] [remote 10.50.157.5:0]   File "/usr/local/autotest/frontend/afe/views.py", line 57, in handler500
[Thu Jul 21 00:29:16.454146 2016] [:error] [pid 22252] [remote 10.50.157.5:0]     t = loader.get_template('500.html')
[Thu Jul 21 00:29:16.454164 2016] [:error] [pid 22252] [remote 10.50.157.5:0]   File "/usr/lib64/python2.7/site-packages/django/template/loader.py", line 146, in get_template
[Thu Jul 21 00:29:16.454442 2016] [:error] [pid 22252] [remote 10.50.157.5:0]     template, origin = find_template(template_name)
[Thu Jul 21 00:29:16.454473 2016] [:error] [pid 22252] [remote 10.50.157.5:0]   File "/usr/lib64/python2.7/site-packages/django/template/loader.py", line 139, in find_template
[Thu Jul 21 00:29:16.454492 2016] [:error] [pid 22252] [remote 10.50.157.5:0]     raise TemplateDoesNotExist(name)
[Thu Jul 21 00:29:16.454513 2016] [:error] [pid 22252] [remote 10.50.157.5:0] TemplateDoesNotExist: 500.html


 

Comment 1 by sbasi@chromium.org, Jul 20 2016

Cc: jgiorgi@chromium.org
+Justin who was modifying the host add command line scripts.
Is that the entire traceback (it doesn't seem to reference any code related to adding a host)? Could you provide reproduction steps?

Comment 3 by ntang@google.com, Jul 20 2016

There is no other trace stack in the /var/log/apache2/error.log. I just cros flash the moblab device with ToT local build. Then I could not add host via the admin Web UI.

Comment 4 by sbasi@chromium.org, Jul 20 2016

I get the same error. That traceback is likely unrelated.

Comment 5 by sbasi@chromium.org, Jul 20 2016

Reproduction steps:

Go to moblab UI
Click on admin interface
Hosts -> add
Put in IP
Click Save
Owner: jgiorgi@chromium.org
Status: Started (was: Untriaged)
Investigating now.
Project Member

Comment 7 by sheriffbot@chromium.org, Jul 21 2016

Labels: Hotlist-Google
Status: Fixed (was: Started)
CL up that should correct the issue https://chromium-review.googlesource.com/#/c/362095/

Comment 9 by sbasi@chromium.org, Jul 21 2016

Cc: krk@chromium.org
Status: Assigned (was: Fixed)
Not fixed, the breakage landed in R53, you need to merge it back there once it lands in ToT.
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/971b324350a9746a524c498464db0252e02b7d45

commit 971b324350a9746a524c498464db0252e02b7d45
Author: Justin Giorgi <jgiorgi@google.com>
Date: Wed Jul 20 22:44:21 2016

[autotest] Fixed 500 status when adding hosts.

Corrected variable name in afe/admin. Corrected redirect in urls_common.

BUG= chromium:629868 
TEST=Verified locally and on moblab.

Change-Id: Ied07656af56a2922ab7e208e357635ac1e352a31
Reviewed-on: https://chromium-review.googlesource.com/362095
Commit-Ready: Justin Giorgi <jgiorgi@google.com>
Tested-by: Justin Giorgi <jgiorgi@google.com>
Reviewed-by: Justin Giorgi <jgiorgi@google.com>

[modify] https://crrev.com/971b324350a9746a524c498464db0252e02b7d45/frontend/urls_common.py
[modify] https://crrev.com/971b324350a9746a524c498464db0252e02b7d45/frontend/afe/admin.py

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 22 2016

Labels: merge-merged-release-R53-8530.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f2108a532265c300e0311dda2057a9ff0ff6fe60

commit f2108a532265c300e0311dda2057a9ff0ff6fe60
Author: Justin Giorgi <jgiorgi@google.com>
Date: Wed Jul 20 22:44:21 2016

[autotest] Fixed 500 status when adding hosts.

Corrected variable name in afe/admin. Corrected redirect in urls_common.

BUG= chromium:629868 
TEST=Verified locally and on moblab.

Change-Id: Ied07656af56a2922ab7e208e357635ac1e352a31
Reviewed-on: https://chromium-review.googlesource.com/362095
Commit-Ready: Justin Giorgi <jgiorgi@google.com>
Tested-by: Justin Giorgi <jgiorgi@google.com>
Reviewed-by: Justin Giorgi <jgiorgi@google.com>
(cherry picked from commit 971b324350a9746a524c498464db0252e02b7d45)
Reviewed-on: https://chromium-review.googlesource.com/362418
Trybot-Ready: Justin Giorgi <jgiorgi@google.com>
Reviewed-by: Simran Basi <sbasi@chromium.org>

[modify] https://crrev.com/f2108a532265c300e0311dda2057a9ff0ff6fe60/frontend/urls_common.py
[modify] https://crrev.com/f2108a532265c300e0311dda2057a9ff0ff6fe60/frontend/afe/admin.py

Status: Fixed (was: Assigned)
Fixed in ToT and release-R53-8530.B

Sign in to add a comment