New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629867 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocked on:
issue 630616



Sign in to add a comment

Get EarlGrey tests running with gn

Project Member Reported by sdefresne@chromium.org, Jul 20 2016

Issue description

Umbrella bug
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/d790216df4557910f8acc88b1f2be261c9805256

commit d790216df4557910f8acc88b1f2be261c9805256
Author: sdefresne <sdefresne@google.com>
Date: Thu Jul 21 15:48:35 2016

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4eba1aaa77f9e89b2b1cdf117a7e6fd8175436e4

commit 4eba1aaa77f9e89b2b1cdf117a7e6fd8175436e4
Author: sdefresne <sdefresne@chromium.org>
Date: Fri Jul 22 07:45:34 2016

Query sdk-platform-path in build/config/mac/sdk_info.py.

The XCTest support (used for EarlGrey tests) requires linking against
XCTest.framework whose location is relative to sdk-platform-path, so
propagate via ios_sdk_platform_path variable in gn.

BUG= 629867 

Review-Url: https://codereview.chromium.org/2168873003
Cr-Commit-Position: refs/heads/master@{#407093}

[modify] https://crrev.com/4eba1aaa77f9e89b2b1cdf117a7e6fd8175436e4/build/config/ios/ios_sdk.gni
[modify] https://crrev.com/4eba1aaa77f9e89b2b1cdf117a7e6fd8175436e4/build/config/mac/sdk_info.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd0360b2ab164da9e527e32f6d602b9e22f21b06

commit dd0360b2ab164da9e527e32f6d602b9e22f21b06
Author: sdefresne <sdefresne@chromium.org>
Date: Fri Jul 22 07:54:12 2016

Keep ios_app_bundle final executable target name unchanged in fat builds.

Keep the name of the target generating the executable in ios_app_bundle
template the same whether the final binary is a fat or thin binary.

BUG= 629867 

Review-Url: https://codereview.chromium.org/2167933003
Cr-Commit-Position: refs/heads/master@{#407095}

[modify] https://crrev.com/dd0360b2ab164da9e527e32f6d602b9e22f21b06/build/config/ios/rules.gni

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/047490e7bb0d5c4ef2862a7059931fdec4e69ce9

commit 047490e7bb0d5c4ef2862a7059931fdec4e69ce9
Author: sdefresne <sdefresne@chromium.org>
Date: Fri Jul 22 08:49:34 2016

Add bundle_deps to ios_{app,framework}_bundle templates.

Allow to specify dependencies that are only used by the create_bundle
target when using ios_app_bundle or ios_framework_bundle templates to
increase parallelism.

BUG= 629867 

Review-Url: https://codereview.chromium.org/2169973002
Cr-Commit-Position: refs/heads/master@{#407102}

[modify] https://crrev.com/047490e7bb0d5c4ef2862a7059931fdec4e69ce9/build/config/ios/rules.gni
[modify] https://crrev.com/047490e7bb0d5c4ef2862a7059931fdec4e69ce9/build/config/mac/base_rules.gni
[modify] https://crrev.com/047490e7bb0d5c4ef2862a7059931fdec4e69ce9/components/cronet/ios/BUILD.gn
[modify] https://crrev.com/047490e7bb0d5c4ef2862a7059931fdec4e69ce9/testing/test.gni

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/effdadd7485ae1bf2361c8e3762761328fe1d581

commit effdadd7485ae1bf2361c8e3762761328fe1d581
Author: sdefresne <sdefresne@chromium.org>
Date: Fri Jul 22 11:18:57 2016

Add ${target}+bundle to ios_framework_bundle template.

Usually iOS framework bundle will be included in an application
so have them define a ${target}+bundle target that can be used
to depend and cause the copy into the application bundle.

BUG= 629867 

Review-Url: https://codereview.chromium.org/2172733003
Cr-Commit-Position: refs/heads/master@{#407129}

[modify] https://crrev.com/effdadd7485ae1bf2361c8e3762761328fe1d581/build/config/ios/rules.gni

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 22 2016

Comment 8 by baxley@chromium.org, Jul 22 2016

Blockedon: 630616
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdf365d050f4d1a86c42818b3e1f760eedfc4315

commit cdf365d050f4d1a86c42818b3e1f760eedfc4315
Author: sdefresne <sdefresne@chromium.org>
Date: Fri Jul 22 14:53:48 2016

Convert ios_web_shell_test to GN.

BUG= 629867 

Review-Url: https://codereview.chromium.org/2173493002
Cr-Commit-Position: refs/heads/master@{#407159}

[modify] https://crrev.com/cdf365d050f4d1a86c42818b3e1f760eedfc4315/build/config/ios/BUILD.gn
[add] https://crrev.com/cdf365d050f4d1a86c42818b3e1f760eedfc4315/build/config/ios/Host-Info.plist
[add] https://crrev.com/cdf365d050f4d1a86c42818b3e1f760eedfc4315/build/config/ios/Module-Info.plist
[modify] https://crrev.com/cdf365d050f4d1a86c42818b3e1f760eedfc4315/build/config/ios/codesign.py
[modify] https://crrev.com/cdf365d050f4d1a86c42818b3e1f760eedfc4315/build/config/ios/rules.gni
[add] https://crrev.com/cdf365d050f4d1a86c42818b3e1f760eedfc4315/build/config/ios/xctest_shell.mm
[modify] https://crrev.com/cdf365d050f4d1a86c42818b3e1f760eedfc4315/build/config/mac/base_rules.gni
[modify] https://crrev.com/cdf365d050f4d1a86c42818b3e1f760eedfc4315/components/cronet/ios/BUILD.gn
[modify] https://crrev.com/cdf365d050f4d1a86c42818b3e1f760eedfc4315/ios/BUILD.gn
[modify] https://crrev.com/cdf365d050f4d1a86c42818b3e1f760eedfc4315/ios/third_party/earl_grey/BUILD.gn
[add] https://crrev.com/cdf365d050f4d1a86c42818b3e1f760eedfc4315/ios/third_party/earl_grey/ios_eg_test.gni
[modify] https://crrev.com/cdf365d050f4d1a86c42818b3e1f760eedfc4315/ios/web/ios_web_shell_tests.gyp
[modify] https://crrev.com/cdf365d050f4d1a86c42818b3e1f760eedfc4315/ios/web/shell/BUILD.gn
[add] https://crrev.com/cdf365d050f4d1a86c42818b3e1f760eedfc4315/ios/web/shell/test/BUILD.gn
[modify] https://crrev.com/cdf365d050f4d1a86c42818b3e1f760eedfc4315/ios/web/shell/test/web_shell_navigation_egtest.mm

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8919c23569d0efd909965720ce68b895120ed46

commit c8919c23569d0efd909965720ce68b895120ed46
Author: sdefresne <sdefresne@chromium.org>
Date: Tue Jul 26 13:00:23 2016

Allow configuration of info_plist_{,target} in ios_xctest_test.

Some XCTests needs a different Info.plist file, so let them
configure it either via the info_plist or info_plist_target
parameters and only use the default value if neither is set.

BUG= 629867 

Review-Url: https://codereview.chromium.org/2183003002
Cr-Commit-Position: refs/heads/master@{#407778}

[modify] https://crrev.com/c8919c23569d0efd909965720ce68b895120ed46/build/config/ios/rules.gni

Status: Fixed (was: Started)
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cb24daa370c6c7156afbf17d00aa8af7d021c96

commit 5cb24daa370c6c7156afbf17d00aa8af7d021c96
Author: sdefresne <sdefresne@chromium.org>
Date: Tue Aug 09 06:03:13 2016

Add a target //build/config/ios:xctest.

Introduce a group target //build/config/ios:xctest to add a
config on //build/config/ios:xctest_config (it is easier to
use deps than configs).

BUG= 629867 

Review-Url: https://codereview.chromium.org/2220823002
Cr-Commit-Position: refs/heads/master@{#410592}

[modify] https://crrev.com/5cb24daa370c6c7156afbf17d00aa8af7d021c96/build/config/ios/BUILD.gn

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/773eadb91cc6a1aa5006e2b87771d4de69b7ac01

commit 773eadb91cc6a1aa5006e2b87771d4de69b7ac01
Author: sdefresne <sdefresne@chromium.org>
Date: Tue Aug 09 22:57:58 2016

[iOS] Fix EarlGrey public configurations.

The dependency of //ios/third_party/earl_grey on XCTest is not
exposed in public header, so change it to private config and
instead add the missing dependency to the target needing it.

BUG= 629867 

Review-Url: https://codereview.chromium.org/2220243002
Cr-Commit-Position: refs/heads/master@{#410861}

[modify] https://crrev.com/773eadb91cc6a1aa5006e2b87771d4de69b7ac01/ios/third_party/earl_grey/BUILD.gn
[modify] https://crrev.com/773eadb91cc6a1aa5006e2b87771d4de69b7ac01/ios/web/shell/test/BUILD.gn

Sign in to add a comment