New issue
Advanced search Search tips

Issue 629855 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

crosfw needs some attention

Project Member Reported by sjg@chromium.org, Jul 20 2016

Issue description

This script is pretty out of date now.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/eb0c5358b2f3b6ad3264caeba3a87806833de32f

commit eb0c5358b2f3b6ad3264caeba3a87806833de32f
Author: Simon Glass <sjg@chromium.org>
Date: Wed Jul 20 15:29:34 2016

crosfw: Handle the new boards.cfg format

This file is now auto-generated, and has a slightly updated format. Use
the presence of the MAINTAINERS file to determine which format is in use,
since that file was added when U-Boot moved to Kbuild.

Signed-off-by: Simon Glass <sjg@chromium.org>
BUG= chromium:629855 
TEST='crosfw -b sandbox -w' works correctly on post-2013 U-Boot
Change-Id: Ifcbc54eaf12b5976eab99bcb1cec32dd0bfaab51
Reviewed-on: https://chromium-review.googlesource.com/361889
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/eb0c5358b2f3b6ad3264caeba3a87806833de32f/scripts/crosfw.py

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/ef7e4378c78f032e6746cf65c725f0a1c69d5824

commit ef7e4378c78f032e6746cf65c725f0a1c69d5824
Author: Simon Glass <sjg@chromium.org>
Date: Wed Jul 20 15:38:47 2016

crosfw: Handling incremental build with Kbuild

Change to using autoconf.mk to detect an existing build. This works with
Kbuild and also pre-Kbuild.

Signed-off-by: Simon Glass <sjg@chromium.org>
BUG= chromium:629855 
TEST=run 'crosfw -b sandbox_spl -wi' twice; see that the second time does not
print a warning 'No build found for sandbox_spl - dropping -i'
Change-Id: Id0a0429d3e13356371ea7c4212e943c89363c911
Reviewed-on: https://chromium-review.googlesource.com/364870
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/ef7e4378c78f032e6746cf65c725f0a1c69d5824/scripts/crosfw.py

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/234e5f326cc463cf149545c51c116119ba299076

commit 234e5f326cc463cf149545c51c116119ba299076
Author: Simon Glass <sjg@chromium.org>
Date: Wed Jul 20 15:11:59 2016

crosfw: Use a verbose build with -v3 or greater

Provide a way to increase the verbosity of the build so that all the build
commands are displayed.

Signed-off-by: Simon Glass <sjg@chromium.org>
BUG= chromium:629855 
TEST=crosfw -b sandbox -v3; see that the full build log is shown

Change-Id: I8a6c52bf6eeb6fcf435739f34d81558c86e4ac80
Reviewed-on: https://chromium-review.googlesource.com/365560
Tested-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/234e5f326cc463cf149545c51c116119ba299076/scripts/crosfw.py

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f67f93e2592355a9e8fc2fafe1f2ff2695035ed4

commit f67f93e2592355a9e8fc2fafe1f2ff2695035ed4
Author: Simon Glass <sjg@chromium.org>
Date: Fri Aug 05 02:29:51 2016

crosfw: Use a default of 'all' for the 'target' command line option

This is not really needed as the board target is specified with the -b flag.
But keep it around with a useful default for now.

Signed-off-by: Simon Glass <sjg@chromium.org>
BUG= chromium:629855 
TEST=crosfw -b odroid-c2; see that it now builds correctly

Change-Id: Ia30817d2a76557533b2baf6e79bb48b121342090
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/366435
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/f67f93e2592355a9e8fc2fafe1f2ff2695035ed4/scripts/crosfw.py

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/c1a323a85044d1fd34e11870e9365007a057b6c7

commit c1a323a85044d1fd34e11870e9365007a057b6c7
Author: Simon Glass <sjg@chromium.org>
Date: Fri Aug 05 02:29:51 2016

crosfw: Add arm64 support

Allow building of arm64 targets. There are quite a few in U-Boot now.

Signed-off-by: Simon Glass <sjg@chromium.org>
BUG= chromium:629855 
TEST=crosfw -b odroid-c2; see that it builds correctly

Change-Id: I6c792ce9a657308bcd7cd9418d752e18c14639cb
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/366436
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/c1a323a85044d1fd34e11870e9365007a057b6c7/scripts/crosfw.py

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/c0a4d0e1fcae28223517bce4847ba9a85729d1c6

commit c0a4d0e1fcae28223517bce4847ba9a85729d1c6
Author: Simon Glass <sjg@chromium.org>
Date: Wed Aug 10 14:18:27 2016

crosfw: Build u-boot.rom on x86

On x86 platforms the final u-boot.rom is not automatically built, since it
normally requires pre-built binaries. However, with crosfw we assume that
these are available, and we want an error if something is missing.

Pass BUILD_ROM to the U-Boot build system to enable this behaviour.

Signed-off-by: Simon Glass <sjg@chromium.org>
BUG= chromium:629855 
TEST=crosfw -b chromebook_samus -w; see that it builds u-boot.rom

Change-Id: I9ab65679b7205d5314df727c7fa774e4e9ae5dce
Reviewed-on: https://chromium-review.googlesource.com/367534
Commit-Ready: Dan Shi <dshi@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/c0a4d0e1fcae28223517bce4847ba9a85729d1c6/scripts/crosfw.py

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/d0557f0786d3ed02266186bce49e6a3ebce502d0

commit d0557f0786d3ed02266186bce49e6a3ebce502d0
Author: Simon Glass <sjg@chromium.org>
Date: Tue Nov 15 15:51:34 2016

crosfw: Explain which toolchain is missing

When a toolchain is missing, show the architecture type needed.

Signed-off-by: Simon Glass <sjg@chromium.org>
BUG= chromium:629855 
TEST=crosfw -b chromebook_samus -w; see that it builds u-boot.rom

Change-Id: Ib1c1f5f3cffac7caf39e683b0d6886121e37ce1c
Reviewed-on: https://chromium-review.googlesource.com/411471
Commit-Ready: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/d0557f0786d3ed02266186bce49e6a3ebce502d0/scripts/crosfw.py

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/5a5a36ec4fb99219951c0886bf0830d7187513a4

commit 5a5a36ec4fb99219951c0886bf0830d7187513a4
Author: Simon Glass <sjg@chromium.org>
Date: Tue Nov 15 15:51:34 2016

crosfw: Select board by target name only

At present we search the boards.cfg file to find the architecture for a
board to be built. But the supplied board can match any field in the board
line. In the case of Raspberry Pi ('rpi') this can match an aarch64 target
with rpi_3, or an arm target with rpi. Fix it to distinguish these
correctly.

Signed-off-by: Simon Glass <sjg@chromium.org>
BUG= chromium:629855 
TEST=crosfw -b rpi -w; see that it builds with the correct (arm) toolchain

Change-Id: Idf1a3f475851c38d76fd0b9b55a0c30d8867be24
Reviewed-on: https://chromium-review.googlesource.com/411472
Commit-Ready: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/5a5a36ec4fb99219951c0886bf0830d7187513a4/scripts/crosfw.py

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/4e28d11ffa44d38fc0002d2782bd8efa12642a59

commit 4e28d11ffa44d38fc0002d2782bd8efa12642a59
Author: Simon Glass <sjg@chromium.org>
Date: Wed Nov 16 20:52:48 2016

crosfw: Use _defconfig target for new U-Boot

U-Boot has moved to using a <board>_defconfig target for configuration.
Use this when we detect a newer U-Boot (one that auto-generates the
boards.cfg file).

Signed-off-by: Simon Glass <sjg@chromium.org>
BUG= chromium:629855 
TEST=on new tree: crosfw -b rpi -w; see that it still configures and
builds correctly
Change-Id: Ia6899226095bde04a3de873f86b89e732573791b
Reviewed-on: https://chromium-review.googlesource.com/412052
Commit-Ready: Simon Glass <sjg@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/4e28d11ffa44d38fc0002d2782bd8efa12642a59/scripts/crosfw.py

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/c2fe94c85c7fd138e392670b7bcf856d607e7d61

commit c2fe94c85c7fd138e392670b7bcf856d607e7d61
Author: Simon Glass <sjg@chromium.org>
Date: Wed Nov 16 20:56:24 2016

crosfw: Return an exit code when we get a build error

Sometimes configuring or building the board will fail. We should use the
correct exit code in this case. For configuration failure it helps to print
out the error too. Adjust the code accordingly.

BUG= chromium:629855 
TEST=change 'defconfig' to a bad target and build. See that error
information is printed. Also see that an exit code 2 is returned to the
shell.

Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: Icfb2fac1d7c86641361927af43d071f4d664c9f8
Reviewed-on: https://chromium-review.googlesource.com/412053
Commit-Ready: Simon Glass <sjg@google.com>
Tested-by: Simon Glass <sjg@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/c2fe94c85c7fd138e392670b7bcf856d607e7d61/scripts/crosfw.py

Comment 11 by sjg@chromium.org, Nov 28 2016

Status: Fixed (was: Assigned)
I think this is good enough now, so I'm closing this.
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/08b33086ec16e04e30f61d7ef502fa47d6c522db

commit 08b33086ec16e04e30f61d7ef502fa47d6c522db
Author: Simon Glass <sjg@chromium.org>
Date: Mon Jan 23 19:16:40 2017

crosfw: Output errors to stderr instead of stdout

IDEs expect errors to be sent to stderr. For example, Kate will not taken
any notice of errors and warnings sent to stdout.

Update the script to use stderr for build output.

BUG= chromium:629855 
TEST=add a build error; crosfw -b sandbox -w
See that Kate shows line/file info in its errors/warnings view

Change-Id: I6255f32544d0f0fc81fb4822837d6cbd52d907e6
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/431296
Reviewed-by: Chris Ching <chingcodes@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/08b33086ec16e04e30f61d7ef502fa47d6c522db/scripts/crosfw.py

Sign in to add a comment