New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629854 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

ARC custom notification has wrong size

Project Member Reported by xiy...@chromium.org, Jul 20 2016

Issue description

ARC custom notification could show up with wrong size and appear clipped.

Details in http://b/30227926
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 21 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e55d9d3bf6082a636271efda6ece4cd04dc94109

commit e55d9d3bf6082a636271efda6ece4cd04dc94109
Author: xiyuan <xiyuan@chromium.org>
Date: Thu Jul 21 14:54:38 2016

exo: Add notification surface to manager after commit

Add notification surface to manager after commit so that it has
the correct content size when creating the hosting view.

BUG= 629854 

Review-Url: https://codereview.chromium.org/2169513003
Cr-Commit-Position: refs/heads/master@{#406851}

[modify] https://crrev.com/e55d9d3bf6082a636271efda6ece4cd04dc94109/components/exo/notification_surface.cc
[modify] https://crrev.com/e55d9d3bf6082a636271efda6ece4cd04dc94109/components/exo/notification_surface.h

Comment 3 by xiy...@chromium.org, Jul 25 2016

Labels: -M-54 -MovedFrom-53 Merge-Request-53 M-53

Comment 4 by dimu@chromium.org, Jul 25 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 25 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/712028a78341a17acecdbf832eccfd30cab6a0f3

commit 712028a78341a17acecdbf832eccfd30cab6a0f3
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Mon Jul 25 16:09:45 2016

Merge "exo: Add notification surface to manager after commit"

> Add notification surface to manager after commit so that it has
> the correct content size when creating the hosting view.
>
> BUG= 629854 
>
> Review-Url: https://codereview.chromium.org/2169513003
> Cr-Commit-Position: refs/heads/master@{#406851}
> (cherry picked from commit e55d9d3bf6082a636271efda6ece4cd04dc94109)

Review URL: https://codereview.chromium.org/2177973002 .

Cr-Commit-Position: refs/branch-heads/2785@{#328}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/712028a78341a17acecdbf832eccfd30cab6a0f3/components/exo/notification_surface.cc
[modify] https://crrev.com/712028a78341a17acecdbf832eccfd30cab6a0f3/components/exo/notification_surface.h

Comment 6 by xiy...@chromium.org, Jul 25 2016

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment