New issue
Advanced search Search tips

Issue 629844 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

SiteEngagement* tests failing on Qualcom devices

Reported by kra...@amazon.com, Jul 20 2016 
Version: Tip of master
OS: Android

What steps will reproduce the problem?
(On a Qualcom device)
(1) out/GN-Debug/bin/run_unit_tests -v

What is the expected output?
C  186.779s Main  ********************************************************************************
C  186.795s Main  [==========] 2167 tests ran.
C  186.795s Main  [  PASSED  ] 2167 tests.
C  186.795s Main  ********************************************************************************

What happens instead?
C  295.953s Main  ********************************************************************************
C  295.955s Main  [FAIL] SiteEngagementScoreTest.ProportionalDecay:
C  295.955s Main  [ RUN  ] SiteEngagementScoreTest.ProportionalDecay
C  295.955s Main  ../../chrome/browser/engagement/site_engagement_score_unittest.cc:446: Failure
C  295.955s Main  Value of: score_.GetScore()
C  295.955s MainActual: 0.99999999999999911
C  295.955s Main  Expected: 1.0
C  295.956s Main  Which is: 1
C  295.956s Main  [  FAILED  ] SiteEngagementScoreTest.ProportionalDecay (0 ms)
C  295.956s Main  [FAIL] SiteEngagementServiceTest.CleanupEngagementScoresProportional:
C  295.956s Main  [ RUN  ] SiteEngagementServiceTest.CleanupEngagementScoresProportional
C  295.956s Main  ../../chrome/browser/engagement/site_engagement_service_unittest.cc:959: Failure
C  295.956s Main  Value of: service->GetScore(url1)
C  295.956s MainActual: 0.5
C  295.956s Main  Expected: 0.5
C  295.956s Main  ../../chrome/browser/engagement/site_engagement_service_unittest.cc:960: Failure
C  295.956s Main  Value of: service->GetScore(url2)
C  295.956s MainActual: 0.6
C  295.956s Main  Expected: 0.6
C  295.956s Main  ../../chrome/browser/engagement/site_engagement_service_unittest.cc:966: Failure
C  295.956s Main  Value of: service->GetScore(url2)
C  295.956s MainActual: 0.6
C  295.956s Main  Expected: 0.6
C  295.956s Main  [  FAILED  ] SiteEngagementServiceTest.CleanupEngagementScoresProportional (110 ms)
C  295.956s Main  [FAIL] SiteEngagementServiceTest.CleanupOriginsOnHistoryDeletion:
C  295.956s Main  [ RUN  ] SiteEngagementServiceTest.CleanupOriginsOnHistoryDeletion
C  295.956s Main  ../../chrome/browser/engagement/site_engagement_service_unittest.cc:1068: Failure
C  295.956s Main  Value of: engagement->GetScore(origin1)
C  295.956s MainActual: 3
C  295.956s Main  Expected: 3.0
C  295.956s Main  Which is: 3
C  295.956s Main  ../../chrome/browser/engagement/site_engagement_service_unittest.cc:1069: Failure
C  295.956s Main  Value of: engagement->GetScore(origin2)
C  295.956s MainActual: 5
C  295.956s Main  Expected: 5.0
C  295.956s Main  Which is: 5
C  295.957s Main  ../../chrome/browser/engagement/site_engagement_service_unittest.cc:1070: Failure
C  295.957s Main  Value of: engagement->GetScore(origin3)
C  295.957s MainActual: 5
C  295.957s Main  Expected: 5.0
C  295.957s Main  Which is: 5
C  295.957s Main  ../../chrome/browser/engagement/site_engagement_service_unittest.cc:1071: Failure
C  295.957s Main  Value of: engagement->GetScore(origin4)
C  295.957s MainActual: 5
C  295.957s Main  Expected: 5.0
C  295.957s Main  Which is: 5
C  295.957s Main  ../../chrome/browser/engagement/site_engagement_service_unittest.cc:1087: Failure
C  295.957s Main  Value of: engagement->GetScore(origin1)
C  295.957s MainActual: 2
C  295.957s Main  Expected: 2
C  295.958s Main  ../../chrome/browser/engagement/site_engagement_service_unittest.cc:1089: Failure
C  295.958s Main  Value of: engagement->GetScore(origin3)
C  295.958s MainActual: 5
C  295.958s Main  Expected: 5.0
C  295.958s Main  Which is: 5
C  295.958s Main  ../../chrome/browser/engagement/site_engagement_service_unittest.cc:1090: Failure
C  295.958s Main  Value of: engagement->GetScore(origin4)
C  295.958s MainActual: 2.5
C  295.959s Main  Expected: 2.5
C  295.959s Main  ../../chrome/browser/engagement/site_engagement_service_unittest.cc:1091: Failure
C  295.959s Main  Value of: engagement->GetTotalEngagementPoints()
C  295.959s MainActual: 9.5
C  295.959s Main  Expected: 9.5
C  295.959s Main  ../../chrome/browser/engagement/site_engagement_service_unittest.cc:1111: Failure
C  295.959s Main  Value of: engagement->GetScore(origin1)
C  295.959s MainActual: 1
C  295.959s Main  Expected: 1
C  295.964s Main  ../../chrome/browser/engagement/site_engagement_service_unittest.cc:1113: Failure
C  295.964s Main  Value of: engagement->GetScore(origin3)
C  295.964s MainActual: 5
C  295.964s Main  Expected: 5.0
C  295.964s Main  Which is: 5
C  295.964s Main  ../../chrome/browser/engagement/site_engagement_service_unittest.cc:1114: Failure
C  295.964s Main  Value of: engagement->GetScore(origin4)
C  295.964s MainActual: 2.5
C  295.964s Main  Expected: 2.5
C  295.964s Main  ../../chrome/browser/engagement/site_engagement_service_unittest.cc:1115: Failure
C  295.964s Main  Value of: engagement->GetTotalEngagementPoints()
C  295.964s MainActual: 8.5
C  295.964s Main  Expected: 8.5
C  295.964s Main  ../../chrome/browser/engagement/site_engagement_service_unittest.cc:1136: Failure
C  295.964s Main  Value of: engagement->GetScore(origin3)
C  295.964s MainActual: 5
C  295.964s Main  Expected: 5.0
C  295.964s Main  Which is: 5
C  295.964s Main  ../../chrome/browser/engagement/site_engagement_service_unittest.cc:1137: Failure
C  295.964s Main  Value of: engagement->GetScore(origin4)
C  295.964s MainActual: 2.5
C  295.964s Main  Expected: 2.5
C  295.964s Main  ../../chrome/browser/engagement/site_engagement_service_unittest.cc:1138: Failure
C  295.965s Main  Value of: engagement->GetTotalEngagementPoints()
C  295.965s MainActual: 7.5
C  295.965s Main  Expected: 7.5
C  295.965s Main  [  FAILED  ] SiteEngagementServiceTest.CleanupOriginsOnHistoryDeletion (234 ms)
C  295.965s Main  ********************************************************************************
C  295.965s Main  Summary
C  295.965s Main  ********************************************************************************
C  295.981s Main  [==========] 2167 tests ran.
C  295.981s Main  [  PASSED  ] 2164 tests.
C  295.981s Main  [  FAILED  ] 3 tests, listed below:
C  295.981s Main  [  FAILED  ] SiteEngagementScoreTest.ProportionalDecay
C  295.981s Main  [  FAILED  ] SiteEngagementServiceTest.CleanupEngagementScoresProportional
C  295.981s Main  [  FAILED  ] SiteEngagementServiceTest.CleanupOriginsOnHistoryDeletion
C  295.981s Main
C  295.981s Main  3 FAILED TESTS
C  295.981s Main  ********************************************************************************

Please use labels and text to provide additional information.
When looking at the numbers bit for bit, they often seem to be off by minuscule amounts.
Doesn't seem to have functional impact, but breaks those tests.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca9d8ac0a8735dacad863962c28a960c60747042

commit ca9d8ac0a8735dacad863962c28a960c60747042
Author: kraush <kraush@amazon.com>
Date: Thu Jul 21 06:25:52 2016

Allow rounding errors in Site Engagement tests

This change alters SiteEngagement tests to allow for
small rounding errors.
This will allow Qualcom chipsets to pass those tests, which
are often off by minimal values.

BUG= 629844 

Review-Url: https://codereview.chromium.org/2163233002
Cr-Commit-Position: refs/heads/master@{#406785}

[modify] https://crrev.com/ca9d8ac0a8735dacad863962c28a960c60747042/chrome/browser/engagement/site_engagement_score_unittest.cc
[modify] https://crrev.com/ca9d8ac0a8735dacad863962c28a960c60747042/chrome/browser/engagement/site_engagement_service_unittest.cc

Comment 3 by ssamanoori@chromium.org, Aug 5 2016

Components: Tests>Fails

Comment 4 by dominickn@chromium.org, Dec 5 2016

Status: Fixed (was: Untriaged)
I think this is fixed.
►

Sign in to add a comment