New issue
Advanced search Search tips

Issue 629842 link

Starred by 3 users
Status: Fixed
Owner:
ekaramad@chromium.org
Closed: Jul 2016
Cc:
creis@chromium.org
wfh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 578168


Sign in to add a comment

Initialize and clean up IME state in TextInputManager to avoid memory crashes/memory leak.

Project Member Reported by ekaramad@chromium.org, Jul 20 2016 
Some of the internal state in TextInputManager are not initialized or cleaned up in a Register or Unregister call. Since we assume registration based on existence of a key in the |text_input_state_map_| all other maps should be initialized/erased accordingly.

Comment 1 by ekaramad@chromium.org, Jul 20 2016

Status: Started (was: start)
There won't be crashes or leaks, but potentially more memory used if we keep adding frames and removing them from the page.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cfc03e1c2d8561641951e8843f4af4f52285703

commit 4cfc03e1c2d8561641951e8843f4af4f52285703
Author: ekaramad <ekaramad@chromium.org>
Date: Thu Jul 21 17:34:21 2016

[refactor] content::TextInputManager - Make some methods const and initialize/cleanup IME maps

This CL makes some getter methods in TextInputManager const. Also,
the CL will clean up and initialize maps at the time of unregistering
and registering with TextInputManager.

BUG= 629842 ,  578168 

Review-Url: https://codereview.chromium.org/2170463002
Cr-Commit-Position: refs/heads/master@{#406891}

[modify] https://crrev.com/4cfc03e1c2d8561641951e8843f4af4f52285703/content/browser/renderer_host/text_input_manager.cc
[modify] https://crrev.com/4cfc03e1c2d8561641951e8843f4af4f52285703/content/browser/renderer_host/text_input_manager.h

Comment 3 by ekaramad@chromium.org, Jul 26 2016

Status: Fixed (was: Started)
►

Sign in to add a comment