New issue
Advanced search Search tips

Issue 629826 link

Starred by 3 users
Status: Fixed
Owner:
f...@opera.com
Closed: Jul 2016
Cc:
vmp...@chromium.org
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 470608


Sign in to add a comment

All -webkit-clip-path url(...)s regarded as local

Project Member Reported by f...@opera.com, Jul 20 2016 
Even if a -webkit-clip-path url(...) references a non-local and/or non-existent element, the reference will resolve within the local document.

https://jsfiddle.net/m4e7ogo6/

Setting this to block on  issue 470608 , because without that fixed, some references that worked even in the face of a different base URL could fail if fixing this issue first, so these two should at least be fixed in close succession.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9357efcc40d785828b457ce7d6a020691593e99

commit d9357efcc40d785828b457ce7d6a020691593e99
Author: fs <fs@opera.com>
Date: Fri Jul 22 23:38:41 2016

Don't resolve non-local -webkit-clip-path references as local

Whether the reference was local or not was disregarded, meaning that
any URL with a valid fragment part could potential result in a valid
clip - regardless of whether it was local or not. I.e foo.svg#bar would
reference an element with the id 'bar' in the local document.

Check if the URL reference resolver flagged the reference as being local,
and only pass a non-null fragment if it was.

BUG= 629826 

Review-Url: https://codereview.chromium.org/2174813003
Cr-Commit-Position: refs/heads/master@{#407300}

[add] https://crrev.com/d9357efcc40d785828b457ce7d6a020691593e99/third_party/WebKit/LayoutTests/css3/masking/clip-path-reference-nonexisting-existing-local-expected.html
[add] https://crrev.com/d9357efcc40d785828b457ce7d6a020691593e99/third_party/WebKit/LayoutTests/css3/masking/clip-path-reference-nonexisting-existing-local.html
[modify] https://crrev.com/d9357efcc40d785828b457ce7d6a020691593e99/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

Comment 2 by f...@opera.com, Jul 23 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment