New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629825 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 474921
issue 625353



Sign in to add a comment

V8 is compiled twice for custom v8_target_cpu if custom_toolchain isn't specified as well

Project Member Reported by machenb...@chromium.org, Jul 20 2016

Issue description

As a result of https://codereview.chromium.org/2116183002/ if we specify a custom v8_target_cpu and not custom_toolchain, v8 is compiled twice.

E.g. specify:
target_cpu = "x86"
v8_target_cpu = "arm"

The resulting output folder has a clang_x86_v8_arm that includes mksnapshot. The other executables, e.g. d8 are in the main output folder. Both folders have subfolders with all the objects. Also the number of ninja tasks nearly doubled (not sure if they're deduped through goma on-the-fly).

Now lets add:
custom_toolchain = "//build/toolchain/linux:clang_x86_v8_arm"

Now everything is as before (in gyp). All executables are in the main output folder.

---

If this behavior can't be fixed, I'd at least suggest an assertion requiring explicit custom_toolchain to avoid the double compilation.
 
Owner: dpranke@chromium.org
Status: Assigned (was: Untriaged)
Ah, interesting. Yes, custom_toolchain would be one way to solve this, but we should be  able to do better. I'll think about how.
Status: Started (was: Assigned)
Proposed fix: https://codereview.chromium.org/2166173002/ .
Labels: OS-All
Fix #3 was abandoned.

Fix #4: https://codereview.chromium.org/2173343002/
Status: Fixed (was: Started)
Labels: Proj-GN-Migration-V8

Sign in to add a comment