New issue
Advanced search Search tips

Issue 629818 link

Starred by 0 users
Status: Fixed
Owner:
b...@chromium.org
Closed: Jul 2016
Cc:
rch@chromium.org
tfarina@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Remove flip_server.

Project Member Reported by b...@chromium.org, Jul 20 2016 
src/net/tools/flip_server/ has not been used for a long time, but poses some maintenance burden.  For example:
* class SpdySM and class SpdyFramerVisitor both implement BufferedSpdyFramerVisitorInterface, so methods signatures need to be kept in sync;
* it has happened to me twice during the past year that a CL passed CQ but had to be reverted because it broke the build, due to inconsistencies between build targets.

This issue includes removing:
* src/net/tools/flip_server/
* flip_in_mem_edsm_server, flip_in_mem_edsm_server_base, flip_in_mem_edsm_server_unittests targets,
* functions only used by flip_server, for example, BufferedSpdyFramer::CreateSynStream() and CreateSynReply().
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69866a47ebf38e14e330e15de944a695458c3141

commit 69866a47ebf38e14e330e15de944a695458c3141
Author: bnc <bnc@chromium.org>
Date: Thu Jul 21 12:03:21 2016

Remove flip_server.

* Remove src/net/tools/flip_server/.
* Remove //net:flip_in_mem_edsm_server, //net:flip_in_mem_edsm_server_base,
  //net:flip_in_mem_edsm_server_unittests.
* Remove now unused BufferedSpdyFramer::CreateSynStream() and
  BufferedSpdyFramer::CreateSynReply() methods.

BUG= 629818 

Review-Url: https://codereview.chromium.org/2169503002
Cr-Commit-Position: refs/heads/master@{#406822}

[modify] https://crrev.com/69866a47ebf38e14e330e15de944a695458c3141/BUILD.gn
[modify] https://crrev.com/69866a47ebf38e14e330e15de944a695458c3141/build/gn_migration.gypi
[modify] https://crrev.com/69866a47ebf38e14e330e15de944a695458c3141/net/BUILD.gn
[modify] https://crrev.com/69866a47ebf38e14e330e15de944a695458c3141/net/DEPS
[modify] https://crrev.com/69866a47ebf38e14e330e15de944a695458c3141/net/net.gyp
[modify] https://crrev.com/69866a47ebf38e14e330e15de944a695458c3141/net/spdy/buffered_spdy_framer.cc
[modify] https://crrev.com/69866a47ebf38e14e330e15de944a695458c3141/net/spdy/buffered_spdy_framer.h
[modify] https://crrev.com/69866a47ebf38e14e330e15de944a695458c3141/net/tools/DEPS
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/acceptor_thread.cc
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/acceptor_thread.h
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/constants.h
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/flip_config.cc
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/flip_config.h
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/flip_in_mem_edsm_server.cc
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/flip_test_utils.cc
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/flip_test_utils.h
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/http_interface.cc
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/http_interface.h
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/http_interface_test.cc
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/mem_cache.cc
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/mem_cache.h
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/mem_cache_test.cc
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/output_ordering.cc
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/output_ordering.h
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/ring_buffer.cc
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/ring_buffer.h
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/run_all_tests.cc
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/sm_connection.cc
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/sm_connection.h
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/sm_interface.h
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/spdy_interface.cc
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/spdy_interface.h
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/spdy_interface_test.cc
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/spdy_ssl.cc
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/spdy_ssl.h
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/spdy_util.cc
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/spdy_util.h
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/streamer_interface.cc
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/streamer_interface.h
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/tcp_socket_util.cc
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/tcp_socket_util.h
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/url_to_filename_encoder.cc
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/url_to_filename_encoder.h
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/url_to_filename_encoder_unittest.cc
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/url_utilities.cc
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/url_utilities.h
[delete] https://crrev.com/ce7e217303925cfec9b453ff745e9ebb5f120d95/net/tools/flip_server/url_utilities_unittest.cc

Comment 2 by b...@chromium.org, Jul 21 2016

Status: Fixed (was: Started)
►

Sign in to add a comment