New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629816 link

Starred by 4 users

Issue metadata

Status: WontFix
Owner:
Closed: Jul 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Update hover/press effects for buttons in the new MD user menu

Reported by dmascare...@etouch.net, Jul 20 2016

Issue description

Chrome Version:54.0.2802.0 Revision fc6aaca4ed6ff4f050e6f5c7fb19af85da8db574-refs/heads/master@{#406441}(64 bit)
OS: Mac (10.10.5,10.11.4)

Pre-condition: 1. Enable material design user menu flag.

What steps will reproduce the problem?
1. Launch chrome,Open Ntp and click on avatar icon such that overlay opens
2. Hover the mouse over default profile icon and Observe text within desktop user menu revamp.
3. Click ‘sign in to chrome’ and sign in with valid credential.
4. Go to 'chrome://settings' and add/import a Supervised User from 'People' section.
5. Switch to Supervised User and observe the avatar icon in top R.H.S.

Actual: 1. On hovering, colour of hover effect and default profile icon background is same.
        2. Unnecessary space is seen on R.H.S of the text within desktop user menu revamp.
        3. In Supervised User, avatar icon image hide behind supervise profile logo.

Expected: 1. On hovering,colour of hover effect and default profile icon background should be different.
          2. Space should not be seen on R.H.S of the overlay.
          3. In Supervised User, avatar icon image should be properly seen.

This is regression issue, broken in 'M 54’ and below is narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/8cc17dd5bd16119157decba981d11f1e217052dd..e6fcf92ec826c6b56672eec154e2075b1d01cf60?pretty=fuller&n=100

Suspecting: r406377 

Good build:54.0.2801.0
Bad build:54.0.2802.0

Note: Issue is not seen Windows and Linux OS.

 
icon.png
145 KB View Download
Labels: ReleaseBlock-Stable
Adding Release block label, please undo if not the case.
Material design user menu is still a WIP. To explain the above three behaviors:
1. The hover color and icon color aren't exactly the same, but I did notice that they are really close. However, the color of the hover effect is defined to be consistent across all buttons on Mac, while the default icon image is the same across all platforms, so I imagine the change to be very involved if we want to tackle this. 
2. The signin promo text shares the exact same text, width/padding spec, and layout code as the text on the current user menu; the only difference is that the new menu is 10px narrower, resulting in an earlier cut in the lines, hence the seeming extra space. I imagine it would stay this way unless we tweak the sentences. (Attached is a screenshot to show that the space is indeed only due to long words.)
3. The supervised profile logo UI is still a WIP. I'm waiting to get an updated icon from the UI folks and then add a reduced-sized logo. This was mentioned as a TODO in the code.

I will add our UI designer here to add some thoughts on 1 and 2, and decide if we want to tackle them. Thanks!
User menu text.png
23.7 KB View Download
Cc: cl...@chromium.org
Hi Chris, can you take a look at comment #2 and provide some guidance?  Thanks.
@cleer: Gentle Ping, Request you to please take a look into it.
Chris@ : Gentle Ping.! Could you please take a look into this and update further.
Updates:
1. I will be updating the button press/hover effect color to be the following across windows and mac: 
hover: #000 0.08a
pressed and active: #000 0.12a
2. @Chris, do we want to tweak the signin promo sentence so that it doesn't look like there's too much space on the RHS?
3. FYI we have a bug tracking the UI work for the new supervised badge: https://buganizer.corp.google.com/issues/29914003. Once we have the new svg, I will update the icon on both windows and mac.
Thanks!

Comment 7 by ew...@chromium.org, Aug 8 2016

Labels: md-usermenu

Comment 8 by ew...@chromium.org, Aug 9 2016

Labels: -ReleaseBlock-Stable
Removing the RBS label.

Re 2: I don't think it's worth tweaking the signin promo sentence to remove the space on the RHS. This topic has come up before, and we've decided against doing so in the past. I'll let Chris comment if he feels differently.
Updates:

1. Button hover/press color: We are in the process of updating the hover/press effect of the menu buttons. We need to first wait for https://codereview.chromium.org/2250783002/ or something similar to land, and then update the menu buttons to use InkDropHighlight only as hover/press effect (but not InkDropRipple). This will probably happen after I leave. 

2. Signin promo sentence (extra space): I don't think we are tweaking the sentence to remove the space.

3. New supervised badge: This issue should have been fixed by the follow CLs on all platforms:
https://chromium.googlesource.com/chromium/src/+/d5141f56dc92d1400988bfabb5170dd48731ee4f
https://chromium.googlesource.com/chromium/src/+/441da708943b005941af140a1364c0b305eafa4c
The new badge icons don't block the profile icons.

Thanks!

Comment 10 by ew...@chromium.org, Aug 26 2016

Cc: rogerta@chromium.org
Owner: anthonyvd@chromium.org
Summary: Update hover/press effects for buttons in the new MD user menu (was: Regression: Unnecessary space is seen on R.H.S of the text within desktop user menu revamp and Supervised icon image is not properly visible.)
Renaming this bug to more accurately reflect the only outstanding work.

Reassigning to Anthony to take now that Jane is leaving.
Project Member

Comment 11 by sheriffbot@chromium.org, Dec 19 2016

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: ew...@chromium.org
+ewald to figure out if this is still relevant since I no longer work on Identity.

Comment 13 by ew...@chromium.org, Apr 26 2017

Cc: ew...@chromium.org
Labels: -Pri-1 -hasbisect -M-54 -Type-Bug-Regression -md-usermenu Pri-2 Type-Bug
Owner: jlebel@chromium.org
Status: Assigned (was: Available)
Jerome, this is related to the user menu.

Sounds like we wanted to update the pressed/active and hover color for the user menu buttons across Win and Mac (see comment #6 and #9).
Project Member

Comment 14 by sheriffbot@chromium.org, May 29 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 15 Deleted

Comment 16 by ew...@chromium.org, Jun 28 2017

Cc: jlebel@chromium.org pkasting@chromium.org
Labels: -Pri-2 OS-Windows Pri-3
Owner: ----
I don't think the signin team is going to have the bandwidth to take on this bug any time in the near future.

+Peter for desktop, in case someone on the desktop team that's been working on the user menu recently could look into this. All that's left is updating the hover/pressed effects of the buttons in the user menu (see comments #6 and #9).
Owner: tapted@chromium.org
Status: Assigned (was: Available)
tapted is already working on button colors for Harmony, so hopefully this will Just Get Fixed by that.
Project Member

Comment 18 by sheriffbot@chromium.org, Jul 31 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 19 by sheriffbot@chromium.org, Jul 30

Cc: droger@chromium.org msarda@chromium.org tangltom@chromium.org sabineb@chromium.org bsazonov@chromium.org
--Chrome Identity automated triaging--

This bug is Available and has gone one year without any activity. If another month passes without any activity, this bug will be closed out. Please provide an update with the latest status for this bug. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: Available)
Obsolete with MD redesign in 69

Sign in to add a comment