New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 629811 link

Starred by 2 users
Status: Fixed
Owner:
█ tsergeant@chromium.org
Not on Chrome
Closed: Aug 2016
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: The fonts in the iron icon do not change to "Very small" in Autofill overlay on MD settings

Reported by lpa...@etouch.net, Jul 20 2016 
Chrome Version: 54.0.2802.0 (Official Build) fc6aaca4ed6ff4f050e6f5c7fb19af85da8db574-refs/heads/master@{#406441} (32/64 bit)
OS: Windows(7,8,8.1,10), Linux (Ubuntu 14.04 LTS), Mac (10.10.5, 10.11.4).

Steps:
1. Launch chrome and navigate to chrome://md-settings and change the font size to "Very small".
2. Now go to Auto fill and save a Credit Card/Address form. Click on the iron icon of the saved form..
3. Observe. (Please review the attached screen cast for reference)

Actual  : The fonts in the iron icon do not change to "Very small".
Expected: The fonts in the iron icon should change to "Very small".

This is a regression issue broken in 'M-54' and below is the Manual Regression range.
Good Build: 54.0.2797.0
Bad Build : 54.0.2799.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/eb270c9af201e549f3e2e2b1016b6b99565f1706..4aab40a95c7c9f01d7c258c1095b13f5c75300eb?pretty=fuller&n=1000

Suspecting: r405666?

Kindly help to re-assign if your change is not the cause of this issue.
Actual_Font_Large.mp4
854 KB View Download
Expected_Font_Small.mp4
535 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d72249ba3fa4ab9671cf9327aa58e7f5a86868b1

commit d72249ba3fa4ab9671cf9327aa58e7f5a86868b1
Author: tsergeant <tsergeant@chromium.org>
Date: Mon Aug 01 23:40:31 2016

MD Settings: Inherit font size in passwords/autofill shared menu

Switching to a native button element caused these elements to use the
default User Agent stylesheet fonts. This caused the menu items to
render in the system font rather than Roboto, and to not adjust to
changes in font size preferences.

BUG= 629811 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2202433002
Cr-Commit-Position: refs/heads/master@{#409088}

[modify] https://crrev.com/d72249ba3fa4ab9671cf9327aa58e7f5a86868b1/chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html

Comment 2 by tsergeant@chromium.org, Aug 1 2016

Status: Fixed (was: Assigned)

Comment 3 by ssamanoori@chromium.org, Aug 2 2016

Labels: TE-Verified-54.0.2816.0 TE-Verified-M54
Tested the issue on Windows 7, Mac 10.11.5, Ubuntu 14.04 using 54.0.2816.0. Observed that the fonts in the iron icon changed to "Very small" in Autofill overlay on MD settings.
Please find attached screencast.

Marking it as TE-Verified.
629811.mp4
540 KB View Download
►

Sign in to add a comment